- rpmlint ok
- naming ok
! shouldn't use %makeinstall
- license is GPL and included in doc files
- md5sum is good
- builds fine on fc5 x86_64
- uses find_lang
! need desktop file and icon?
! doesn't build in mock:
checking for XML::Parser... configure: error: XML::Parser perl module is
required for intltool
! there seems to be a small bug in how it handles user-defined configs: if one
clicks on the selector showing "User defined", and then clicks somewhere else,
the selector changes to "scim" and a symlink to "User specific" is created.

I attach a spec file with some fixes.

Created attachment 132157 [details]
im-chooser.spec-1.patch

Thanks. updated.

Spec URL: http://people.redhat.com/tagoh/im-chooser/im-chooser.spec
SRPM URL: http://people.redhat.com/tagoh/im-chooser/im-chooser-0.2.1-1.src.rpm

I can't reproduce the last comment however. if you have the exact steps to
reproduce it, it would be appreciated.

(In reply to comment #3)
> I can't reproduce the last comment however. if you have the exact steps to
> reproduce it, it would be appreciated.

Ok, I don't think it is a blocking issue (it needs to be a file
not a symlink to reproduce it btw) and by "clicks somewhere
else" I meant clicking away from the selector to cancel any change
or clicking on "User defined" ("User specific").

I get this error now in mock:

Making all in po
make[2]: Entering directory `/builddir/build/BUILD/im-chooser-0.2.1/po'
file=`echo ja | sed 's,.*/,,'`.gmo \
  && rm -f $file &&  -o $file ja.po
/bin/sh: -o: command not found
make[2]: *** [ja.gmo] Error 127

Otherwise the package looks good.

I think you need to BR gettext for msgfmt.

Feel to import it into extras cvs for more eyes to see it.
This is an important package for i18n.

Builds ok in mock on fc5 with BR gettext.

Thanks for the import.  APPROVED.

imported and built into devel.