Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1979278

Summary: timemaster service fails to start on single domain with multiple interfaces
Product: Red Hat OpenStack Reporter: Haresh Khandelwal <hakhande>
Component: tripleo-ansibleAssignee: Haresh Khandelwal <hakhande>
Status: CLOSED DUPLICATE QA Contact: Joe H. Rahme <jhakimra>
Severity: medium Docs Contact:
Priority: medium    
Version: 16.2 (Train)CC: aschultz, cfields, kfida, lmartins, mbultel
Target Milestone: z2Keywords: Triaged
Target Release: 16.2 (Train on RHEL 8.4)   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2021-09-16 12:07:51 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Haresh Khandelwal 2021-07-05 12:56:00 UTC
Description:

Current jinja template (timemaster.conf.j2) is having below.

{% for domain, nic_list in ptp_dict.items() %}
[ptp_domain {{ domain }}]
interfaces {% for nic in nic_list %}
{{ nic }}{% if not loop.last %},{% endif %}
{% endfor %}

{% endfor %}

Due to this, when below is passed via THT,
PTPInterfaces: '0:eno1,0:eno2'

results in to

[ptp_domain 0]
interfaces eno1,eno2

timemaster service fails with this message.

[root@computedpdk-0 heat-admin]# systemctl status timemaster
● timemaster.service - Synchronize system clock to NTP and PTP time sources
   Loaded: loaded (/usr/lib/systemd/system/timemaster.service; enabled; vendor preset: disabled)
   Active: failed (Result: exit-code) since Mon 2021-07-05 12:12:05 UTC; 4s ago
  Process: 169838 ExecStart=/usr/sbin/timemaster -f /etc/timemaster.conf (code=exited, status=1/FAILURE)
 Main PID: 169838 (code=exited, status=1/FAILURE)

Jul 05 12:12:05 hareshcomputedpdk-0 systemd[1]: timemaster.service: Succeeded.
Jul 05 12:12:05 hareshcomputedpdk-0 systemd[1]: Stopped Synchronize system clock to NTP and PTP time sources.
Jul 05 12:12:05 hareshcomputedpdk-0 systemd[1]: Started Synchronize system clock to NTP and PTP time sources.
Jul 05 12:12:05 hareshcomputedpdk-0 timemaster[169838]: timemaster[532409.195]: ioctl SIOCETHTOOL failed: No such device
Jul 05 12:12:05 hareshcomputedpdk-0 timemaster[169838]: timemaster[532409.195]: failed to get time stamping info for eno1,eno2 <<<<<<<<<<<<<<<<<<<<
Jul 05 12:12:05 hareshcomputedpdk-0 systemd[1]: timemaster.service: Main process exited, code=exited, status=1/FAILURE
Jul 05 12:12:05 hareshcomputedpdk-0 systemd[1]: timemaster.service: Failed with result 'exit-code'.

Version-Release number of selected component (if applicable):
16.2

How reproducible:
Always

Steps to Reproduce:
- Perform deployment with above mentioned PTPInternface value.

Expected result:
Ideally, we should have

[ptp_domain 0]
interfaces eno1 eno2 <<<<No ","

To start timemaster service successfully.

Actual results:
Failed timemaster service on the node.

Expected results:
start timemaster service successfully with provided interfaces
We need to replace "," with "" in order to generate working template.

Additional info:

Comment 3 Karrar Fida 2021-09-16 12:07:51 UTC

*** This bug has been marked as a duplicate of bug 1979282 ***