RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1979425 - kselftest/tc-testing: u32.json failed to match
Summary: kselftest/tc-testing: u32.json failed to match
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 8
Classification: Red Hat
Component: iproute
Version: 8.5
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: beta
: ---
Assignee: Andrea Claudi
QA Contact: Mingyu Shi
URL:
Whiteboard:
Depends On:
Blocks: 1704655
TreeView+ depends on / blocked
 
Reported: 2021-07-06 01:52 UTC by Hangbin Liu
Modified: 2021-11-10 07:48 UTC (History)
5 users (show)

Fixed In Version: iproute-5.12.0-3.el8
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-11-09 19:37:07 UTC
Type: Bug
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2021:4389 0 None None None 2021-11-09 19:37:23 UTC

Description Hangbin Liu 2021-07-06 01:52:29 UTC
Description of problem:
tc-testing/tc-tests/filters/u32.json 0692 and 2478 failed to match the output

Version-Release number of selected component (if applicable):
4.18.0-320.el8.x86_64

How reproducible:


Steps to Reproduce:
1. install related kselftest rpm
2. ./tdc.py -f tc-tests/filters/u32.json
3.

Actual results:
ok 8 74c2 - Add/Replace u32 filter with invalid hash table id
ok 9 1fe6 - Replace valid u32 filter with invalid hash table id
not ok 10 0692 - Test u32 sample option, divisor 256
        Could not match regex pattern. Verify command output:
filter protocol all pref 99 u32 chain 0
filter protocol all pref 99 u32 chain 0 fh 1: ht divisor 256
filter protocol all pref 99 u32 chain 0 fh 1:40:800 order 2048 key ht 1 bkt 40 flowid 1:1 not_in_hw
  match 00000000/00000000 at 0
filter protocol all pref 99 u32 chain 0 fh 1:40:801 order 2049 key ht 1 bkt 40 flowid 1:1 not_in_hw
  match 00000000/00000000 at 0
filter protocol all pref 99 u32 chain 0 fh 1:50:800 order 2048 key ht 1 bkt 50 flowid 1:1 not_in_hw
  match 00000000/00000000 at 0
filter protocol all pref 99 u32 chain 0 fh 1:50:801 order 2049 key ht 1 bkt 50 flowid 1:1 not_in_hw
  match 00000000/00000000 at 0
filter protocol all pref 99 u32 chain 0 fh 1:60:800 order 2048 key ht 1 bkt 60 flowid 1:1 not_in_hw
  match 00000000/00000000 at 0
filter protocol all pref 99 u32 chain 0 fh 1:70:800 order 2048 key ht 1 bkt 70 flowid 1:1 not_in_hw
  match 00000000/00000000 at 0
filter protocol all pref 99 u32 chain 0 fh 1:70:801 order 2049 key ht 1 bkt 70 flowid 1:1 not_in_hw
  match 00000000/00000000 at 0
filter protocol all pref 99 u32 chain 0 fh 800: ht divisor 1


not ok 11 2478 - Test u32 sample option, divisor 16
        Could not match regex pattern. Verify command output:
filter protocol all pref 99 u32 chain 0
filter protocol all pref 99 u32 chain 0 fh 1: ht divisor 256
filter protocol all pref 99 u32 chain 0 fh 1:40:800 order 2048 key ht 1 bkt 40 flowid 1:1 not_in_hw
  match 00000000/00000000 at 0
filter protocol all pref 99 u32 chain 0 fh 1:40:801 order 2049 key ht 1 bkt 40 flowid 1:1 not_in_hw
  match 00000000/00000000 at 0
filter protocol all pref 99 u32 chain 0 fh 1:40:802 order 2050 key ht 1 bkt 40 flowid 1:1 not_in_hw
  match 00000000/00000000 at 0
filter protocol all pref 99 u32 chain 0 fh 1:60:800 order 2048 key ht 1 bkt 60 flowid 1:1 not_in_hw
  match 00000000/00000000 at 0
filter protocol all pref 99 u32 chain 0 fh 1:70:800 order 2048 key ht 1 bkt 70 flowid 1:1 not_in_hw
  match 00000000/00000000 at 0
filter protocol all pref 99 u32 chain 0 fh 800: ht divisor 1


Expected results:
ok 9 1fe6 - Replace valid u32 filter with invalid hash table id
ok 10 0692 - Test u32 sample option, divisor 256
ok 11 2478 - Test u32 sample option, divisor 16


Additional info:
https://lore.kernel.org/netdev/20210202183051.21022-1-phil@nwl.cc

Comment 1 Hangbin Liu 2021-07-06 01:54:36 UTC
The tc test was added in bug 1946986

Comment 3 Andrea Claudi 2021-08-09 13:08:39 UTC
Hi Hangbin, unfortunately that patch is not applied (yet) upstream, and we are pretty close to the release+ deadline, unfortunately. Would it be ok, in case it will not get merged in time, to postpone this to rhel-8.6?

Comment 4 Hangbin Liu 2021-08-11 09:51:14 UTC
(In reply to Andrea Claudi from comment #3)
> Hi Hangbin, unfortunately that patch is not applied (yet) upstream, and we
> are pretty close to the release+ deadline, unfortunately. Would it be ok, in
> case it will not get merged in time, to postpone this to rhel-8.6?

It's OK for me. I can mark this failure as a known issue.

Comment 5 Andrea Claudi 2021-08-11 11:16:06 UTC
Hi Mingyu, can you please consider to set itm and grant qa_ack+ on this? The fix is finally upstream and it's contained on the u32 filter code. Also, it is easy to test using kselftest as in the first comment.

Comment 9 Mingyu Shi 2021-08-19 02:24:40 UTC
iproute-5.12.0-3.el8.x86_64

dnf install kernel-selftests-internal
cd /usr/libexec/kselftests/tc-testing/
 ./tdc.py -f tc-tests/filters/u32.json

Got the output:
 -- ns/SubPlugin.__init__
Test afa9: Add u32 with source match
Test 6aa7: Add/Replace u32 with source match and invalid indev
Test bc4d: Replace valid u32 with source match and invalid indev
Test 648b: Add u32 with custom hash table
Test 6658: Add/Replace u32 with custom hash table and invalid handle
Test 9d0a: Replace valid u32 with custom hash table and invalid handle
Test 1644: Add u32 filter that links to a custom hash table
Test 74c2: Add/Replace u32 filter with invalid hash table id
Test 1fe6: Replace valid u32 filter with invalid hash table id
Test 0692: Test u32 sample option, divisor 256
Test 2478: Test u32 sample option, divisor 16

All test results: 

1..11
ok 1 afa9 - Add u32 with source match
ok 2 6aa7 - Add/Replace u32 with source match and invalid indev
ok 3 bc4d - Replace valid u32 with source match and invalid indev
ok 4 648b - Add u32 with custom hash table
ok 5 6658 - Add/Replace u32 with custom hash table and invalid handle
ok 6 9d0a - Replace valid u32 with custom hash table and invalid handle
ok 7 1644 - Add u32 filter that links to a custom hash table
ok 8 74c2 - Add/Replace u32 filter with invalid hash table id
ok 9 1fe6 - Replace valid u32 filter with invalid hash table id
ok 10 0692 - Test u32 sample option, divisor 256
ok 11 2478 - Test u32 sample option, divisor 16

Comment 11 errata-xmlrpc 2021-11-09 19:37:07 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (iproute bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2021:4389


Note You need to log in before you can comment on or make changes to this bug.