RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1979523 - annocheck failures about -fstack-clash-protection not enabled in /usr/bin/nm-applet
Summary: annocheck failures about -fstack-clash-protection not enabled in /usr/bin/nm-...
Keywords:
Status: CLOSED DUPLICATE of bug 1978176
Alias: None
Product: Red Hat Enterprise Linux 9
Classification: Red Hat
Component: annobin
Version: 9.0
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: beta
: ---
Assignee: Nick Clifton
QA Contact: qe-baseos-tools-bugs
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-07-06 09:45 UTC by Beniamino Galvani
Modified: 2021-09-20 09:14 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-07-06 12:45:48 UTC
Type: Bug
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)

Description Beniamino Galvani 2021-07-06 09:45:52 UTC 
We see some annocheck failures in nm-applet gating for RHEL 9.0:

http://artifacts.osci.redhat.com/testing-farm/b6efec43-5349-4c16-9c50-2036ca424e26/work-rpminspect1oMA1A/rpminspect/execute/data/annocheck/output.txt
https://brewweb.engineering.redhat.com/brew/buildinfo?buildID=1654292

The error is:

Hardened: /usr/bin/nm-applet: FAIL: stack-clash test because -fstack-clash-protection not enabled (function: resource_destructor)

Function resource_destructor() is in generated file src/applet-resources.c which is compiled with -fstack-clash-protection:

[4/69] gcc -Isrc/nm-applet.p -Isrc -I../src -I. -I.. -Isrc/utils -I../src/utils -Ishared -I../shared -Isrc/wireless-security -I../src/wireless-security -I/usr/include/gtk-3.0 -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/sysprof-4 -I/usr/include/harfbuzz -I/usr/include/freetype2 -I/usr/include/libpng16 -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/fribidi -I/usr/include/libxml2 -I/usr/include/cairo -I/usr/include/pixman-1 -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/gio-unix-2.0 -I/usr/include/atk-1.0 -I/usr/include/at-spi2-atk/2.0 -I/usr/include/dbus-1.0 -I/usr/lib64/dbus-1.0/include -I/usr/include/at-spi-2.0 -I/usr/include/libnm -I/usr/include/libnma -I/usr/include/libsecret-1 -I/usr/include/libmm-glib -I/usr/include/ModemManager -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -std=gnu99 -fdata-sections -ffunction-sections -O2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -mbranch-protection=standard -fasynchronous-unwind-tables -fstack-clash-protection -pthread -DGLIB_VERSION_MIN_REQUIRED=GLIB_VERSION_2_38 -DGLIB_VERSION_MAX_ALLOWED=GLIB_VERSION_2_38 -DNM_VERSION_MIN_REQUIRED=NM_VERSION_1_16 -DNM_VERSION_MAX_ALLOWED=NM_VERSION_1_16 -DNMA_VERSION_MIN_REQUIRED=NMA_VERSION_1_8_28 -DNMA_VERSION_MAX_ALLOWED=NMA_VERSION_1_8_28 -DGDK_VERSION_MIN_REQUIRED=GDK_VERSION_3_10 -DGDK_VERSION_MAX_ALLOWED=GDK_VERSION_3_10 '-DBINDIR="/usr/bin"' '-DDATADIR="/usr/share"' '-DLIBDIR="/usr/lib64"' '-DLIBEXECDIR="/usr/libexec"' '-DNMALOCALEDIR="/usr/share/locale"' '-DSYSCONFDIR="/etc"' '-DAUTOSTARTDIR="/etc/xdg/autostart"' '-DICONDIR="/usr/share/icons"' '-DG_LOG_DOMAIN="nm-applet"' -MD -MQ src/nm-applet.p/meson-generated_.._applet-resources.c.o -MF src/nm-applet.p/meson-generated_.._applet-resources.c.o.d -o src/nm-applet.p/meson-generated_.._applet-resources.c.o -c src/applet-resources.c

Also the link step uses -fstack-clash-protection:

[69/69] gcc  -o src/nm-applet src/nm-applet.p/meson-generated_.._applet-resources.c.o src/nm-applet.p/ap-menu-item.c.o src/nm-applet.p/applet-agent.c.o src/nm-applet.p/applet.c.o src/nm-applet.p/applet-device-bt.c.o src/nm-applet.p/applet-device-ethernet.c.o src/nm-applet.p/applet-device-wifi.c.o src/nm-applet.p/applet-dialogs.c.o src/nm-applet.p/applet-vpn-request.c.o src/nm-applet.p/ethernet-dialog.c.o src/nm-applet.p/main.c.o src/nm-applet.p/mb-menu-item.c.o src/nm-applet.p/mobile-helpers.c.o src/nm-applet.p/applet-device-broadband.c.o -Wl,--as-needed -Wl,--no-undefined -Wl,--whole-archive -Wl,--start-group src/wireless-security/libwireless-security-libnm.a -Wl,--no-whole-archive -Wl,--gc-sections -O2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -mbranch-protection=standard -fasynchronous-unwind-tables -fstack-clash-protection -Wl,-z,relro -Wl,--as-needed -Wl,-z,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld src/utils/libutils-libnm.a -Wl,--version-script,/builddir/build/BUILD/network-manager-applet-1.22.0/linker-script-binary.ver /usr/lib64/libgtk-3.so /usr/lib64/libgdk-3.so /usr/lib64/libpangocairo-1.0.so /usr/lib64/libpango-1.0.so /usr/lib64/libharfbuzz.so /usr/lib64/libatk-1.0.so /usr/lib64/libcairo-gobject.so /usr/lib64/libcairo.so /usr/lib64/libgdk_pixbuf-2.0.so /usr/lib64/libgio-2.0.so /usr/lib64/libgobject-2.0.so /usr/lib64/libglib-2.0.so -Wl,--export-dynamic /usr/lib64/libgmodule-2.0.so -pthread /usr/lib64/libnm.so /usr/lib64/libnma.so /usr/lib64/libnotify.so /usr/lib64/libsecret-1.so -lm /usr/lib64/libmm-glib.so -Wl,--end-group

Is there anything wrong in the build process, or is this a problem in annobin?
Comment 1 Nick Clifton 2021-07-06 12:45:48 UTC 
(In reply to Beniamino Galvani from comment #0)
Hi Benjamin,

> http://artifacts.osci.redhat.com/testing-farm/b6efec43-5349-4c16-9c50-
> 2036ca424e26/work-rpminspect1oMA1A/rpminspect/execute/data/annocheck/output.
> txt

There is a clue in this log, just before the FAIL result:

  Hardened: Hardened: /usr/bin/nm-applet: The annobin plugin was built by an older version of the compiler.
  Hardened: debug: Annobin plugin was built by gcc 11.0.1 but run on gcc version 11.1.1.
  Hardened: debug: If there are WARN or FAIL results that appear to be incorrect, it could be due to this discrepancy.

> Is there anything wrong in the build process, or is this a problem in
> annobin?

It is a problem with annobin (or rather annobin vs gcc) - please feel free to waive the result.

This problem has also been reported in BZ 1978176, so I am going to close this BZ.

Cheers
  Nick

*** This bug has been marked as a duplicate of bug 1978176 ***
Note You need to log in before you can comment on or make changes to this bug.