Spec URL: https://download.copr.fedorainfracloud.org/results/mhayden/azure-cli/fedora-rawhide-x86_64/02315302-python-applicationinsights/python-applicationinsights.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/mhayden/azure-cli/fedora-rawhide-x86_64/02315302-python-applicationinsights/python-applicationinsights-0.11.10-1.fc35.src.rpm Description: Python support for Azure Application Insights API Fedora Account System Username: mhayden
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated ===== Issues ===== - The only reason to write “%{python3_pkgversion}” is for EPEL compatibility—and, really, it is probably only needed for EPEL7, where it may have a value other than “3”. Since you are using pyproject-rpm-macros, which are not available on these EPELs, please just replace each occurrence with “3”. - You should run the tests. Add: BuildRequires: python3-test and: %check PYTHONPATH=%{buildroot}/%{python3_sitelib} \ %{__python3} -m unittest discover ./tests/ ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "MIT License", "*No copyright* MIT License". 97 files have unknown license. Detailed output of licensecheck in /home/reviewer/1979724-python- applicationinsights/licensecheck.txt [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. https://bugzilla.redhat.com/show_bug.cgi?id=1953789 [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: No rpmlint messages. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. Tests are available and should be run. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python3-applicationinsights-0.11.10-1.fc35.noarch.rpm python-applicationinsights-0.11.10-1.fc35.src.rpm 2 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output: Source checksums ---------------- https://files.pythonhosted.org/packages/source/a/applicationinsights/applicationinsights-0.11.10.tar.gz : CHECKSUM(SHA256) this package : 0b761f3ef0680acf4731906dfc1807faa6f2a57168ae74592db0084a6099f7b3 CHECKSUM(SHA256) upstream package : 0b761f3ef0680acf4731906dfc1807faa6f2a57168ae74592db0084a6099f7b3 Requires -------- python3-applicationinsights (rpmlib, GLIBC filtered): python(abi) Provides -------- python3-applicationinsights: python-applicationinsights python3-applicationinsights python3.10-applicationinsights python3.10dist(applicationinsights) python3dist(applicationinsights) Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10 Command line :/usr/bin/fedora-review -b 1979724 Buildroot used: fedora-rawhide-aarch64 Active plugins: Generic, Shell-api, Python Disabled plugins: Perl, fonts, Ocaml, SugarActivity, Java, Haskell, C/C++, R, PHP Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
So the %{python3_pkgversion} was in my local copy, but I guess I built the SRPM before committing those changes. 🤦🏻♂️ As for the tests, the azure tests require two bits of helper code from the git repository itself that are not installable on their own and they are not published to pypi. In addition, the majority of the tests need network access to download certain things and talk to Azure's API. That's why I haven't found a way to run tests here yet. If I try your testing method, I get: ImportError: Start directory is not importable: './tests/' pytest *does* work, but then I run into the network access problems and the missing helpers from the upstream repository. The whole upstream repository is about ~ 150-160MB and each of these little components are released independently from that repository.
> As for the tests, the azure tests require two bits of helper code from the git repository itself that are not installable on their own and they are not published to pypi. In addition, the majority of the tests need network access to download certain things and talk to Azure's API. That's why I haven't found a way to run tests here yet. That makes sense, and if the tests prove to be un-runnable, I think that ought to go in a spec file comment where the %check section would be. > If I try your testing method, I get: > > ImportError: Start directory is not importable: './tests/' > > pytest *does* work, but then I run into the network access problems and the missing helpers from the upstream repository. The whole upstream repository is about ~ 150-160MB and each of these little components are released independently from that repository. This is strange. Here’s a koji build that worked for me (https://koji.fedoraproject.org/koji/taskinfo?taskID=71966298). Maybe that will help?
Created attachment 1802058 [details] Diff from your original spec to the koji build I linked
It’s possible that all of these tests are “passing” by being silently skipped or something like that—I haven’t investigated closely—but it at least acts like it’s running some tests.
Oof, I was looking at python-azure-mgmt-applicationinsights (the management library) by mistake. 🤦🏻♂️ Updated: Spec URL: https://download.copr.fedorainfracloud.org/results/mhayden/azure-cli/fedora-rawhide-x86_64/02331173-python-applicationinsights/python-applicationinsights.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/mhayden/azure-cli/fedora-rawhide-x86_64/02331173-python-applicationinsights/python-applicationinsights-0.11.10-1.fc35.src.rpm
Approved by inspection of the diff from the previous submission (but please do still change “%{python3_pkgversion}” to "3”—the macro is allowable but pointless in this case!). > --- ../1979724-python-applicationinsights/srpm-unpacked/python-applicationinsights.spec 2021-07-15 11:49:21.584855762 -0400 > +++ ./python-applicationinsights.spec 2021-07-15 20:06:57.785945336 -0400 > @@ -1,3 +1,6 @@ > +# tests are enabled by default > +%bcond_without tests > + > %global srcname applicationinsights > > Name: python-%{srcname} > @@ -15,6 +18,9 @@ > BuildRequires: python%{python3_pkgversion}-devel > BuildRequires: pyproject-rpm-macros > > +%if %{with tests} > +BuildRequires: python3-test > +%endif > > %global _description %{expand: > This project extends the Application Insights API surface to support Python} > @@ -48,6 +54,13 @@ > %pyproject_save_files applicationinsights > > > +%if %{with tests} > +%check > +PYTHONPATH=%{buildroot}/%{python3_sitelib} \ > + %{__python3} -m unittest discover ./tests/ > +%endif > + > + > %files -n python3-%{srcname} -f %{pyproject_files} > %license LICENSE.txt > %doc README.rst
Thanks, Ben. I'll ensure that the change is in the RPM when it's imported.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-applicationinsights