Bug 1979780 - Review Request: rust-gmp-mpfr-sys - Rust FFI bindings for GMP, MPFR and MPC
Summary: Review Request: rust-gmp-mpfr-sys - Rust FFI bindings for GMP, MPFR and MPC
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Robert-André Mauchin 🐧
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-07-07 04:22 UTC by Davide Cavalca
Modified: 2022-07-20 01:38 UTC (History)
4 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2022-07-10 21:58:41 UTC
Type: ---
Embargoed:
eclipseo: fedora-review+


Attachments (Terms of Use)

Description Davide Cavalca 2021-07-07 04:22:22 UTC
Spec URL: https://dcavalca.fedorapeople.org/review/rust-gmp-mpfr-sys/rust-gmp-mpfr-sys.spec
SRPM URL: https://dcavalca.fedorapeople.org/review/rust-gmp-mpfr-sys/rust-gmp-mpfr-sys-1.4.5-1.fc35.src.rpm

Description:
Rust FFI bindings for GMP, MPFR and MPC.

Fedora Account System Username: dcavalca

Comment 1 Robert-André Mauchin 🐧 2022-01-23 15:24:26 UTC
 - Bump to 1.4.7

 - License ok
 - Builds in mock
 - No rpmlint errors
 - Conforms to Packaging Guidelines

Package approved.

Comment 2 Fabio Valentini 2022-01-23 17:24:55 UTC
This looks weird:

> # Upstream license specification: LGPL-3.0+
> %license LICENSE-GPL.md LICENSE-LGPL.md

Why does the crate contain both GPL and LGPL license texts if its license is only LGPL?

The crate also contains lots of files that should probably be excluded (for example, the "doc-c" directory seems to bundle documentation for the bundled C libraries).

Also, please regenerate the .spec file with rust2rpm 20 before building the crate for Fedora.

Comment 3 Davide Cavalca 2022-02-13 05:52:59 UTC
> Why does the crate contain both GPL and LGPL license texts if its license is only LGPL?

I suspect it's because GMP (which is wrapped by this crate) is dual licensed under LGPL and GPL.

> The crate also contains lots of files that should probably be excluded (for example, the "doc-c" directory seems to bundle documentation for the bundled C libraries).
> Also, please regenerate the .spec file with rust2rpm 20 before building the crate for Fedora.

Will fix on import, thanks!

$ fedpkg request-repo rust-gmp-mpfr-sys 1979780
https://pagure.io/releng/fedora-scm-requests/issue/42160

Comment 4 Igor Raits 2022-02-13 10:49:03 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-gmp-mpfr-sys

Comment 5 Fabio Valentini 2022-03-19 12:15:54 UTC
This package has been reviewed and created over a month ago. Please don't forget to import and build it, too.

Comment 6 Trevor Spiteri 2022-06-11 16:03:23 UTC
> Why does the crate contain both GPL and LGPL license texts if its license is only LGPL?

Because the LGPL 3 depends on the GPL 3. In fact, in the LGPL text there is:

> This version of the GNU Lesser General Public License incorporates the
> terms and conditions of version 3 of the GNU General Public License,
> supplemented by the additional permissions listed below.

That is, I think LICENSE-LGPL is incomplete without LICENSE-GPL.

Comment 7 Trevor Spiteri 2022-06-11 16:06:40 UTC
From <https://www.gnu.org/licenses/gpl-howto.html>:

> Please note that, since the LGPL is a set of additional permissions on top of the GPL, it's crucial to include both licenses so users have all the materials they need to understand their rights.

Comment 8 Fabio Valentini 2022-06-15 20:27:52 UTC
(In reply to Fabio Valentini from comment #5)
> This package has been reviewed and created over a month ago. Please don't
> forget to import and build it, too.

This still hasn't happened. :(

Comment 9 Fedora Update System 2022-07-10 21:57:12 UTC
FEDORA-2022-bcf570e7ad has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2022-bcf570e7ad

Comment 10 Fedora Update System 2022-07-10 21:58:41 UTC
FEDORA-2022-bcf570e7ad has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 11 Fedora Update System 2022-07-11 02:02:39 UTC
FEDORA-2022-d85941b958 has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-d85941b958

Comment 12 Fedora Update System 2022-07-11 03:13:46 UTC
FEDORA-2022-d825d8dd24 has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2022-d825d8dd24

Comment 13 Fedora Update System 2022-07-12 02:30:39 UTC
FEDORA-2022-d85941b958 has been pushed to the Fedora 36 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-d85941b958 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-d85941b958

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 14 Fedora Update System 2022-07-12 02:37:36 UTC
FEDORA-2022-d825d8dd24 has been pushed to the Fedora 35 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-d825d8dd24 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-d825d8dd24

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 15 Fedora Update System 2022-07-20 01:30:50 UTC
FEDORA-2022-d85941b958 has been pushed to the Fedora 36 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 16 Fedora Update System 2022-07-20 01:38:09 UTC
FEDORA-2022-d825d8dd24 has been pushed to the Fedora 35 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.