Spec URL: https://dcavalca.fedorapeople.org/review/golang-github-schollz-peerdiscovery/golang-github-schollz-peerdiscovery.spec SRPM URL: https://dcavalca.fedorapeople.org/review/golang-github-schollz-peerdiscovery/golang-github-schollz-peerdiscovery-1.6.6-1.fc35.src.rpm Description: Pure-Go library for cross-platform local peer discovery using UDP multicast. Fedora Account System Username: dcavalca
This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=71431718
Hello Davide, package is almost approved! Please update the version. The latest version of the upstream is v1.6.9. Thanks in advance, Hirotaka Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. [x]: Package does not own files or directories owned by other packages. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 7 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [!]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [!]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- $ rpmlint golang-github-schollz-peerdiscovery-1.6.6-1.fc36.src.rpm ===================================================== rpmlint session starts ===================================================== rpmlint: 2.1.0 configuration: /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/licenses.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 1 golang-github-schollz-peerdiscovery.spec: W: no-%build-section ====================== 1 packages and 0 specfiles checked; 0 errors, 1 warnings, 0 badness; has taken 0.4 s ====================== $ rpmlint golang-github-schollz-peerdiscovery-devel-1.6.6-1.fc36.noarch.rpm ===================================================== rpmlint session starts ===================================================== rpmlint: 2.1.0 configuration: /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/licenses.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 1 golang-github-schollz-peerdiscovery-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/schollz/peerdiscovery/.goipath golang-github-schollz-peerdiscovery-devel.noarch: W: files-duplicate /usr/share/gocode/src/github.com/schollz/peerdiscovery/README.md /usr/share/doc/golang-github-schollz-peerdiscovery-devel/README.md ====================== 1 packages and 0 specfiles checked; 0 errors, 2 warnings, 0 badness; has taken 0.1 s ====================== Source checksums ---------------- https://github.com/schollz/peerdiscovery/archive/v1.6.6/peerdiscovery-1.6.6.tar.gz : CHECKSUM(SHA256) this package : 0c75033a5b1d179957c99d60181d507e607ee650100c36d8604f99821f047557 CHECKSUM(SHA256) upstream package : 0c75033a5b1d179957c99d60181d507e607ee650100c36d8604f99821f047557 Requires -------- golang-github-schollz-peerdiscovery-devel (rpmlib, GLIBC filtered): go-filesystem golang(golang.org/x/net/ipv4) golang(golang.org/x/net/ipv6) Provides -------- golang-github-schollz-peerdiscovery-devel: golang(github.com/schollz/peerdiscovery) golang-github-schollz-peerdiscovery-devel golang-ipath(github.com/schollz/peerdiscovery) Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10 Command line :/usr/bin/fedora-review -b 1979793 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic Disabled plugins: Perl, Ocaml, fonts, SugarActivity, R, Java, PHP, Python, Haskell, C/C++ Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
Spec URL: https://dcavalca.fedorapeople.org/review/golang-github-schollz-peerdiscovery/golang-github-schollz-peerdiscovery.spec SRPM URL: https://dcavalca.fedorapeople.org/review/golang-github-schollz-peerdiscovery/golang-github-schollz-peerdiscovery-1.6.9-1.fc36.src.rpm Changelog: - Convert to rpmautospec - Update to 1.6.9
Hello Davide, Thank you for correcting the spec file! Package approved. Regards, Hirotaka Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. [x]: Package does not own files or directories owned by other packages. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 7 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [!]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- $ rpmlint golang-github-schollz-peerdiscovery-1.6.9-1.fc36.src.rpm =================================================== rpmlint session starts ================================================== rpmlint: 2.1.0 configuration: /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/licenses.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 1 golang-github-schollz-peerdiscovery.spec: W: no-%build-section golang-github-schollz-peerdiscovery.spec:54: W: macro-in-%changelog %autochangelog ==================== 1 packages and 0 specfiles checked; 0 errors, 2 warnings, 0 badness; has taken 0.2 s =================== $ rpmlint golang-github-schollz-peerdiscovery-devel-1.6.9-1.fc36.noarch.rpm =================================================== rpmlint session starts ================================================== rpmlint: 2.1.0 configuration: /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/licenses.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 1 golang-github-schollz-peerdiscovery-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/schollz/peerdiscovery/.goipath golang-github-schollz-peerdiscovery-devel.noarch: W: files-duplicate /usr/share/gocode/src/github.com/schollz/peerdiscovery/README.md /usr/share/doc/golang-github-schollz-peerdiscovery-devel/README.md ==================== 1 packages and 0 specfiles checked; 0 errors, 2 warnings, 0 badness; has taken 0.1 s =================== Source checksums ---------------- https://github.com/schollz/peerdiscovery/archive/v1.6.9/peerdiscovery-1.6.9.tar.gz : CHECKSUM(SHA256) this package : b393923c5ce61c02cb5a7d26c480bc0bd22d9578ba5e0ad402a29304a2cf3d6c CHECKSUM(SHA256) upstream package : b393923c5ce61c02cb5a7d26c480bc0bd22d9578ba5e0ad402a29304a2cf3d6c Requires -------- golang-github-schollz-peerdiscovery-devel (rpmlib, GLIBC filtered): go-filesystem golang(golang.org/x/net/ipv4) golang(golang.org/x/net/ipv6) Provides -------- golang-github-schollz-peerdiscovery-devel: golang(github.com/schollz/peerdiscovery) golang-github-schollz-peerdiscovery-devel golang-ipath(github.com/schollz/peerdiscovery) Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10 Command line :/usr/bin/fedora-review -b 1979793 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api Disabled plugins: fonts, C/C++, R, Python, SugarActivity, Ocaml, PHP, Haskell, Perl, Java Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
Thanks! $ fedpkg request-repo golang-github-schollz-peerdiscovery 1979793 https://pagure.io/releng/fedora-scm-requests/issue/37550
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-schollz-peerdiscovery
FEDORA-2021-17b810f76b has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2021-17b810f76b
FEDORA-2021-17b810f76b has been pushed to the Fedora 36 stable repository. If problem still persists, please make note of it in this bug report.