Bug 1980051 - ramdisk_kernel_arguments not adding argument to kernel command line
Summary: ramdisk_kernel_arguments not adding argument to kernel command line
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Red Hat OpenStack
Classification: Red Hat
Component: openstack-ironic
Version: 17.0 (Wallaby)
Hardware: Unspecified
OS: Unspecified
low
low
Target Milestone: ---
: ---
Assignee: Julia Kreger
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-07-07 16:53 UTC by Juan Pablo Lopez Guzman
Modified: 2022-02-08 15:27 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2022-02-08 15:27:55 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Issue Tracker OSP-6011 0 None None None 2022-01-26 15:17:37 UTC

Description Juan Pablo Lopez Guzman 2021-07-07 16:53:52 UTC
Description of problem:
"unattended" argument is not added to /var/lib/ironic/httpboot/00:ca:09:5b:43:66.conf
after set the ramdisk_kernel_arguments and rebuilding the node


Version-Release number of selected component (if applicable):
tripleo-quickstart + master
baremetal 4.6.1


How reproducible:
100%

Steps to Reproduce:
1. baremetal node power off control-1
2. baremetal node maintenance set control-1
3. baremetal node set \
    --instance-info kernel="file:///var/lib/ironic/tftpboot/overcloud-controller-1.kernel" \
    --instance-info ramdisk="file:///var/lib/ironic/tftpboot/overcloud-controller-1.initrd.cgz" \
    --instance-info ramdisk_kernel_arguments="unattended" \
    --deploy-interface ramdisk \
    control-1
4. baremetal node maintenance unset control-1
5- baremetal node rebuild control-1

Actual results:
"unattended" not included in the kernel command line

Expected results:
"unattended" should be included in the kernel command line

Additional info:

http://pastebin.test.redhat.com/977683 (node yaml)
http://pastebin.test.redhat.com/977683 (node /var/lib/ironic/httpboot/00:ca:09:5b:43:66.conf)

Comment 1 Julia Kreger 2021-07-13 18:49:48 UTC
So the proper parameter is in the instance_info field, a value assigned to "kernel_append_params". We've added  unit test upstream which works as expected if the information is present, so we believe that should work instead of the ramdisk_kernel_params value which appears to be a hold-over from initial redfish virtual media support. Please try "kernel_append_params" and let us know how that goes.

Comment 2 Julia Kreger 2021-07-20 21:37:31 UTC
Heard back from the requester. They used the kernel_append_params and the setting worked. I double checked the upstream documentation, and it also states as such. Given this, I'm going to close this item out.

Comment 3 Juan Badia Payno 2022-01-26 15:15:38 UTC
Reopening the BZ.
The instance_info argument doesn't work.

Comment 4 Julia Kreger 2022-01-26 20:25:01 UTC
So it seems the original requester was using the master branch and not wallaby. That being said, I noticed that the original ramdisk parameter passing functionality could have used better unit testing as there were some gaps where it was not really covered. The ramdisk_kernel_arguments parameter is supposed to work on stable/wallaby, and should even work on master. And according to all the unit testing I put in place, it does work. Rendered output is as expected when used. Which means there is a variable or something mechanics wise which is occurring here, that is not readily visible.

Comment 5 Julia Kreger 2022-02-08 15:27:55 UTC
Additional unit tests merged upstream. I'm considering this matter closed and that there is not a need to backport additional unit tests.


Note You need to log in before you can comment on or make changes to this bug.