Spec URL: http://home.comcast.net/~ckweyl/perl-POE-Component-Child.spec SRPM URL: http://home.comcast.net/~ckweyl/perl-POE-Component-Child-1.39-0.fc5.src.rpm Description: This POE component serves as a wrapper for POE::Wheel::Run, obviating the need to create a session to receive the events it dishes out.
Trying to access the URL above gives: Page URL Not Found!! The requested page does not exist on this server. The URL you typed or followed is either outdated or inaccurate.
My bad; fixed.
This package seems to be under the GPL only. The version in your changelog entry is a bit odd ("-0"), causing rpmlint indigestion: W: perl-POE-Component-Child incoherent-version-in-changelog -0 1.39-0.fc6 Review: * source files match upstream: 35827260ad62e9d1bcbf74ada943deb9 POE-Component-Child-1.39.tar.gz * package meets naming and packaging guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * dist tag is present. * build root is correct. X license field matches the actual license. * license is open source-compatible. License text included in package. * latest version is being packaged. O BuildRequires are proper (BR: perl is not required) * %clean is present. * package builds in mock (development, x86_64). X rpmlint is silent. * noarch package, so no debuginfo. * final provides and requires are sane: perl(POE::Component::Child) = 1.39 perl-POE-Component-Child = 1.39-0.fc6 = perl(:MODULE_COMPAT_5.8.8) perl(Carp) perl(Cwd) perl(POE) >= 0.29 perl(strict) perl(vars) perl(warnings) * %check is present and all tests pass: ok 19 - all tests successful * no shared libraries are present. * package is not relocatable. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no scriptlets present. * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * no headers. * no pkgconfig files. * no libtool .la droppings. * not a GUI app.
package is noarch => OPTIMIZE="%{optflags}" is unused/superfluous. => This find also is very likely unnecessary: find %{buildroot} -type f -name '*.bs' -a -size 0 -exec rm -f {} ';'
Updated to deal with licensing and version issues. Spec URL: http://home.comcast.net/~ckweyl/perl-POE-Component-Child.spec SRPM URL: http://home.comcast.net/~ckweyl/perl-POE-Component-Child-1.39-0.fc5.src.rpm
Updated to deal with licensing and version issues. Spec URL: http://home.comcast.net/~ckweyl/perl-POE-Component-Child.spec SRPM URL: http://home.comcast.net/~ckweyl/perl-POE-Component-Child-1.39-0.1.fc5.src.rpm
The license is now correct. The version in the changelog entry is now sensible. The two issues I had are fixed. The issues Ralf pointed out are not. I don't see them as blockers, but I do recommend that you address them as needless cruft in specfiles should always be cleaned up.
I neglected to add: APPROVED
+Import to CVS +Add to owners.list +Bump release, build for devel +devel build succeeds +Request branching (FC-4, FC-5) +Close bug Thanks for the review! :)