Spec URL: https://ankursinha.fedorapeople.org/python-pox/python-pox.spec SRPM URL: https://ankursinha.fedorapeople.org/python-pox/python-pox-0.3.0-1.fc34.src.rpm Description: pox provides a collection of utilities for navigating and manipulating filesystems. This module is designed to facilitate some of the low level operating system interactions that are useful when exploring a filesystem on a remote host, where queries such as "what is the root of the filesystem?", "what is the user's name?", and "what login shell is preferred?" become essential in allowing a remote user to function as if they were logged in locally. While pox is in the same vein of both the os and shutil builtin modules, the majority of its functionality is unique and compliments these two modules. pox provides python equivalents of several unix shell commands such as which and find. These commands allow automated discovery of what has been installed on an operating system, and where the essential tools are located. This capability is useful not only for exploring remote hosts, but also locally as a helper utility for automated build and installation. Several high-level operations on files and filesystems are also provided. Examples of which are: finding the location of an installed python package, determining if and where the source code resides on the filesystem, and determining what version the installed package is. pox also provides utilities to enable the abstraction of commands sent to a remote filesystem. In conjunction with a registry of environment variables and installed utilites, pox enables the user to interact with a remote filesystem as if they were logged in locally. pox is part of pathos, a python framework for heterogeneous computing. pox is in active development, so any user feedback, bug reports, comments, or suggestions are highly appreciated. A list of issues is located at https://github.com/uqfoundation/pox/issues, with a legacy list maintained at https://uqfoundation.github.io/project/pathos/query. Major Features pox provides utilities for discovering the user's environment: - return the user's name, current shell, and path to user's home directory - strip duplicate entries from the user's $PATH - lookup and expand environment variables from ${VAR} to value pox also provides utilities for filesystem exploration and manipulation: - discover the path to a file, exectuable, directory, or symbolic link - discover the path to an installed package - parse operating system commands for remote shell invocation - convert text files to platform-specific formatting Fedora Account System Username: ankursinha
I'm new contributor, and your package seems okay to me. I've checked the both License and fedora-review.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 34 files have unknown license. Detailed output of licensecheck in /home/chronoelves/rpmbuild/SRPMS/1980142-python-pox/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [?]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [?]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [?]: Python eggs must not download any dependencies during the build process. [?]: A package which is used by another package via an egg interface should provide egg info. [?]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python3-pox [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [?]: %check is present and all tests pass. [?]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python3-pox-0.3.0-1.fc35.noarch.rpm python-pox-doc-0.3.0-1.fc35.noarch.rpm python-pox-0.3.0-1.fc35.src.rpm python3-pox.noarch: W: spelling-error %description -l en_US os -> OS, och, so python3-pox.noarch: W: spelling-error %description -l en_US shutil -> shutting python3-pox.noarch: W: spelling-error %description -l en_US unix -> UNIX, Unix, uni python3-pox.noarch: W: spelling-error %description -l en_US utilites -> utilities, utilizes, titillates python3-pox.noarch: W: spelling-error %description -l en_US exectuable -> executable, execrable python3-pox.noarch: W: no-manual-page-for-binary pox python-pox.src: W: spelling-error %description -l en_US os -> OS, och, so python-pox.src: W: spelling-error %description -l en_US shutil -> shutting python-pox.src: W: spelling-error %description -l en_US unix -> UNIX, Unix, uni python-pox.src: W: spelling-error %description -l en_US utilites -> utilities, utilizes, titillates python-pox.src: W: spelling-error %description -l en_US exectuable -> executable, execrable 3 packages and 0 specfiles checked; 0 errors, 11 warnings. Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output: Source checksums ---------------- https://files.pythonhosted.org/packages/source/p/pox/pox-0.3.0.zip : CHECKSUM(SHA256) this package : cb968350b186466bb4905a21084587ec3aa6fd7aa0ef55d416ee0d523e2abe31 CHECKSUM(SHA256) upstream package : cb968350b186466bb4905a21084587ec3aa6fd7aa0ef55d416ee0d523e2abe31 Requires -------- python3-pox (rpmlib, GLIBC filtered): /usr/bin/python3 python(abi) python-pox-doc (rpmlib, GLIBC filtered): Provides -------- python3-pox: python-pox python3-pox python3.10-pox python3.10dist(pox) python3dist(pox) python-pox-doc: python-pox-doc Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10 Command line :/usr/bin/fedora-review -b 1980142 Buildroot used: fedora-rawhide-x86_64 Active plugins: Python, Generic, Shell-api Disabled plugins: R, SugarActivity, PHP, Perl, fonts, C/C++, Haskell, Ocaml, Java Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
- [?]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 2 files. True because there is a doc package - [?]: %check is present and all tests pass. Check are successful, you can see this in the build.log file in results/ : + /usr/bin/pytest -k 'not test_shutils' ============================= test session starts ============================== platform linux -- Python 3.10.0b3, pytest-6.2.4, py-1.10.0, pluggy-0.13.1 rootdir: /builddir/build/BUILD/pox-0.3.0 collected 2 items / 1 deselected / 1 selected tests/test_utils.py . [100%] ======================= 1 passed, 1 deselected in 0.07s ======================== Package is approved following Didik Supriadi's review.
Thanks very much Dridi and Robert-Andre! Requesting SCM now. Cheers, Ankur
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-pox
Built now. Didik, I'm very sorry I got your name wrong. Apologies :/
FEDORA-2021-9ce57bfbe7 has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-9ce57bfbe7
FEDORA-2021-9ce57bfbe7 has been pushed to the Fedora 34 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-9ce57bfbe7 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-9ce57bfbe7 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2021-9ce57bfbe7 has been pushed to the Fedora 34 stable repository. If problem still persists, please make note of it in this bug report.