Red Hat Bugzilla – Bug 198021
Review Request: perl-Log-Dispatch-Config
Last modified: 2012-09-03 13:21:47 EDT
Spec URL: http://home.comcast.net/~ckweyl/perl-Log-Dispatch-Config.spec
Log::Dispatch::Config is a subclass of Log::Dispatch and provides a way to
configure Log::Dispatch object with configulation file (default, in AppConfig
Just a note that there's an empty line at the top of your .spec.
* source files match upstream:
* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is correct.
* license field matches the actual license.
* license is open source-compatible. License text not included upstream.
* latest version is being packaged.
O BuildRequires are proper (BR: perl is not required).
* %clean is present.
* package builds in mock (development, x86_64).
* rpmlint is silent.
* noarch package, so no debuginfo.
* final provides and requires are sane:
perl(Log::Dispatch::Config) = 1.01
perl(Log::Dispatch::Configurator) = 1.00
perl(Log::Dispatch::Configurator::AppConfig) = 1.00
perl-Log-Dispatch-Config = 1.01-0.fc6
perl(Log::Dispatch) >= 2.00
* %check is present and all tests pass:
All tests successful.
Files=15, Tests=48, 4 wallclock secs ( 0.68 cusr + 0.27 csys = 0.95 CPU)
* no shared libraries are present.
* package is not relocatable.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no libtool .la droppings.
* not a GUI app.
* "...object with configulation file..."
The upstream developer's summary used the word configulation, which is copied
into the spec file. I don't think it's a real word. If it was changed to
configuration, then package searches are more likely to be successful.
Oops, my brain simply read over the typo. Time for a script to spellcheck
Symmary: and %description, I suppose.
Hm, I wonder if we can get rpmlint to do that. I glossed right over it, too...
rpmlint does check for some common misspellings. It should be pretty easy to
have it call aspell instead if it's installed.
+Import to CVS
+Add to owners.list
+Bump release, build for devel
+devel build succeeds
+Request branching (FC-4, FC-5)
Thanks for the review! :)
Package Change Request
Package Name: perl-Log-Dispatch-Config
New Branches: el6
Git done (by process-git-requests).