Bug 1980342 - Review Request: libxcvt - VESA CVT standard timing modelines generator
Summary: Review Request: libxcvt - VESA CVT standard timing modelines generator
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Yanko Kaneti
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-07-08 12:28 UTC by Olivier Fourdan
Modified: 2021-07-28 13:28 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2021-07-28 13:28:46 UTC
Type: ---
Embargoed:
yaneti: fedora-review+


Attachments (Terms of Use)

Description Olivier Fourdan 2021-07-08 12:28:36 UTC
Spec URL: https://ofourdan.fedorapeople.org/libxcvt/libxcvt.spec
SRPM URL: https://ofourdan.fedorapeople.org/libxcvt/libxcvt-0.1.0-1.fc34.src.rpm
Description: libxcvt is a library providing a standalone version of the X server implementation of the VESA CVT standard timing modelines generator. libxcvt also provides a standalone version of the command line tool cvt copied from the Xorg implementation and is meant to be a direct replacement to the version provided by the Xorg server.
Fedora Account System Username: ofourdan

Comment 1 Yanko Kaneti 2021-07-08 13:02:22 UTC
alternatives is for where there is a legitimate use case for using one or the other
Would there be a legitimate case for using the old cvt code from the X server ?

I am assuming X upstream would be made a user of the lib.

Comment 2 Olivier Fourdan 2021-07-08 13:22:48 UTC
(In reply to Yanko Kaneti from comment #1)
> Would there be a legitimate case for using the old cvt code from the X
> server ?

Not really - It's actually the same code.
 
> I am assuming X upstream would be made a user of the lib.

Yep, that's the plan. And even without using the lib, we could just drop cvt from the xorg-x11-server-package and make packages which need cvt (e.g. mutter has a buildReq on cvt) use the one from the lib (typically installing all of xorg-x11-server-Xorg to get only cvt to generate modelines at build time in mutter seems overkill).

Comment 3 Olivier Fourdan 2021-07-09 07:55:31 UTC
So I was trying to avoid adding an explicit conflict, but considering that the use of libxcvt will not be backported to the stable branch of the xserver (1.20.xx) we could just make libxcvt-cvt conflicts with xorg-x11-server-Xorg <= 1.20.

Would that be acceptable in ths context?

Comment 4 Olivier Fourdan 2021-07-09 08:09:57 UTC
spec/srpm updated to add a "Conflicts: xorg-x11-server-Xorg < 1.21" for the package libxcvt-cvt

Comment 5 Yanko Kaneti 2021-07-09 11:26:50 UTC
Name matches and doesn't conflict
License matches.
Builds in mock. Seems to work.

APPROVED

Instead of "libxcvt-cvt"  I would name the subpackage with the binary just "cvt"

Comment 6 Yanko Kaneti 2021-07-09 11:29:15 UTC
Oh and own 
%dir %{_includedir}/libxcvt

Comment 7 Olivier Fourdan 2021-07-09 13:00:53 UTC
Thanks!

(In reply to Yanko Kaneti from comment #5)
> Instead of "libxcvt-cvt"  I would name the subpackage with the binary just
> "cvt"

Done.

(In reply to Yanko Kaneti from comment #6)
> Oh and own 
> %dir %{_includedir}/libxcvt

Done.

spec and srpm updated.

Comment 8 Olivier Fourdan 2021-07-22 14:44:30 UTC
repo request https://pagure.io/releng/fedora-scm-requests/issue/35846

Comment 9 Gwyn Ciesla 2021-07-22 14:45:48 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/libxcvt

Comment 10 Olivier Fourdan 2021-07-28 13:28:46 UTC
Build complete https://bodhi.fedoraproject.org/updates/FEDORA-2021-45d36e4bd5


Note You need to log in before you can comment on or make changes to this bug.