Fedora Account System
Red Hat Associate
Red Hat Customer
Spec URL: http://oturpe.kapsi.fi/fedora/rpms/mt32emu/mt32emu.spec SRPM URL: http://oturpe.kapsi.fi/fedora/rpms/mt32emu/mt32emu-2.5.1-1.fc34.src.rpm Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=71537281 Description: mt32emu is a part of the Munt project. It represents a C/C++ library named libmt32emu which allows to emulate (approximately) the Roland MT-32, CM-32L and LAPC-I synthesizer modules. Currently, dosbox-staging bundles mt32emu, even though it could also use a system library. Adding mt32emu as a system library here so that dosbox-staging can shed the bundling. Fedora Account System Username: oturpe
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated Issues: ======= - (MUST) The GPL license in COPYING doesn't actually apply to any code included in this package, so I don't think it should be included in %license - (SHOULD) Upstream appears to have just released version 2.5.2 https://github.com/munt/munt/releases/tag/libmt32emu_2_5_2 - (COMMENT) Disttag & changelog will be autogenerated in the final package via rpmautospec. The required macros are present & correctly applied. I have disregarded issues & rpmlint messages related to this. - (COMMENT) Further non-issue comments below, enclosed in **** ===== MUST items ===== C/C++: [X]: Package does not contain kernel modules. [X]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [X]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [X]: License field in the package spec file matches the actual license. **** Parts of the upstream project are licenses under GPL rather than LGPL, however, none of those files are present in this package. [X]: License file installed when any subpackage combination is installed. [X]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [X]: %build honors applicable compiler flags or justifies otherwise. [X]: Package contains no bundled libraries without FPC exception. [X]: Changelog in prescribed format. [X]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [X]: Development files must be in a -devel package [X]: Package uses nothing in %doc for runtime. [X]: Package consistently uses macros (instead of hard-coded directory names). [X]: Package is named according to the Package Naming Guidelines. [X]: Package does not generate any conflict. [X]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [X]: Requires correct, justified where necessary. [X]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [X]: Useful -debuginfo package or justification otherwise. [X]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. [X]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [X]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [X]: Final provides and requires are sane (see attachments). [?]: Package functions as described. **** package installes without issues, but I have no easy way of evaluating its functionality **** [!]: Latest version is packaged. **** 2.5.2 is available upstream **** [!]: Package does not include license text files separate from upstream. **** MIT License text is added via patch, with bug filed upstream. This is OK **** [X]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. [X]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [X]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. **** no tests available **** [-]: Packages should try to preserve timestamps of original installed files. **** all files are installed via cmake/%doc/%license macros **** [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: The placement of pkgconfig(.pc) files are correct. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: mt32emu-2.5.1-1.fc35.x86_64.rpm mt32emu-devel-2.5.1-1.fc35.x86_64.rpm mt32emu-debuginfo-2.5.1-1.fc35.x86_64.rpm mt32emu-debugsource-2.5.1-1.fc35.x86_64.rpm mt32emu-2.5.1-1.fc35.src.rpm mt32emu.src:75: W: macro-in-%changelog %autochangelog 5 packages and 0 specfiles checked; 0 errors, 1 warnings. **** An expected warning when using rpmautospec macros. This is OK. **** Rpmlint (debuginfo) ------------------- Checking: mt32emu-debuginfo-2.5.1-1.fc35.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings.
Thank you for the review. I have fixed the issues. New specfile: http://oturpe.kapsi.fi/fedora/rpms/mt32emu/2/mt32emu.spec New srpm: http://oturpe.kapsi.fi/fedora/rpms/mt32emu/2/mt32emu-2.5.2-1.fc34.src.rpm (In reply to Christopher Engelhard from comment #1) > Issues: > ======= > - (MUST) The GPL license in COPYING doesn't actually apply to any code > included in this package, so I don't think it should be included in > %license Makes sense, removing during %install. I also contacted upstream about removing the file from there also. There is a different but also sensible argument for keeping it, thus the file stays upstream. Refer to: https://github.com/munt/munt/issues/68#issuecomment-882524417 > - (SHOULD) Upstream appears to have just released version 2.5.2 > https://github.com/munt/munt/releases/tag/libmt32emu_2_5_2 Nice, updated to latest version. > [!]: Package does not include license text files separate from upstream. > **** MIT License text is added via patch, with bug filed upstream. This > is OK **** Version 2.5.2 has the MIT license text, so I was able to remove the patch.
Looks good to me now, thanks for packaging this.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/mt32emu
Everything done here. Thank you for reviewing.