RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1981393 - kselftests/tc-testing: police.json failed to match
Summary: kselftests/tc-testing: police.json failed to match
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 8
Classification: Red Hat
Component: iproute
Version: 8.5
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: beta
: ---
Assignee: Andrea Claudi
QA Contact: Mingyu Shi
URL:
Whiteboard:
Depends On:
Blocks: 1704655
TreeView+ depends on / blocked
 
Reported: 2021-07-12 13:16 UTC by Hangbin Liu
Modified: 2021-11-10 07:48 UTC (History)
4 users (show)

Fixed In Version: iproute-5.12.0-3.el8
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-11-09 19:37:07 UTC
Type: Bug
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2021:4389 0 None None None 2021-11-09 19:37:23 UTC

Description Hangbin Liu 2021-07-12 13:16:34 UTC 
Description of problem:
kselftests/tc-testing: police.json test cdd7 failed to match

Version-Release number of selected component (if applicable):
iproute-5.9.0-4.el8

How reproducible:
every time

Steps to Reproduce:
1. install related kselftest rpm
2. ./tdc.py -f tc-tests/actions/police.json
3.

Actual results:
not ok 32 cdd7 - Add valid police action with packets per second rate limit
	Command exited with 255, expected 0

Expected results:


Additional info:
Fixed by https://lore.kernel.org/netdev/20210712122653.100652-1-roid@nvidia.com/
Comment 1 Andrea Claudi 2021-08-09 10:04:44 UTC 
We need to backport:
- commit a5b355c08c62 ("Update kernel headers")
- commit cf9ae1bd3118 ("police: add support for packet-per-second rate limiting")
- commit 0d5cf51e0d6c ("police: Add support for json output")
- commit 71d36000dc9c ("police: Fix normal output back to what it was")

Hangbin, is there a reason to use iproute-5.9.0-4.el8 from rhel-8.4 to test rhel-8.5? I'm going to fix this on iproute-5.12.0-*, but if you really need this on rhel-8.4 I can open a z-stream issue for that. Let me know.
Comment 2 Hangbin Liu 2021-08-11 09:50:19 UTC 
(In reply to Andrea Claudi from comment #1)
> We need to backport:
> - commit a5b355c08c62 ("Update kernel headers")
> - commit cf9ae1bd3118 ("police: add support for packet-per-second rate
> limiting")
> - commit 0d5cf51e0d6c ("police: Add support for json output")
> - commit 71d36000dc9c ("police: Fix normal output back to what it was")
> 
> Hangbin, is there a reason to use iproute-5.9.0-4.el8 from rhel-8.4 to test
> rhel-8.5? I'm going to fix this on iproute-5.12.0-*, but if you really need
> this on rhel-8.4 I can open a z-stream issue for that. Let me know.

No need to fix it on 8.4. I run the test on an old distro, so the iproute was not up to date.
Comment 3 Andrea Claudi 2021-08-11 10:14:45 UTC 
Hi Mingyu, can you please consider to set itm and grant this qa_ack+?
The fix is contained on the tc police code, and it's easy to verify it following the step detailed in the first comment.
Comment 8 Mingyu Shi 2021-08-19 02:27:35 UTC 
iproute-5.12.0-3.el8.x86_64

[10:24:26@dell-per730-20 /usr/libexec/kselftests/tc-testing]0# ./tdc.py -f tc-tests/actions/police.json
Test 49aa: Add valid basic police action
Test 3abe: Add police action with duplicate index
Test 49fa: Add valid police action with mtu
Test 7943: Add valid police action with peakrate
Test 055e: Add police action with peakrate and no mtu
Test f057: Add police action with valid overhead
Test 7ffb: Add police action with ethernet linklayer type
Test 3dda: Add police action with atm linklayer type
Test 551b: Add police actions with conform-exceed control continue/drop
Test 0c70: Add police actions with conform-exceed control pass/reclassify
Test d946: Add police actions with conform-exceed control pass/pipe
Test ddd6: Add police action with invalid rate value
Test f61c: Add police action with invalid burst value
Test 6aaf: Add police actions with conform-exceed control pass/pipe [with numeric values]
Test 29b1: Add police actions with conform-exceed control <invalid>/drop
Test c26f: Add police action with invalid peakrate value
Test db04: Add police action with invalid mtu value
Test f3c9: Add police action with cookie
Test d190: Add police action with maximum index
Test 336e: Delete police action
Test 77fa: Get single police action from many actions
Test aa43: Get single police action without specifying index
Test 858b: List police actions
Test 1c3a: Flush police actions
Test 7326: Add police action with control continue
Test 34fa: Add police action with control drop
Test 8dd5: Add police action with control ok
Test b9d1: Add police action with control reclassify
Test c534: Add police action with control pipe
Test b48b: Add police action with exceed goto chain control action
Test 689e: Replace police action with invalid goto chain control
Test cdd7: Add valid police action with packets per second rate limit
Test f5bc: Add invalid police action with both bps and pps

All test results: 

1..33
ok 1 49aa - Add valid basic police action
ok 2 3abe - Add police action with duplicate index
ok 3 49fa - Add valid police action with mtu
ok 4 7943 - Add valid police action with peakrate
ok 5 055e - Add police action with peakrate and no mtu
ok 6 f057 - Add police action with valid overhead
ok 7 7ffb - Add police action with ethernet linklayer type
ok 8 3dda - Add police action with atm linklayer type
ok 9 551b - Add police actions with conform-exceed control continue/drop
ok 10 0c70 - Add police actions with conform-exceed control pass/reclassify
ok 11 d946 - Add police actions with conform-exceed control pass/pipe
ok 12 ddd6 - Add police action with invalid rate value
ok 13 f61c - Add police action with invalid burst value
ok 14 6aaf - Add police actions with conform-exceed control pass/pipe [with numeric values]
ok 15 29b1 - Add police actions with conform-exceed control <invalid>/drop
ok 16 c26f - Add police action with invalid peakrate value
ok 17 db04 - Add police action with invalid mtu value
ok 18 f3c9 - Add police action with cookie
ok 19 d190 - Add police action with maximum index
ok 20 336e - Delete police action
ok 21 77fa - Get single police action from many actions
ok 22 aa43 - Get single police action without specifying index
ok 23 858b - List police actions
ok 24 1c3a - Flush police actions
ok 25 7326 - Add police action with control continue
ok 26 34fa - Add police action with control drop
ok 27 8dd5 - Add police action with control ok
ok 28 b9d1 - Add police action with control reclassify
ok 29 c534 - Add police action with control pipe
ok 30 b48b - Add police action with exceed goto chain control action
ok 31 689e - Replace police action with invalid goto chain control
ok 32 cdd7 - Add valid police action with packets per second rate limit
ok 33 f5bc - Add invalid police action with both bps and pps
Comment 10 errata-xmlrpc 2021-11-09 19:37:07 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (iproute bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2021:4389
Note You need to log in before you can comment on or make changes to this bug.