Spec URL: https://www.techie.net/~talbert/sip6.spec SRPM URL: https://www.techie.net/~talbert/sip6-6.1.1-1.fc35.src.rpm Description: SIP is a collection of tools that makes it very easy to create Python bindings for C and C++ libraries. It was originally developed in 1998 to create PyQt, the Python bindings for the Qt toolkit, but can be used to create bindings for any C or C++ library. For example it is also used to generate wxPython, the Python bindings for wxWidgets. Fedora Account System Username: swt2c The intention is for this to replace the 'sip5' package which would be retired when all current sip5 users can use sip6. Some packages will stick with sip 4 (sip package) if they cannot move to sip6.
I will take this review.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated Issues: ======= - Since this package is intended to replace the sip5 package, shouldn't it have Obsoletes and Provides for sip5? - Please add a comment explaining the patch (a SHOULD item) - If no other form of testing makes sense (such as building the examples), then this is now possible in Rawhide: %check %py3_check_import sipbuild sipbuild.distinfo sipbuild.module sipbuild.tools ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Development (unversioned) .so files in -devel subpackage, if present. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. [x]: License file installed when any subpackage combination is installed. [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/lib64/python3.10/site- packages/sipbuild(sip5), /usr/lib64/python3.10/site- packages/sipbuild/__pycache__(sip5), /usr/lib64/python3.10/site- packages/sipbuild/distinfo(sip5), /usr/lib64/python3.10/site- packages/sipbuild/distinfo/__pycache__(sip5), /usr/lib64/python3.10/site-packages/sipbuild/module(sip5), /usr/lib64/python3.10/site-packages/sipbuild/module/__pycache__(sip5), /usr/lib64/python3.10/site-packages/sipbuild/module/source(sip5), /usr/lib64/python3.10/site-packages/sipbuild/module/source/12.7(sip5), /usr/lib64/python3.10/site-packages/sipbuild/module/source/12.8(sip5), /usr/lib64/python3.10/site-packages/sipbuild/tools(sip5), /usr/lib64/python3.10/site-packages/sipbuild/tools/__pycache__(sip5) This is okay since the intention is to retire the sip5 package. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package There are development files in a non-devel package, but that's because sip6 is inherently a development package. [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [!]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [!]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: sip6-6.1.1-1.fc35.x86_64.rpm sip6-debuginfo-6.1.1-1.fc35.x86_64.rpm sip6-debugsource-6.1.1-1.fc35.x86_64.rpm sip6-6.1.1-1.fc35.src.rpm sip6.x86_64: W: spelling-error %description -l en_US wxPython -> python, Python sip6.x86_64: W: spelling-error %description -l en_US wxWidgets -> widgets sip6.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.10/site-packages/sipbuild/module/source/12.7/apiversions.c sip6.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.10/site-packages/sipbuild/module/source/12.7/array.c sip6.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.10/site-packages/sipbuild/module/source/12.7/array.h sip6.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.10/site-packages/sipbuild/module/source/12.7/bool.cpp sip6.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.10/site-packages/sipbuild/module/source/12.7/descriptors.c sip6.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.10/site-packages/sipbuild/module/source/12.7/int_convertors.c sip6.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.10/site-packages/sipbuild/module/source/12.7/objmap.c sip6.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.10/site-packages/sipbuild/module/source/12.7/qtlib.c sip6.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.10/site-packages/sipbuild/module/source/12.7/sipint.h sip6.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.10/site-packages/sipbuild/module/source/12.7/siplib.c sip6.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.10/site-packages/sipbuild/module/source/12.7/threads.c sip6.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.10/site-packages/sipbuild/module/source/12.7/voidptr.c sip6.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.10/site-packages/sipbuild/module/source/12.8/apiversions.c sip6.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.10/site-packages/sipbuild/module/source/12.8/array.c sip6.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.10/site-packages/sipbuild/module/source/12.8/array.h sip6.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.10/site-packages/sipbuild/module/source/12.8/bool.cpp sip6.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.10/site-packages/sipbuild/module/source/12.8/descriptors.c sip6.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.10/site-packages/sipbuild/module/source/12.8/int_convertors.c sip6.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.10/site-packages/sipbuild/module/source/12.8/objmap.c sip6.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.10/site-packages/sipbuild/module/source/12.8/qtlib.c sip6.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.10/site-packages/sipbuild/module/source/12.8/sipint.h sip6.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.10/site-packages/sipbuild/module/source/12.8/siplib.c sip6.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.10/site-packages/sipbuild/module/source/12.8/threads.c sip6.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.10/site-packages/sipbuild/module/source/12.8/voidptr.c sip6.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.10/site-packages/sipbuild/module/source/12.9/apiversions.c sip6.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.10/site-packages/sipbuild/module/source/12.9/array.c sip6.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.10/site-packages/sipbuild/module/source/12.9/array.h sip6.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.10/site-packages/sipbuild/module/source/12.9/bool.cpp sip6.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.10/site-packages/sipbuild/module/source/12.9/descriptors.c sip6.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.10/site-packages/sipbuild/module/source/12.9/int_convertors.c sip6.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.10/site-packages/sipbuild/module/source/12.9/objmap.c sip6.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.10/site-packages/sipbuild/module/source/12.9/qtlib.c sip6.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.10/site-packages/sipbuild/module/source/12.9/sipint.h sip6.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.10/site-packages/sipbuild/module/source/12.9/siplib.c sip6.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.10/site-packages/sipbuild/module/source/12.9/threads.c sip6.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.10/site-packages/sipbuild/module/source/12.9/voidptr.c sip6.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.10/site-packages/sipbuild/module/source/13.0/array.c sip6.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.10/site-packages/sipbuild/module/source/13.0/array.h sip6.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.10/site-packages/sipbuild/module/source/13.0/bool.cpp sip6.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.10/site-packages/sipbuild/module/source/13.0/descriptors.c sip6.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.10/site-packages/sipbuild/module/source/13.0/int_convertors.c sip6.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.10/site-packages/sipbuild/module/source/13.0/objmap.c sip6.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.10/site-packages/sipbuild/module/source/13.0/sipint.h sip6.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.10/site-packages/sipbuild/module/source/13.0/siplib.c sip6.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.10/site-packages/sipbuild/module/source/13.0/threads.c sip6.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.10/site-packages/sipbuild/module/source/13.0/voidptr.c sip6.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.10/site-packages/sipbuild/module/source/13.1/array.c sip6.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.10/site-packages/sipbuild/module/source/13.1/array.h sip6.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.10/site-packages/sipbuild/module/source/13.1/bool.cpp sip6.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.10/site-packages/sipbuild/module/source/13.1/descriptors.c sip6.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.10/site-packages/sipbuild/module/source/13.1/int_convertors.c sip6.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.10/site-packages/sipbuild/module/source/13.1/objmap.c sip6.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.10/site-packages/sipbuild/module/source/13.1/sipint.h sip6.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.10/site-packages/sipbuild/module/source/13.1/siplib.c sip6.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.10/site-packages/sipbuild/module/source/13.1/threads.c sip6.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.10/site-packages/sipbuild/module/source/13.1/voidptr.c sip6.x86_64: W: no-manual-page-for-binary sip-build sip6.x86_64: W: no-manual-page-for-binary sip-distinfo sip6.x86_64: W: no-manual-page-for-binary sip-install sip6.x86_64: W: no-manual-page-for-binary sip-module sip6.x86_64: W: no-manual-page-for-binary sip-sdist sip6.x86_64: W: no-manual-page-for-binary sip-wheel sip6.src: W: spelling-error %description -l en_US wxPython -> python, Python sip6.src: W: spelling-error %description -l en_US wxWidgets -> widgets 4 packages and 0 specfiles checked; 0 errors, 66 warnings. Rpmlint (debuginfo) ------------------- Checking: sip6-debuginfo-6.1.1-1.fc35.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- Checking: sip6-6.1.1-1.fc35.x86_64.rpm sip6.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.10/site-packages/sipbuild/code_generator.cpython-310-x86_64-linux-gnu.so PyExc_UserWarning (/usr/lib64/python3.10/site-packages/sipbuild/code_generator.cpython-310-x86_64-linux-gnu.so) sip6.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.10/site-packages/sipbuild/code_generator.cpython-310-x86_64-linux-gnu.so PyExc_FutureWarning (/usr/lib64/python3.10/site-packages/sipbuild/code_generator.cpython-310-x86_64-linux-gnu.so) sip6.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.10/site-packages/sipbuild/code_generator.cpython-310-x86_64-linux-gnu.so PyExc_TypeError (/usr/lib64/python3.10/site-packages/sipbuild/code_generator.cpython-310-x86_64-linux-gnu.so) sip6.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.10/site-packages/sipbuild/code_generator.cpython-310-x86_64-linux-gnu.so _Py_NoneStruct (/usr/lib64/python3.10/site-packages/sipbuild/code_generator.cpython-310-x86_64-linux-gnu.so) sip6.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.10/site-packages/sipbuild/code_generator.cpython-310-x86_64-linux-gnu.so PyCapsule_Type (/usr/lib64/python3.10/site-packages/sipbuild/code_generator.cpython-310-x86_64-linux-gnu.so) sip6.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.10/site-packages/sipbuild/code_generator.cpython-310-x86_64-linux-gnu.so PyList_New (/usr/lib64/python3.10/site-packages/sipbuild/code_generator.cpython-310-x86_64-linux-gnu.so) sip6.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.10/site-packages/sipbuild/code_generator.cpython-310-x86_64-linux-gnu.so PyObject_GetAttrString (/usr/lib64/python3.10/site-packages/sipbuild/code_generator.cpython-310-x86_64-linux-gnu.so) sip6.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.10/site-packages/sipbuild/code_generator.cpython-310-x86_64-linux-gnu.so PyErr_WarnEx (/usr/lib64/python3.10/site-packages/sipbuild/code_generator.cpython-310-x86_64-linux-gnu.so) sip6.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.10/site-packages/sipbuild/code_generator.cpython-310-x86_64-linux-gnu.so _Py_Dealloc (/usr/lib64/python3.10/site-packages/sipbuild/code_generator.cpython-310-x86_64-linux-gnu.so) sip6.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.10/site-packages/sipbuild/code_generator.cpython-310-x86_64-linux-gnu.so PyUnicode_EncodeLocale (/usr/lib64/python3.10/site-packages/sipbuild/code_generator.cpython-310-x86_64-linux-gnu.so) sip6.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.10/site-packages/sipbuild/code_generator.cpython-310-x86_64-linux-gnu.so PyErr_SetString (/usr/lib64/python3.10/site-packages/sipbuild/code_generator.cpython-310-x86_64-linux-gnu.so) sip6.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.10/site-packages/sipbuild/code_generator.cpython-310-x86_64-linux-gnu.so PyUnicode_EncodeFSDefault (/usr/lib64/python3.10/site-packages/sipbuild/code_generator.cpython-310-x86_64-linux-gnu.so) sip6.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.10/site-packages/sipbuild/code_generator.cpython-310-x86_64-linux-gnu.so PyList_Append (/usr/lib64/python3.10/site-packages/sipbuild/code_generator.cpython-310-x86_64-linux-gnu.so) sip6.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.10/site-packages/sipbuild/code_generator.cpython-310-x86_64-linux-gnu.so PyUnicode_DecodeLocale (/usr/lib64/python3.10/site-packages/sipbuild/code_generator.cpython-310-x86_64-linux-gnu.so) sip6.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.10/site-packages/sipbuild/code_generator.cpython-310-x86_64-linux-gnu.so PyObject_CallFunction (/usr/lib64/python3.10/site-packages/sipbuild/code_generator.cpython-310-x86_64-linux-gnu.so) sip6.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.10/site-packages/sipbuild/code_generator.cpython-310-x86_64-linux-gnu.so Py_BuildValue (/usr/lib64/python3.10/site-packages/sipbuild/code_generator.cpython-310-x86_64-linux-gnu.so) sip6.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.10/site-packages/sipbuild/code_generator.cpython-310-x86_64-linux-gnu.so PyModule_Create2 (/usr/lib64/python3.10/site-packages/sipbuild/code_generator.cpython-310-x86_64-linux-gnu.so) sip6.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.10/site-packages/sipbuild/code_generator.cpython-310-x86_64-linux-gnu.so PyImport_ImportModule (/usr/lib64/python3.10/site-packages/sipbuild/code_generator.cpython-310-x86_64-linux-gnu.so) sip6.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.10/site-packages/sipbuild/code_generator.cpython-310-x86_64-linux-gnu.so PyArg_ParseTuple (/usr/lib64/python3.10/site-packages/sipbuild/code_generator.cpython-310-x86_64-linux-gnu.so) sip6.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.10/site-packages/sipbuild/code_generator.cpython-310-x86_64-linux-gnu.so PyCapsule_New (/usr/lib64/python3.10/site-packages/sipbuild/code_generator.cpython-310-x86_64-linux-gnu.so) sip6.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.10/site-packages/sipbuild/code_generator.cpython-310-x86_64-linux-gnu.so PyCapsule_GetPointer (/usr/lib64/python3.10/site-packages/sipbuild/code_generator.cpython-310-x86_64-linux-gnu.so) sip6.x86_64: W: no-manual-page-for-binary sip-build sip6.x86_64: W: no-manual-page-for-binary sip-distinfo sip6.x86_64: W: no-manual-page-for-binary sip-install sip6.x86_64: W: no-manual-page-for-binary sip-module sip6.x86_64: W: no-manual-page-for-binary sip-sdist sip6.x86_64: W: no-manual-page-for-binary sip-wheel sip6.x86_64: W: invalid-license-exception exceptions) sip6.x86_64: W: invalid-license (GPLv2+ sip6.x86_64: E: files-duplicated-waste 378910 sip6.x86_64: W: files-duplicate /usr/lib64/python3.10/site-packages/sipbuild/module/source/13.1/MANIFEST.in /usr/lib64/python3.10/site-packages/sipbuild/module/source/12.7/MANIFEST.in:/usr/lib64/python3.10/site-packages/sipbuild/module/source/12.8/MANIFEST.in:/usr/lib64/python3.10/site-packages/sipbuild/module/source/12.9/MANIFEST.in:/usr/lib64/python3.10/site-packages/sipbuild/module/source/13.0/MANIFEST.in sip6.x86_64: W: files-duplicate /usr/lib64/python3.10/site-packages/sipbuild/module/source/12.9/README.in /usr/lib64/python3.10/site-packages/sipbuild/module/source/12.7/README.in:/usr/lib64/python3.10/site-packages/sipbuild/module/source/12.8/README.in sip6.x86_64: W: files-duplicate /usr/lib64/python3.10/site-packages/sipbuild/module/source/12.9/apiversions.c /usr/lib64/python3.10/site-packages/sipbuild/module/source/12.7/apiversions.c:/usr/lib64/python3.10/site-packages/sipbuild/module/source/12.8/apiversions.c sip6.x86_64: W: files-duplicate /usr/lib64/python3.10/site-packages/sipbuild/module/source/12.9/array.c /usr/lib64/python3.10/site-packages/sipbuild/module/source/12.7/array.c:/usr/lib64/python3.10/site-packages/sipbuild/module/source/12.8/array.c sip6.x86_64: W: files-duplicate /usr/lib64/python3.10/site-packages/sipbuild/module/source/13.1/array.h /usr/lib64/python3.10/site-packages/sipbuild/module/source/12.7/array.h:/usr/lib64/python3.10/site-packages/sipbuild/module/source/12.8/array.h:/usr/lib64/python3.10/site-packages/sipbuild/module/source/12.9/array.h:/usr/lib64/python3.10/site-packages/sipbuild/module/source/13.0/array.h sip6.x86_64: W: files-duplicate /usr/lib64/python3.10/site-packages/sipbuild/module/source/13.1/bool.cpp /usr/lib64/python3.10/site-packages/sipbuild/module/source/12.7/bool.cpp:/usr/lib64/python3.10/site-packages/sipbuild/module/source/12.8/bool.cpp:/usr/lib64/python3.10/site-packages/sipbuild/module/source/12.9/bool.cpp:/usr/lib64/python3.10/site-packages/sipbuild/module/source/13.0/bool.cpp sip6.x86_64: W: files-duplicate /usr/lib64/python3.10/site-packages/sipbuild/module/source/12.9/descriptors.c /usr/lib64/python3.10/site-packages/sipbuild/module/source/12.7/descriptors.c:/usr/lib64/python3.10/site-packages/sipbuild/module/source/12.8/descriptors.c sip6.x86_64: W: files-duplicate /usr/lib64/python3.10/site-packages/sipbuild/module/source/12.9/int_convertors.c /usr/lib64/python3.10/site-packages/sipbuild/module/source/12.7/int_convertors.c:/usr/lib64/python3.10/site-packages/sipbuild/module/source/12.8/int_convertors.c sip6.x86_64: W: files-duplicate /usr/lib64/python3.10/site-packages/sipbuild/module/source/13.1/objmap.c /usr/lib64/python3.10/site-packages/sipbuild/module/source/12.7/objmap.c:/usr/lib64/python3.10/site-packages/sipbuild/module/source/12.8/objmap.c:/usr/lib64/python3.10/site-packages/sipbuild/module/source/12.9/objmap.c:/usr/lib64/python3.10/site-packages/sipbuild/module/source/13.0/objmap.c sip6.x86_64: W: files-duplicate /usr/lib64/python3.10/site-packages/sipbuild/module/source/13.1/pyproject.toml /usr/lib64/python3.10/site-packages/sipbuild/module/source/12.7/pyproject.toml:/usr/lib64/python3.10/site-packages/sipbuild/module/source/12.8/pyproject.toml:/usr/lib64/python3.10/site-packages/sipbuild/module/source/12.9/pyproject.toml:/usr/lib64/python3.10/site-packages/sipbuild/module/source/13.0/pyproject.toml sip6.x86_64: W: files-duplicate /usr/lib64/python3.10/site-packages/sipbuild/module/source/12.9/qtlib.c /usr/lib64/python3.10/site-packages/sipbuild/module/source/12.7/qtlib.c:/usr/lib64/python3.10/site-packages/sipbuild/module/source/12.8/qtlib.c sip6.x86_64: W: files-duplicate /usr/lib64/python3.10/site-packages/sipbuild/module/source/12.9/setup.cfg.in /usr/lib64/python3.10/site-packages/sipbuild/module/source/12.7/setup.cfg.in:/usr/lib64/python3.10/site-packages/sipbuild/module/source/12.8/setup.cfg.in sip6.x86_64: W: files-duplicate /usr/lib64/python3.10/site-packages/sipbuild/module/source/12.9/setup.py.in /usr/lib64/python3.10/site-packages/sipbuild/module/source/12.7/setup.py.in:/usr/lib64/python3.10/site-packages/sipbuild/module/source/12.8/setup.py.in sip6.x86_64: W: files-duplicate /usr/lib64/python3.10/site-packages/sipbuild/module/source/12.9/sip.rst.in /usr/lib64/python3.10/site-packages/sipbuild/module/source/12.7/sip.rst.in:/usr/lib64/python3.10/site-packages/sipbuild/module/source/12.8/sip.rst.in sip6.x86_64: W: files-duplicate /usr/lib64/python3.10/site-packages/sipbuild/module/source/12.9/sipint.h /usr/lib64/python3.10/site-packages/sipbuild/module/source/12.7/sipint.h:/usr/lib64/python3.10/site-packages/sipbuild/module/source/12.8/sipint.h sip6.x86_64: W: files-duplicate /usr/lib64/python3.10/site-packages/sipbuild/module/source/13.1/threads.c /usr/lib64/python3.10/site-packages/sipbuild/module/source/12.7/threads.c:/usr/lib64/python3.10/site-packages/sipbuild/module/source/12.8/threads.c:/usr/lib64/python3.10/site-packages/sipbuild/module/source/12.9/threads.c:/usr/lib64/python3.10/site-packages/sipbuild/module/source/13.0/threads.c sip6.x86_64: W: files-duplicate /usr/lib64/python3.10/site-packages/sipbuild/module/source/12.9/voidptr.c /usr/lib64/python3.10/site-packages/sipbuild/module/source/12.7/voidptr.c:/usr/lib64/python3.10/site-packages/sipbuild/module/source/12.8/voidptr.c sip6.x86_64: W: files-duplicate /usr/lib64/python3.10/site-packages/sipbuild/module/source/12.9/sip.pyi /usr/lib64/python3.10/site-packages/sipbuild/module/source/12.8/sip.pyi sip6.x86_64: W: files-duplicate /usr/lib64/python3.10/site-packages/sipbuild/module/source/13.1/README.in /usr/lib64/python3.10/site-packages/sipbuild/module/source/13.0/README.in sip6.x86_64: W: files-duplicate /usr/lib64/python3.10/site-packages/sipbuild/module/source/13.1/array.c /usr/lib64/python3.10/site-packages/sipbuild/module/source/13.0/array.c sip6.x86_64: W: files-duplicate /usr/lib64/python3.10/site-packages/sipbuild/module/source/13.1/descriptors.c /usr/lib64/python3.10/site-packages/sipbuild/module/source/13.0/descriptors.c sip6.x86_64: W: files-duplicate /usr/lib64/python3.10/site-packages/sipbuild/module/source/13.1/int_convertors.c /usr/lib64/python3.10/site-packages/sipbuild/module/source/13.0/int_convertors.c sip6.x86_64: W: files-duplicate /usr/lib64/python3.10/site-packages/sipbuild/module/source/13.1/setup.cfg.in /usr/lib64/python3.10/site-packages/sipbuild/module/source/13.0/setup.cfg.in sip6.x86_64: W: files-duplicate /usr/lib64/python3.10/site-packages/sipbuild/module/source/13.1/setup.py.in /usr/lib64/python3.10/site-packages/sipbuild/module/source/13.0/setup.py.in sip6.x86_64: W: files-duplicate /usr/lib64/python3.10/site-packages/sipbuild/module/source/13.1/sip.pyi /usr/lib64/python3.10/site-packages/sipbuild/module/source/13.0/sip.pyi sip6.x86_64: W: files-duplicate /usr/lib64/python3.10/site-packages/sipbuild/module/source/13.1/sip.rst.in /usr/lib64/python3.10/site-packages/sipbuild/module/source/13.0/sip.rst.in sip6.x86_64: W: files-duplicate /usr/lib64/python3.10/site-packages/sipbuild/module/source/13.1/sipint.h /usr/lib64/python3.10/site-packages/sipbuild/module/source/13.0/sipint.h sip6.x86_64: W: files-duplicate /usr/lib64/python3.10/site-packages/sipbuild/module/source/13.1/voidptr.c /usr/lib64/python3.10/site-packages/sipbuild/module/source/13.0/voidptr.c sip6.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.10/site-packages/sipbuild/module/source/12.7/apiversions.c sip6.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.10/site-packages/sipbuild/module/source/12.7/array.c sip6.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.10/site-packages/sipbuild/module/source/12.7/array.h sip6.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.10/site-packages/sipbuild/module/source/12.7/bool.cpp sip6.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.10/site-packages/sipbuild/module/source/12.7/descriptors.c sip6.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.10/site-packages/sipbuild/module/source/12.7/int_convertors.c sip6.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.10/site-packages/sipbuild/module/source/12.7/objmap.c sip6.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.10/site-packages/sipbuild/module/source/12.7/qtlib.c sip6.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.10/site-packages/sipbuild/module/source/12.7/sipint.h sip6.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.10/site-packages/sipbuild/module/source/12.7/siplib.c sip6.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.10/site-packages/sipbuild/module/source/12.7/threads.c sip6.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.10/site-packages/sipbuild/module/source/12.7/voidptr.c sip6.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.10/site-packages/sipbuild/module/source/12.8/apiversions.c sip6.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.10/site-packages/sipbuild/module/source/12.8/array.c sip6.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.10/site-packages/sipbuild/module/source/12.8/array.h sip6.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.10/site-packages/sipbuild/module/source/12.8/bool.cpp sip6.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.10/site-packages/sipbuild/module/source/12.8/descriptors.c sip6.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.10/site-packages/sipbuild/module/source/12.8/int_convertors.c sip6.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.10/site-packages/sipbuild/module/source/12.8/objmap.c sip6.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.10/site-packages/sipbuild/module/source/12.8/qtlib.c sip6.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.10/site-packages/sipbuild/module/source/12.8/sipint.h sip6.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.10/site-packages/sipbuild/module/source/12.8/siplib.c sip6.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.10/site-packages/sipbuild/module/source/12.8/threads.c sip6.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.10/site-packages/sipbuild/module/source/12.8/voidptr.c sip6.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.10/site-packages/sipbuild/module/source/12.9/apiversions.c sip6.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.10/site-packages/sipbuild/module/source/12.9/array.c sip6.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.10/site-packages/sipbuild/module/source/12.9/array.h sip6.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.10/site-packages/sipbuild/module/source/12.9/bool.cpp sip6.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.10/site-packages/sipbuild/module/source/12.9/descriptors.c sip6.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.10/site-packages/sipbuild/module/source/12.9/int_convertors.c sip6.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.10/site-packages/sipbuild/module/source/12.9/objmap.c sip6.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.10/site-packages/sipbuild/module/source/12.9/qtlib.c sip6.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.10/site-packages/sipbuild/module/source/12.9/sipint.h sip6.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.10/site-packages/sipbuild/module/source/12.9/siplib.c sip6.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.10/site-packages/sipbuild/module/source/12.9/threads.c sip6.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.10/site-packages/sipbuild/module/source/12.9/voidptr.c sip6.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.10/site-packages/sipbuild/module/source/13.0/array.c sip6.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.10/site-packages/sipbuild/module/source/13.0/array.h sip6.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.10/site-packages/sipbuild/module/source/13.0/bool.cpp sip6.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.10/site-packages/sipbuild/module/source/13.0/descriptors.c sip6.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.10/site-packages/sipbuild/module/source/13.0/int_convertors.c sip6.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.10/site-packages/sipbuild/module/source/13.0/objmap.c sip6.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.10/site-packages/sipbuild/module/source/13.0/sipint.h sip6.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.10/site-packages/sipbuild/module/source/13.0/siplib.c sip6.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.10/site-packages/sipbuild/module/source/13.0/threads.c sip6.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.10/site-packages/sipbuild/module/source/13.0/voidptr.c sip6.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.10/site-packages/sipbuild/module/source/13.1/array.c sip6.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.10/site-packages/sipbuild/module/source/13.1/array.h sip6.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.10/site-packages/sipbuild/module/source/13.1/bool.cpp sip6.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.10/site-packages/sipbuild/module/source/13.1/descriptors.c sip6.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.10/site-packages/sipbuild/module/source/13.1/int_convertors.c sip6.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.10/site-packages/sipbuild/module/source/13.1/objmap.c sip6.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.10/site-packages/sipbuild/module/source/13.1/sipint.h sip6.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.10/site-packages/sipbuild/module/source/13.1/siplib.c sip6.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.10/site-packages/sipbuild/module/source/13.1/threads.c sip6.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.10/site-packages/sipbuild/module/source/13.1/voidptr.c ================ 1 packages and 0 specfiles checked; 1 errors, 113 warnings, 1 badness; has taken 0.2 s ================ Unversioned so-files -------------------- sip6: /usr/lib64/python3.10/site-packages/sipbuild/code_generator.cpython-310-x86_64-linux-gnu.so Source checksums ---------------- https://files.pythonhosted.org/packages/source/s/sip/sip-6.1.1.tar.gz : CHECKSUM(SHA256) this package : 52d25af2fcd764c4e15cc9cd1350bdb0e63f52dfa2aa3c5e7679af7fde9f7e20 CHECKSUM(SHA256) upstream package : 52d25af2fcd764c4e15cc9cd1350bdb0e63f52dfa2aa3c5e7679af7fde9f7e20 Requires -------- sip6 (rpmlib, GLIBC filtered): /usr/bin/python3 libc.so.6()(64bit) python(abi) python3.10dist(packaging) python3.10dist(toml) rtld(GNU_HASH) sip6-debuginfo (rpmlib, GLIBC filtered): sip6-debugsource (rpmlib, GLIBC filtered): Provides -------- sip6: python-sip6 python3-sip6 python3.10-sip6 python3.10dist(sip) python3dist(sip) sip6 sip6(x86-64) sip6-debuginfo: debuginfo(build-id) sip6-debuginfo sip6-debuginfo(x86-64) sip6-debugsource: sip6-debugsource sip6-debugsource(x86-64) Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10 Command line :/usr/bin/fedora-review -b 1981978 -m fedora-rawhide-x86_64 Buildroot used: fedora-rawhide-x86_64 Active plugins: C/C++, Python, Shell-api, Generic Disabled plugins: Java, SugarActivity, fonts, PHP, Perl, Ocaml, R, Haskell, Ruby Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
(In reply to Jerry James from comment #2) > Issues: > ======= > - Since this package is intended to replace the sip5 package, shouldn't it > have > Obsoletes and Provides for sip5? > > - Please add a comment explaining the patch (a SHOULD item) > > - If no other form of testing makes sense (such as building the examples), > then > this is now possible in Rawhide: > > %check > %py3_check_import sipbuild sipbuild.distinfo sipbuild.module sipbuild.tools Thanks for the review and comments. I have addressed all of these. I had thought about the Obsoletes and Provides for sip5 before but omitted them because all the users of sip5 (I believe) declare their dependencies using the python3dist(sip) name. But it can't hurt to add them anyway just so it's clear to everyone. Ideally this package should be just an update under the 'sip' name (and perhaps rename the existing package to sip4) but it seems like this was the easier route given that a lot of the legacy stuff uses the sip name.
Looks good. This package is APPROVED. Miro just barely submitted updates for F33 and F34 to make %py3_check_import available, so that %check script will only work on Rawhide until those updates go stable.
(In reply to Jerry James from comment #4) > Looks good. This package is APPROVED. Miro just barely submitted updates > for F33 and F34 to make %py3_check_import available, so that %check script > will only work on Rawhide until those updates go stable. Thanks, I intend to only send this to Rawhide anyway.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/sip6
suggestion: I would like to share a incompatible point between sip6 and sip5 according to my usage of sip5 and sip6 on fc35. For example, the `enum DataType{ intType, floatType }' defined in a C++ namespace, say `foo'. The enum's elements are mapped to a global python object named `foo', with sip5. And you can use foo.intType in python. While with sip6, such a usage is invalid in python, and you have to use foo.DataType.intType to refer to the same value. It seems not select-able between the two fashions in sip6.
(In reply to woodhead from comment #7) > suggestion: I would like to share a incompatible point between sip6 and sip5 > according to my usage of sip5 and sip6 on fc35. > For example, the `enum DataType{ intType, floatType }' defined in a C++ > namespace, say `foo'. The enum's elements are mapped to a global python > object named `foo', with sip5. And you can use foo.intType in python. While > with sip6, such a usage is invalid in python, and you have to use > foo.DataType.intType to refer to the same value. It seems not select-able > between the two fashions in sip6. It's probably best to take your concern upstream (the PyQt mailing list is probably the best place): https://www.riverbankcomputing.com/mailman/listinfo/pyqt