Spec URL: https://sergiomb.fedorapeople.org/biglybt.spec SRPM URL: https://sergiomb.fedorapeople.org/biglybt-2.8.0.0-1.fc35.src.rpm Description: BiglyBT is forked from Vuze/Azureus and is being maintained by two of the original developers as well as members of the community. Fedora Account System Username: sergiomb
This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=71845746
Hi, I just installed biglybt*.noarch.rpm and this error occurs: > $ biglybt > Starting BiglyBT... > /usr/bin/build-classpath: Could not find json_simple Java extension for this JVM > /usr/bin/build-classpath: Could not find bcprov Java extension for this JVM > /usr/bin/build-classpath: Could not find apache-commons-cli Java extension for this JVM > /usr/bin/build-classpath: Could not find apache-commons-lang Java extension for this JVM > /usr/bin/build-classpath: error: Some specified jars were not found > WARNING: An illegal reflective access operation has occurred > WARNING: Illegal reflective access by com.biglybt.core.util.spi.AENameServiceJava9 (file:/usr/share/java/biglybt/BiglyBT.jar) to field java.net.InetAddress.impl > WARNING: Please consider reporting this to the maintainers of com.biglybt.core.util.spi.AENameServiceJava9 > WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations > WARNING: All illegal access operations will be denied in a future release > Loading BiglyBT: > Error: Unable to initialize main class com.biglybt.ui.Main > Caused by: java.lang.NoClassDefFoundError: org/apache/commons/cli/ParseException > Exit from BiglyBT complete > WARNING: An illegal reflective access operation has occurred > WARNING: Illegal reflective access by com.biglybt.core.util.spi.AENameServiceJava9 (file:/usr/share/java/biglybt/BiglyBT.jar) to field java.net.InetAddress.impl > WARNING: Please consider reporting this to the maintainers of com.biglybt.core.util.spi.AENameServiceJava9 > WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations > WARNING: All illegal access operations will be denied in a future release > No shutdown tasks to do > BiglyBT TERMINATED. it looks like the package is not installed correctly.
Thanks for the feedback I found and fix the problem I was the patch to java /usr/lib/jvm/java-11/bin/java , when the correct is /usr/lib/jvm/java-11/bin/java warnig messages of "/usr/bin/build-classpath: Could not find" also fixed I have updated biglybt.spec and biglybt-2.8.0.0-1.fc35.src.rpm in same place . I you builds in copr for f33+ 64 bits platforms https://copr.fedorainfracloud.org/coprs/sergiomb/builds_for_Stable_Releases/package/biglybt/ https://copr.fedorainfracloud.org/coprs/sergiomb/builds_for_Stable_Releases/build/2529595/ https://koji.fedoraproject.org/koji/taskinfo?taskID=74113193
also need add apache-commons-cli https://koji.fedoraproject.org/koji/taskinfo?taskID=74113482
> Issues: > ======= > - Package uses either %{buildroot} or $RPM_BUILD_ROOT > Note: Using both %{buildroot} and $RPM_BUILD_ROOT > See: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_macros You should not mix %{buildroot} and $RPM_BUILD_ROOT See https://docs.fedoraproject.org/en-US/packaging-guidelines/#_using_buildroot_and_optflags_vs_rpm_build_root_and_rpm_opt_flags > - Javadoc documentation files are generated and included in -javadoc > subpackage > Note: No javadoc subpackage present. Note: Javadocs are optional for > Fedora versions >= 21 > See: https://fedoraproject.org/wiki/Packaging:Java#Javadoc_installation > - Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink) > Note: No javadoc subpackage present > See: https://fedoraproject.org/wiki/Packaging:Java#Javadoc_installation There is no javadoc generation. > ===== MUST items ===== > > Generic: > [ ]: Package successfully compiles and builds into binary rpms on at least > one supported primary architecture. > Note: Using prebuilt packages There is: * org apache commons lang in core/src/ folder * org gudy bouncycastle * in core/src/ folder * org json simple in core/src/folder * org eclipse swt widgets in uis/src/ folder is that packages bundled in biglybt? they should be unbundled if possible See https://docs.fedoraproject.org/en-US/packaging-guidelines/#bundling > [ ]: Package must own all directories that it creates. > Note: Directories without known owners: /usr/share/application- > registry Using unowned directory: /usr/share/application-registry See https://docs.fedoraproject.org/en-US/packaging-guidelines/UnownedDirectories/ > Rpmlint > ------- > Checking: biglybt-2.8.0.0-1.fc36.noarch.rpm > biglybt-2.8.0.0-1.fc36.src.rpm > biglybt.noarch: W: spelling-error Summary(en_US) bittorrent -> bit torrent, bit-torrent, BitTorrent > biglybt.src: W: spelling-error Summary(en_US) bittorrent -> bit torrent, bit-torrent, BitTorrent > biglybt.noarch: W: summary-ended-with-dot C Source for BiglyBT, a feature filled, open source, ad-free, bittorrent client. > biglybt.src: W: summary-ended-with-dot C Source for BiglyBT, a feature filled, open source, ad-free, bittorrent client. Simply remove the trailing period from the summary field. > biglybt.noarch: W: name-repeated-in-summary C BiglyBT > biglybt.src: W: name-repeated-in-summary C BiglyBT > biglybt.noarch: E: description-line-too-long C BiglyBT is forked from Vuze/Azureus and is being maintained by two of the original developers as well as members of the community. > biglybt.src: E: description-line-too-long C BiglyBT is forked from Vuze/Azureus and is being maintained by two of the original developers as well as members of the community. You should split your description, where each line does not exceed 80 characters. > biglybt.noarch: W: class-path-in-manifest /usr/share/java/biglybt/BiglyBT.jar JAR files must not include class-path entry inside META-INF/MANIFEST.MF (See https://docs.fedoraproject.org/en-US/packaging-guidelines/Java/#_no_class_path_in_manifest_mf) You could remove it by using `sed -i '/class-path/I d' META-INF/MANIFEST.MF`, for example. > biglybt.src: W: strange-permission biglybt.desktop 775 A file that you listed in *.src.rpm has strange permissions. Use chmod to change it. > biglybt.src:105: W: macro-in-comment %{buildroot} > biglybt.src:105: W: macro-in-comment %{_bindir} Removes these comments > 2 packages and 0 specfiles checked; 2 errors, 10 warnings.
- You should not mix %{buildroot} and $RPM_BUILD_ROOT done - I add bundles I don't know the versions - I can't unbundle apache-commons-lang , because fedora have version 3 when biglybt use 2, - bouncycastle biglybt use a very old package I tried to migrate but give me some problems so I postpone the unbundle. - json_simple at have to test maybe we can unbundle easily (is a very little package). - Using unowned directory: /usr/share/application-registry rpm -qf /usr/share/application-registry/ gnome-mime-data-2.18.0-24.fc33.noarch I think spec is correct the directoy is owned by gnome-mime-data - Simply remove the trailing period from the summary field. I believe it is all done - You should split your description, where each line does not exceed 80 characters. I believe it is all done - JAR files must not include class-path entry inside META-INF/MANIFEST.MF done in %prep - biglybt.src: W: strange-permission biglybt.desktop 775 fixed Another problem eclise-swt has been removed for F35 and rawhide ..., so for now it just build in f34 and f33 buildroot fedora-review -b 1981982 -m fedora-34-x86_64
- There is no javadoc generation. I added javadoc generation - Removes these comments removed Spec URL: https://sergiomb.fedorapeople.org/biglybt/biglybt.spec SRPM URL: https://sergiomb.fedorapeople.org/biglybt/biglybt-2.8.0.0-1.fc36.src.rpm Description: BiglyBT is forked from Vuze/Azureus and is being maintained by two of the original developers as well as members of the community. Fedora Account System Username: sergiomb https://koji.fedoraproject.org/koji/taskinfo?taskID=74417946
*** Bug 1981971 has been marked as a duplicate of this bug. ***
*** Bug 1996892 has been marked as a duplicate of this bug. ***
Now that eclipse-swt have been reviewed, I'm gonna take this review. Probably in this weekend.
Hi, I have some update on my local machine , not published yet , I couldn't find a way to fix [1] [1] JAR files must not include class-path entry inside META-INF/MANIFEST.MF (See https://docs.fedoraproject.org/en-US/packaging-guidelines/Java/#_no_class_path_in_manifest_mf) You could remove it by using `sed -i '/class-path/I d' META-INF/MANIFEST.MF`, for example.
I just see the source code of biglybt. In this case, maybe you need to remove this from maven jar plugin. 1) addClasspath=true 2) manifestEntries/Class-Path=. swt.jar commons-cli.jar also in maven shade plugin 3) manifestEntries/Class-Path=. swt.jar commons-cli.jar three of them can be removed using %pom_xpath_remove
.. also I forgot to mention that's in the `/uis` module.
> I can't unbundle apache-commons-lang , because fedora have version 3 when biglybt use 2 This is easier than you think: In 99% of cases, all you need to do is fix the imports for the namespace change: sed -i -e 's/import org.apache.commons.lang/import org.apache.commons.lang3/'
here you have the state or the art , later I will try unbundle apache-commons-lang and fix MANISFEST.MF Spec URL: https://sergiomb.fedorapeople.org/biglybt/biglybt.spec SRPM URL: https://sergiomb.fedorapeople.org/biglybt/biglybt-2.8.0.0-2.fc36.src.rpm
Sergio: It'll be great to see BiglyBT as part of Fedora! Thanks for taking the time to work on it. I'm a frequent user of (and very occasional contributor to) BiglyBT, so if you need any co-maintainers once this makes it through the approval process, I'd be happy to pitch in.
This is an automatic check from review-stats script. This review request ticket hasn't been updated for some time, but it seems that the review is still being working out by you. If this is right, please respond to this comment clearing the NEEDINFO flag and try to reach out the submitter to proceed with the review. If you're not interested in reviewing this ticket anymore, please clear the fedora-review flag and reset the assignee, so that a new reviewer can take this ticket. Without any reply, this request will shortly be resetted.
This is an automatic action taken by review-stats script. The ticket reviewer failed to clear the NEEDINFO flag in a month. As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews we reset the status and the assignee of this ticket.
This is an automatic check from review-stats script. This review request ticket hasn't been updated for some time. We're sorry it is taking so long. If you're still interested in packaging this software into Fedora repositories, please respond to this comment clearing the NEEDINFO flag. You may want to update the specfile and the src.rpm to the latest version available and to propose a review swap on Fedora devel mailing list to increase chances to have your package reviewed. If this is your first package and you need a sponsor, you may want to post some informal reviews. Read more at https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group. Without any reply, this request will shortly be considered abandoned and will be closed. Thank you for your patience.
I will update it soon
Spec URL: https://sergiomb.fedorapeople.org/biglybt/biglybt.spec SRPM URL: https://sergiomb.fedorapeople.org/biglybt/biglybt-3.5.0.0-1.fc40.src.rpm
*** This bug has been marked as a duplicate of bug 2258366 ***