RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.

+++ This bug was initially created as a clone of Bug #1797879 +++

Description of problem:
Libvirt uses synchronous APIs for iscsi-direct type of pool, most notably iscsi_connect_sync(), iscsi_login_sync() and iscsi_reportluns_sync() (and plus some others). But those APIs don't return a negative value as documented but iSCSI status (e.g. SCSI_STATUS_GOOD) which is a positive integer. Thus when there's an error the caller doesn't see it.

Version-Release number of selected component (if applicable):
libvirt-6.0.0-2.virtcov.el8.x86_64
qemu-kvm-4.2.0-8.module+el8.2.0+5607+dc756904.x86_64
libiscsi-1.18.0-8.module+el8.2.0+4793+b09dd2fb.x86_64

How reproducible:
100%

Steps to Reproduce:
1. I've noticed this in the original bug, I can prepare an reproducer if really needed.

Actual results:
iscsi_login_sync() and others return a positive integer on error.

Expected results:
iscsi_login_sync() and others return -1 on error.

Additional info:

This is fixed upstream by the following commit:

https://github.com/sahlberg/libiscsi/commit/b5210a1e31afb9f0adf369cde11c612f3365432e

Thanks for Michal's help.

Reproduced this bug as below.

1. Install libiscsi-devel package.
#  yum install -y libiscsi-devel

2. Compile the codes.
# gcc $(pkg-config --cflags libiscsi) $(pkg-config --libs libiscsi) lsiscsi.c -o lsiscsi

3. Tested.
# ./lsiscsi iqn.2021-03.com.example:client 10.66.10.26:3260 iqn.2021-07.com.example:timaoxx
DEBUG createContext:49 : creating context
DEBUG createContext:72 : connecting
DEBUG createContext:79 : logging in
DEBUG createContext:86 : Login should have failed
DEBUG createContext:92 : logging out
ERROR createContext:94 : Failed to logout: Failed to start logout() Trying to logout while not logged in. : Operation now in progress

DEBUG createContext:98 : disconnecting
DEBUG createContext:103 : destroying context