Spec URL: https://download.copr.fedorainfracloud.org/results/lcts/nextcloud/fedora-rawhide-x86_64/02329590-php-christophwurst-id3parser/php-christophwurst-id3parser.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/lcts/nextcloud/fedora-rawhide-x86_64/02329590-php-christophwurst-id3parser/php-christophwurst-id3parser-0.1.2-1.fc35.src.rpm Description: ID3Parser is a pure ID3 parser based upon getID3. This library takes the ID3 parsing code from getID3 and strips all other functions. Since this package is set up to use rpmautospec, rpmlint/fedora-review will complain about missing dist tags & macros in changelog. These are spurious errors/warnings. This package is available from the lcts/nextcloud Copr, so you can also test it using 'fedora-review --copr-build 2329590' Fedora Account System Username: lcts
PSR-0 conflict :( /usr/share/php/ID3Parser is used by php-lukasreschke-id3parser, another fork of getid3 So I recommend to use a fake "vendor" directory, such as /usr/share/php/christophwurst/ID3Parser
Hi Christopher, i have a few comments, regarding this package. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 10 files have unknown license. Detailed output of licensecheck in /home/tkorbar/packaging/fedora/reviews/php- christophwurst-id3parser/php-christophwurst-id3parser/licensecheck.txt ----- I do not think that license should be GPLv3+ but GPLv3 instead. [ ]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/share/php/ID3Parser(php- lukasreschke-id3parser), /usr/share/php/ID3Parser/getID3(php- lukasreschke-id3parser), /usr/share/php/ID3Parser/getID3/Tags(php- lukasreschke-id3parser) ----- unfortunatelly this conflict will need to be resolved. You can use the solution Remi suggested. [ ]: Package does not generate any conflict. ----- Same as before, there is a conflict with lukasreschkes project
Spec URL: https://download.copr.fedorainfracloud.org/results/lcts/nextcloud/fedora-rawhide-x86_64/02364095-php-christophwurst-id3parser/php-christophwurst-id3parser.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/lcts/nextcloud/fedora-rawhide-x86_64/02364095-php-christophwurst-id3parser/php-christophwurst-id3parser-0.1.2-1.fc35.src.rpm Hey, thanks for the review & sorry for the delay. $DAYJOB intervened... (In reply to Tomas Korbar from comment #2) > ----- I do not think that license should be GPLv3+ but GPLv3 instead. Fixed. > [ ]: Package does not own files or directories owned by other packages. > > ----- unfortunatelly this conflict will need to be resolved. > You can use the solution Remi suggested. > > [ ]: Package does not generate any conflict. > > ----- Same as before, there is a conflict with lukasreschkes project Fixed, the package now installs into %{phpdir}/ChristophWurst/ID3Parser as suggested.
The spec looks ok now.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/php-christophwurst-id3parser