Fedora Account System
Red Hat Associate
Red Hat Customer
Spec URL: https://download.copr.fedorainfracloud.org/results/mhayden/python-google-cloud/fedora-rawhide-x86_64/02331005-python-proto-plus/python-proto-plus.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/mhayden/python-google-cloud/fedora-rawhide-x86_64/02331005-python-proto-plus/python-proto-plus-1.19.0-1.fc35.src.rpm Description: This is a wrapper around protocol buffers. Protocol buffers is a specification format for APIs, such as those inside Google. This library provides protocol buffer message classes and objects that largely behave like native Python types. Fedora Account System Username: mhayden COPR fedora-review: https://copr-be.cloud.fedoraproject.org/results/mhayden/python-google-cloud/fedora-rawhide-x86_64/02331005-python-proto-plus/fedora-review/
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated ===== Issues ===== - It seems like you don’t really need the google-api-client BR, just the “google-api-core[grpc]” from the “testing” extra. Changing %pyproject_buildrequires -r to %pyproject_buildrequires -x testing allows you to drop the explicit google-api-client BR. - This %if %{with tests} BuildRequires: python3-pytest %endif would be better written as %if %{with tests} BuildRequires: python3dist(pytest) %endif and these BuildRequires: python3-sphinx BuildRequires: python3-sphinx_rtd_theme would be better written as BuildRequires: python3dist(sphinx) BuildRequires: python3dist(sphinx-rtd-theme) - You can fix this: loading intersphinx inventory from https://docs.python.org/3/objects.inv... WARNING: failed to reach any of the inventories with the following issues: intersphinx inventory 'https://docs.python.org/3/objects.inv' not fetchable due to <class 'requests.exceptions.ConnectionError'>: HTTPSConnectionPool(host='docs.python.org', port=443): Max retries exceeded with url: /3/objects.inv (Caused by NewConnectionError('<urllib3.connection.HTTPSConnection object at 0xffff99f953c0>: Failed to establish a new connection: [Errno -3] Temporary failure in name resolution')) In %prep, add: # Use local inventory in intersphinx mapping. sed -r -i -e 's|https://docs.python.org/3|/%{_docdir}/python3-docs/html|' \ docs/conf.py and in %package doc, add Requires: python3-docs ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* Apache License 2.0", "Apache License 2.0". 25 files have unknown license. Detailed output of licensecheck in /home/reviewer/1982800-python-proto- plus/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: No rpmlint messages. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python3-proto-plus [x]: Package functions as described. (based on tests passing) [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python3-proto-plus-1.19.0-1.fc35.noarch.rpm python3-proto-plus-doc-1.19.0-1.fc35.noarch.rpm python-proto-plus-1.19.0-1.fc35.src.rpm 3 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output: Source checksums ---------------- https://github.com/googleapis/proto-plus-python/archive/v1.19.0/proto-plus-python-1.19.0.tar.gz : CHECKSUM(SHA256) this package : 23c765a2e44f4c3fb2e61d697018a80a6a25a44b7e2f2484efa9afcdbb5762cf CHECKSUM(SHA256) upstream package : 23c765a2e44f4c3fb2e61d697018a80a6a25a44b7e2f2484efa9afcdbb5762cf Requires -------- python3-proto-plus (rpmlib, GLIBC filtered): python(abi) python3.10dist(protobuf) python3-proto-plus-doc (rpmlib, GLIBC filtered): Provides -------- python3-proto-plus: python-proto-plus python3-proto-plus python3.10-proto-plus python3.10dist(proto-plus) python3dist(proto-plus) python3-proto-plus-doc: python-proto-plus-doc python3-proto-plus-doc python3.10-proto-plus-doc Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10 Command line :/usr/bin/fedora-review -b 1982800 Buildroot used: fedora-rawhide-aarch64 Active plugins: Python, Shell-api, Generic Disabled plugins: Ocaml, SugarActivity, Java, Haskell, R, PHP, fonts, C/C++, Perl Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
(In reply to Ben Beasley from comment #1) > - It seems like you don’t really need the google-api-client BR, just the > “google-api-core[grpc]” from the “testing” extra. Changing > > %pyproject_buildrequires -r > > to > > %pyproject_buildrequires -x testing > > allows you to drop the explicit google-api-client BR. That's awesome and I didn't realize that was possible! > - This > > %if %{with tests} > BuildRequires: python3-pytest > %endif > > would be better written as > > %if %{with tests} > BuildRequires: python3dist(pytest) > %endif > > and these > > BuildRequires: python3-sphinx > BuildRequires: python3-sphinx_rtd_theme > > would be better written as > > BuildRequires: python3dist(sphinx) > BuildRequires: python3dist(sphinx-rtd-theme) Thank you. Fixed. > - You can fix this: > > loading intersphinx inventory from > https://docs.python.org/3/objects.inv... > WARNING: failed to reach any of the inventories with the following > issues: > intersphinx inventory 'https://docs.python.org/3/objects.inv' not > fetchable > due to <class 'requests.exceptions.ConnectionError'>: > HTTPSConnectionPool(host='docs.python.org', port=443): Max retries > exceeded with url: /3/objects.inv (Caused by > NewConnectionError('<urllib3.connection.HTTPSConnection object at > 0xffff99f953c0>: Failed to establish a new connection: [Errno -3] > Temporary failure in name resolution')) > > In %prep, add: > > # Use local inventory in intersphinx mapping. > sed -r -i -e > 's|https://docs.python.org/3|/%{_docdir}/python3-docs/html|' \ > docs/conf.py > > and in %package doc, add > > Requires: python3-docs Done. Spec URL: https://download.copr.fedorainfracloud.org/results/mhayden/python-google-cloud/fedora-rawhide-x86_64/02331888-python-proto-plus/python-proto-plus.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/mhayden/python-google-cloud/fedora-rawhide-x86_64/02331888-python-proto-plus/python-proto-plus-1.19.0-1.fc35.src.rpm COPR fedora-review: https://download.copr.fedorainfracloud.org/results/mhayden/python-google-cloud/fedora-rawhide-x86_64/02331888-python-proto-plus/fedora-review
Package approved, but please see the one Issue below: Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated ===== Issues ===== - I forgot to mention you should also add BuildRequires: python3-docs to fix the intersphinx inventories. As it is, you still have loading intersphinx inventory from //usr/share/doc/python3-docs/html/objects.inv... WARNING: failed to reach any of the inventories with the following issues: intersphinx inventory '//usr/share/doc/python3-docs/html/objects.inv' not fetchable due to <class 'FileNotFoundError'>: [Errno 2] No such file or directory: '//usr/share/doc/python3-docs/html/objects.inv' ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* Apache License 2.0", "Apache License 2.0". 25 files have unknown license. Detailed output of licensecheck in /home/reviewer/1982800-python-proto-plus/re- review/1982800-python-proto-plus/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: No rpmlint messages. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [ ]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python3-proto-plus [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python3-proto-plus-1.19.0-1.fc35.noarch.rpm python3-proto-plus-doc-1.19.0-1.fc35.noarch.rpm python-proto-plus-1.19.0-1.fc35.src.rpm 3 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output: Source checksums ---------------- https://github.com/googleapis/proto-plus-python/archive/v1.19.0/proto-plus-python-1.19.0.tar.gz : CHECKSUM(SHA256) this package : 23c765a2e44f4c3fb2e61d697018a80a6a25a44b7e2f2484efa9afcdbb5762cf CHECKSUM(SHA256) upstream package : 23c765a2e44f4c3fb2e61d697018a80a6a25a44b7e2f2484efa9afcdbb5762cf Requires -------- python3-proto-plus (rpmlib, GLIBC filtered): python(abi) python3.10dist(protobuf) python3-proto-plus-doc (rpmlib, GLIBC filtered): python3-docs Provides -------- python3-proto-plus: python-proto-plus python3-proto-plus python3.10-proto-plus python3.10dist(proto-plus) python3dist(proto-plus) python3-proto-plus-doc: python-proto-plus-doc python3-proto-plus-doc python3.10-proto-plus-doc Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10 Command line :/usr/bin/fedora-review -b 1982800 --mock-options=--enablerepo=local Buildroot used: fedora-rawhide-aarch64 Active plugins: Python, Shell-api, Generic Disabled plugins: R, C/C++, Haskell, PHP, SugarActivity, Java, fonts, Perl, Ocaml Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
Good catch on the BuildRequires. I'll get that fixed prior to import.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-proto-plus