Spec URL: https://download.copr.fedorainfracloud.org/results/mhayden/python-google-cloud/fedora-rawhide-x86_64/02331969-python-google-cloud-iam/python-google-cloud-iam.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/mhayden/python-google-cloud/fedora-rawhide-x86_64/02331969-python-google-cloud-iam/python-google-cloud-iam-2.3.0-1.fc35.src.rpm Description: Manages identity and access control for Google Cloud Platform resources, including the creation of service accounts, which you can use to authenticate to Google and make API calls. Fedora Account System Username: mhayden COPR fedora-review: https://download.copr.fedorainfracloud.org/results/mhayden/python-google-cloud/fedora-rawhide-x86_64/02331969-python-google-cloud-iam/fedora-review
Looks great. I went ahead and approved the package, but there are a few more documentation text files that should be added as noted below. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated ===== Issues ===== - Please add CODE_OF_CONDUCT.md, CONTRIBUTING.rst, SECURITY.md, and UPGRADING.md as %doc, either in the base package or in the -doc subpackage. ===== Notes (no change required) ===== - I was going to ask you to add %pyproject_extras_subpkg -n python3-%{srcname} fixup to create the metapackage (https://fedoraproject.org/wiki/Changes/PythonExtras#Extras_metapackages) for the “fixup” extra, but then I noticed that this only supports the “fixup_credentials_v1_keywords.py” script, which you are not shipping—so I think omitting this extra makes sense. ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Apache License 2.0", "Unknown or generated", "*No copyright* Apache License 2.0", "*No copyright* [generated file]". 68 files have unknown license. Detailed output of licensecheck in /home/reviewer/1982801-python-google-cloud-iam/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/lib/python3.10/site- packages/google(python3-googleapis-common-protos, python3-google-api- core, python3-protobuf) This is the %{python3_sitelib}/google namespace package directory. Co-ownership is appropriate. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python3-google-cloud-iam [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python3-google-cloud-iam-2.3.0-1.fc35.noarch.rpm python3-google-cloud-iam-doc-2.3.0-1.fc35.noarch.rpm python-google-cloud-iam-2.3.0-1.fc35.src.rpm python3-google-cloud-iam-doc.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/python3-google-cloud-iam-doc/html/objects.inv python3-google-cloud-iam-doc.noarch: W: file-not-utf8 /usr/share/doc/python3-google-cloud-iam-doc/html/objects.inv 3 packages and 0 specfiles checked; 0 errors, 2 warnings. Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output: Source checksums ---------------- https://github.com/googleapis/python-iam/archive/v2.3.0/python-iam-2.3.0.tar.gz : CHECKSUM(SHA256) this package : 0408b7ae0cbc94b8c62dc949d6e5c9aafff56fa80091bb9192f8da2612024309 CHECKSUM(SHA256) upstream package : 0408b7ae0cbc94b8c62dc949d6e5c9aafff56fa80091bb9192f8da2612024309 Requires -------- python3-google-cloud-iam (rpmlib, GLIBC filtered): (python3.10dist(google-api-core) < 2~~dev0 with python3.10dist(google-api-core) >= 1.26) (python3.10dist(google-api-core[grpc]) < 2~~dev0 with python3.10dist(google-api-core[grpc]) >= 1.26) python(abi) python3.10dist(packaging) python3.10dist(proto-plus) python3-google-cloud-iam-doc (rpmlib, GLIBC filtered): python3-docs Provides -------- python3-google-cloud-iam: python-google-cloud-iam python3-google-cloud-iam python3.10-google-cloud-iam python3.10dist(google-cloud-iam) python3dist(google-cloud-iam) python3-google-cloud-iam-doc: python-google-cloud-iam-doc python3-google-cloud-iam-doc python3.10-google-cloud-iam-doc Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10 Command line :/usr/bin/fedora-review -b 1982801 Buildroot used: fedora-rawhide-aarch64 Active plugins: Python, Generic, Shell-api Disabled plugins: R, C/C++, Java, Haskell, fonts, SugarActivity, PHP, Ocaml, Perl Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
(In reply to Ben Beasley from comment #1) > ===== Issues ===== > > - Please add CODE_OF_CONDUCT.md, CONTRIBUTING.rst, SECURITY.md, and > UPGRADING.md as %doc, either in the base package or in the -doc subpackage. Thanks for catching that. I'll add those to the base package on import. > ===== Notes (no change required) ===== > > - I was going to ask you to add > > %pyproject_extras_subpkg -n python3-%{srcname} fixup > > to create the metapackage > (https://fedoraproject.org/wiki/Changes/PythonExtras#Extras_metapackages) > for > the “fixup” extra, but then I noticed that this only supports the > “fixup_credentials_v1_keywords.py” script, which you are not shipping—so I > think omitting this extra makes sense. I looked through the script and it doesn't seem like it has much use with the current code. I also wanted to avoid clogging up %{_bindir} with something that didn't seem to be required. Thanks for reviewing! 🤗
> I looked through the script and it doesn't seem like it has much use with the current code. I also wanted to avoid clogging up %{_bindir} with something that didn't seem to be required. I agree.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-google-cloud-iam