Bug 1982942 - Review Request: rust-spin_sleep - Accurate sleeping
Summary: Review Request: rust-spin_sleep - Accurate sleeping
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Robert-André Mauchin 🐧
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1982945
TreeView+ depends on / blocked
 
Reported: 2021-07-16 05:01 UTC by Rémi Lauzier
Modified: 2022-02-09 02:08 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2022-01-31 23:41:53 UTC
Type: ---
Embargoed:
zebob.m: fedora-review+


Attachments (Terms of Use)

Comment 1 Robert-André Mauchin 🐧 2022-01-23 17:56:12 UTC
 - License ok
 - Latest version packaged
 - Builds in mock
 - No rpmlint errors
 - Checks pass
 - Conforms to Packaging Guidelines

Package approved

Comment 2 Fabio Valentini 2022-01-23 18:01:51 UTC
> # Generated by rust2rpm 18

Please regenerate the .spec file with rust2rpm 20 before building this package for Fedora.

Also consider excluding some useless / development-only files from the package: /release, /rustfmt.toml

Comment 3 Rémi Lauzier 2022-01-29 06:38:47 UTC
It seem that i am unable to use rust2rpm to update this library. it says that there is no cargo.toml in the crate. any ideas on what is going on?

Traceback (most recent call last):
  File "/usr/bin/rust2rpm", line 33, in <module>
    sys.exit(load_entry_point('rust2rpm==20', 'console_scripts', 'rust2rpm')())
  File "/usr/lib64/python3.10/contextlib.py", line 79, in inner
    return func(*args, **kwds)
  File "/usr/lib/python3.10/site-packages/rust2rpm/__main__.py", line 379, in main
    crate, diff, metadata, doc_files, license_files = make_diff_metadata(
  File "/usr/lib/python3.10/site-packages/rust2rpm/__main__.py", line 279, in make_diff_metadata
    with files_from_crate(cratef, crate, version) as (toml, doc_files, license_files):
  File "/usr/lib64/python3.10/contextlib.py", line 135, in __enter__
    return next(self.gen)
  File "/usr/lib/python3.10/site-packages/rust2rpm/__main__.py", line 189, in files_from_crate
    raise IOError("crate does not contain Cargo.toml file")
OSError: crate does not contain Cargo.toml file

Comment 4 Rémi Lauzier 2022-01-29 07:05:54 UTC
My error, i was requesting spin-sleep instead of spin_sleep.

Comment 6 Fabio Valentini 2022-01-30 11:16:39 UTC
The .spec file you added seems mangled (Release is 1, but changelog is empty). Is this caused by COPR's support for rpmautospec?

Comment 8 Gwyn Ciesla 2022-01-31 17:37:05 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-spin_sleep

Comment 9 Fedora Update System 2022-01-31 23:36:56 UTC
FEDORA-2022-462184d722 has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-462184d722

Comment 10 Fedora Update System 2022-01-31 23:41:53 UTC
FEDORA-2022-462184d722 has been pushed to the Fedora 36 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 11 Fedora Update System 2022-01-31 23:51:25 UTC
FEDORA-2022-de13bfe414 has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2022-de13bfe414

Comment 12 Fedora Update System 2022-02-01 00:02:11 UTC
FEDORA-2022-c91e5249d4 has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2022-c91e5249d4

Comment 13 Fedora Update System 2022-02-01 01:06:41 UTC
FEDORA-2022-c91e5249d4 has been pushed to the Fedora 34 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2022-c91e5249d4 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-c91e5249d4

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 14 Fedora Update System 2022-02-01 02:00:21 UTC
FEDORA-2022-de13bfe414 has been pushed to the Fedora 35 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2022-de13bfe414 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-de13bfe414

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 15 Fedora Update System 2022-02-09 01:18:01 UTC
FEDORA-2022-de13bfe414 has been pushed to the Fedora 35 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 16 Fedora Update System 2022-02-09 02:08:01 UTC
FEDORA-2022-c91e5249d4 has been pushed to the Fedora 34 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.