RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1983705 - [RFE] Use LVM devices file instead of filter regex
Summary: [RFE] Use LVM devices file instead of filter regex
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 9
Classification: Red Hat
Component: libblockdev
Version: 9.0
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: beta
: ---
Assignee: Vojtech Trefny
QA Contact: guazhang@redhat.com
URL:
Whiteboard:
Depends On: 2021703
Blocks: 1967212 2011329
TreeView+ depends on / blocked
 
Reported: 2021-07-19 14:27 UTC by Vojtech Trefny
Modified: 2022-06-07 03:29 UTC (History)
4 users (show)

Fixed In Version: libblockdev-2.25-9.el9
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2022-05-17 13:24:34 UTC
Type: Bug
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2022:2503 0 None None None 2022-05-17 13:24:41 UTC

Description Vojtech Trefny 2021-07-19 14:27:19 UTC 
This bug was initially created as a copy of Bug #1967212

I am copying this bug because: 

We'll need to make changes in libblockdev to allow passing `--devices` option globally to all LVM commands and also add support for the new `lvmdevices` command for the devices file management.


Description of problem:
Blivet should be capable of adjusting LVM's devices file while configuring storage.

Expected results:
Blivet adjusts the LVM devices file, if desired, instead of passing filter regex on the command line. It would probably be useful to provide calls to explicitly manipulate the list of allowed devices and to write the file on demand.

Additional Information:
If the devices file is the default/preferred method of device filtering we should be writing the file out as part of OS installation.
Comment 3 Vojtech Trefny 2021-10-06 12:50:41 UTC 
upstream PR: https://github.com/storaged-project/libblockdev/pull/646
Comment 4 guazhang@redhat.com 2021-10-19 08:59:17 UTC 
Hi,
Is there any test script or test steps here ?
Comment 5 Vojtech Trefny 2021-11-01 08:42:43 UTC 
The libblockdev part of this feature is relatively simple and should be covered by the unit tests that are part of the upstream test suite. There are two parts:

a) support for configuring the "--devices" option for LVM commands:

`BlockDev.lvm_set_devices_filter(["/dev/sda"])` will make sure all commands are run with `--devices=/dev/sda`, you can get the filter with `BlockDev.lvm_get_devices_filter()`

b) support for managing the /etc/lvm/devices/system.devices config file:

BlockDev.lvm_devices_add("/dev/sda") and BlockDev.lvm_devices_delete("/dev/sda") to add/remove sda to /etc/lvm/devices/system.devices
Comment 6 guazhang@redhat.com 2021-12-08 09:39:17 UTC 
Hi

Please have a look the test steps if test pass the bug ?

>>> import gi
>>> gi.require_version('BlockDev', '2.0')
>>> from gi.repository import GLib
>>> from gi.repository import BlockDev
>>> BlockDev.switch_init_checks(False)
True
>>> BlockDev.init(BlockDev.plugin_specs_from_names(["lvm"]))
True
>>> BlockDev.lvm_set_devices_filter(["/dev/sdc"])
True
>>> BlockDev.lvm_get_devices_filter()
['/dev/sdc']
>>> BlockDev.lvm_devices_add("/dev/sdc")
True
# grep '/dev/sdc' /etc/lvm/devices/system.devices 
IDTYPE=sys_wwid IDNAME=naa.5000c500c48e4d07 DEVNAME=/dev/sdc PVID=.
>>> BlockDev.lvm_devices_delete("/dev/sdc")
True
# grep '/dev/sdc' /etc/lvm/devices/system.devices
Comment 7 Vojtech Trefny 2021-12-08 09:46:19 UTC 
Yes, this looks correct. The support on libblockdev part is very simple, lvm_devices_add/remove just calls "lvmdevices --adddev/--deldev" to add/remove the device from the config file. Thanks.
Comment 12 errata-xmlrpc 2022-05-17 13:24:34 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (new packages: libblockdev), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2022:2503
Note You need to log in before you can comment on or make changes to this bug.