Spec URL: https://dcavalca.fedorapeople.org/review/rust-uefi-run/rust-uefi-run.spec SRPM URL: https://dcavalca.fedorapeople.org/review/rust-uefi-run/rust-uefi-run-0.3.3-1.fc35.src.rpm Description: This helper application takes an EFI executable, builds a FAT filesystem around it, adds a startup script and runs qemu to run the executable. It does not require root permissions since it uses the fatfs crate to build the filesystem image directly without involving mkfs, mount, etc. Fedora Account System Username: dcavalca
- License ok - Latest version packaged - Builds in mock - No rpmlint errors - Checks pass - Conforms to Packaging Guidelines Package approved Please regenerate the .spec file with rust2rpm 20 before building this package for Fedora.
Note that this package builds a binary, so you need to make sure the License tag for the "-n %{crate}" subpackage reflects the licenses of all statically linked components. Right now this is not done at all.
Ha yeah I forgot about that. Weren't there a crate for that?
There is cargo-license, but it obviously does not take into account any of our downstream patches or modifications. I usually use this bash script inside the mock chroot after running a build with "--without check": for i in $(rpm -qa | grep "rust-.*-devel"); do rpm -q $i --qf "%{LICENSE}\n"; done | sort | uniq It gives you a list of all licenses of installed rust-foo-devel packages in the buildroot. From those you can construct the "effective" license of the subpackage that contains the binary. Alternatively, if you want a list of all Rust crates and their licenses in detail, you can install dnf-utils into the mock chroot and run something like: dnf repoquery --cacheonly "rust-*-devel" --installed --qf "# %{LICENSE}: %{source_name} %{version}"
Effective license calculation: (ASL 2.0 or MIT) and MIT and (MIT OR Apache-2.0) and (MIT or ASL 2.0) and (Unlicense or MIT) = ASL 2.0 and MIT and Unlicense
Spec URL: https://dcavalca.fedorapeople.org/review/rust-uefi-run/rust-uefi-run.spec SRPM URL: https://dcavalca.fedorapeople.org/review/rust-uefi-run/rust-uefi-run-0.5.0-1.fc37.src.rpm Changelog: - re-run rust2rpm - update to 0.5.0 - add effective license for binary subpackage
Package was generated with rust2rpm, simplifying the review. - package builds and installs without errors on rawhide - test suite is run and all unit tests pass - latest version of the crate is packaged - license matches upstream specification (MIT) and is acceptable for Fedora- - license for binary subpackage reflects statically linked dependencies - license file is included with %license in %files - package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - add @rust-sig with "commit" access as package co-maintainer - set bugzilla assignee overrides to @rust-sig (optional) - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate - track package in koschei for all built branches === Please also add the list of licenses that played a role in your license determination for the binary subpackage as a comment above the License tag.
Thanks! $ fedpkg request-repo rust-uefi-run 1983877 https://pagure.io/releng/fedora-scm-requests/issue/46104 $ fedpkg request-branch --all-releases --repo rust-uefi-run https://pagure.io/releng/fedora-scm-requests/issue/46105 https://pagure.io/releng/fedora-scm-requests/issue/46106
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-uefi-run
FEDORA-2022-7db1f694a5 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2022-7db1f694a5
FEDORA-2022-7db1f694a5 has been pushed to the Fedora 37 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2022-3c2683a334 has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-3c2683a334
FEDORA-2022-b50af6aa3c has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2022-b50af6aa3c
FEDORA-2022-3c2683a334 has been pushed to the Fedora 36 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-3c2683a334 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-3c2683a334 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2022-b50af6aa3c has been pushed to the Fedora 35 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-b50af6aa3c \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-b50af6aa3c See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2022-3c2683a334 has been pushed to the Fedora 36 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2022-b50af6aa3c has been pushed to the Fedora 35 stable repository. If problem still persists, please make note of it in this bug report.