Spec URL: https://dcavalca.fedorapeople.org/review/rust-sqlite3-src/rust-sqlite3-src.spec SRPM URL: https://dcavalca.fedorapeople.org/review/rust-sqlite3-src/rust-sqlite3-src-0.3.0-1.fc35.src.rpm Description: Package provides SQLite. Fedora Account System Username: dcavalca
This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=72225800
I doubt that this is actually needed. It's an optional dependency of sqlite3-sys, and if possible, you should patch that crate so that it always links against system sqlite. I also wonder why there's two crates providing FFI bindings for sqlite3 ... https://crates.io/crates/libsqlite3-sys and https://crates.io/crates/sqlite3-sys.
Yeah you're right, I don't think we should package this.
Turns out this is actually needed, but it can be set to use the system sqlite instead of the bundled one. Spec URL: https://dcavalca.fedorapeople.org/review/rust-sqlite3-src/rust-sqlite3-src.spec SRPM URL: https://dcavalca.fedorapeople.org/review/rust-sqlite3-src/rust-sqlite3-src-0.3.0-1.fc37.src.rpm Changelog: - re-run rust2rpm - remove bundled sqlite sources - link against system sqlite
I think you will also need to make two more (small) changes: - patch build.rs We only need a call to "pkg_config::find_library("sqlite3").unwrap()" to remain, given that the "bundled" feature is dropped. - remove now unused "cc" build-dependency
Spec URL: https://dcavalca.fedorapeople.org/review/rust-sqlite3-src/rust-sqlite3-src.spec SRPM URL: https://dcavalca.fedorapeople.org/review/rust-sqlite3-src/rust-sqlite3-src-0.4.0-1.fc38.src.rpm Changelog: - re-run rust2rpm - update to 0.4.0 - patch build.rs and remove unused cc dependency
I just noticed that the project doesn't contain a full copy of the Apache-2.0 license text but only includes the license header for Apache-2.0 in LICENSE.md. I'm pretty sure that this is not acceptable :( Other than that, the package looks good to me now, thanks. ====== Keep in mind that you can include a rust2rpm.conf file to automatically include the Build/Requires for sqlite-devel with: ``` [DEFAULT] buildrequires = pkgconfig(sqlite3) lib.requires = pkgconfig(sqlite3) ``` The runtime requires ("Requires: pkgconfig(sqlite3)") is currently missing from the package, using a rust2rpm.conf file in the future will prevent that from happening by mistake. === I also wonder how this crate actually works, given that the sources are empty. Does it only exist to link against libsqlite3 and serves no other purpose? The bindings seem to be in sqlite3-sys, instead ... weird setup. Most projects do this in the same crate, but if it works :shrug:
This is an automatic action taken by review-stats script. The ticket submitter failed to clear the NEEDINFO flag in a month. As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews we consider this ticket as DEADREVIEW and proceed to close it.