Fedora Account System
Red Hat Associate
Red Hat Customer
Spec URL: https://download.copr.fedorainfracloud.org/results/ohrdlick/cfr-0.151/fedora-34-x86_64/02334931-cfr/cfr.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/ohrdlick/cfr-0.151/fedora-34-x86_64/02334931-cfr/cfr-0.151-1.fc34.src.rpm Description: CFR will decompile modern Java features - including much of Java 9, 12 & 14, but is written entirely in Java 6, so will work anywhere! It'll even make a decent go of turning class files from other JVM languages back into java! Fedora Account System Username: ohrdlick
Looks very god. Runnng review now. Can you pleas eadd launcher and possibly man page?
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - missing launcher, ok to add later - cfr.noarch: E: description-line-too-long C It'll even make a decent go of turning class files from other JVM languages back into java! - ok to fix later - correctly missing main method from jar ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Expat License", "Unknown or generated". 736 files have unknown license. Detailed output of licensecheck in /home/jvanek/Desktop/1984078-cfr/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf %{buildroot} present but not required [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [-]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Java: [x]: Bundled jar/class files should be removed before build ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [-]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. Indeed, there are not ests inthe release tarball... [-]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: cfr-0.151-1.fc35.noarch.rpm cfr-javadoc-0.151-1.fc35.noarch.rpm cfr-0.151-1.fc35.src.rpm cfr.noarch: W: name-repeated-in-summary C CFR cfr.noarch: W: spelling-error %description -l en_US decompile -> recompile, compile cfr.noarch: E: description-line-too-long C It'll even make a decent go of turning class files from other JVM languages back into java! cfr.src: W: name-repeated-in-summary C CFR cfr.src: W: spelling-error %description -l en_US decompile -> recompile, compile cfr.src: E: description-line-too-long C It'll even make a decent go of turning class files from other JVM languages back into java! 3 packages and 0 specfiles checked; 2 errors, 4 warnings. Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output: Source checksums ---------------- https://github.com/leibnitz27/cfr/archive/refs/tags/0.151.tar.gz : CHECKSUM(SHA256) this package : 9be04948f9f1985421c2f1388d69dba4d65b024c5bfaeab400076ee3bac13611 CHECKSUM(SHA256) upstream package : 9be04948f9f1985421c2f1388d69dba4d65b024c5bfaeab400076ee3bac13611 Requires -------- cfr (rpmlib, GLIBC filtered): (java-headless or java-11-headless) java-headless javapackages-filesystem cfr-javadoc (rpmlib, GLIBC filtered): javapackages-filesystem Provides -------- cfr: cfr mvn(org.benf:cfr) mvn(org.benf:cfr:pom:) cfr-javadoc: cfr-javadoc Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10 Command line :/usr/bin/fedora-review -b 1984078 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Java, Generic Disabled plugins: Ocaml, SugarActivity, PHP, C/C++, Python, fonts, R, Perl, Haskell Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH Package is approved
Pls, request all live branches including epel7 and epel8
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/CFR
Just note - repo is lowercase: https://github.com/leibnitz27/cfr binary is lowercase jfr.jar but the name itself - as for readme.md is uppercase - Thus I think, that our package name of CFR and binary of cfr.jar remains ok
This package is now in Fedora repo hence closing this review.