Bug 198417 - Package vim lacks IPv6 support
Summary: Package vim lacks IPv6 support
Keywords:
Status: CLOSED UPSTREAM
Alias: None
Product: Fedora
Classification: Fedora
Component: vim
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Karsten Hopp
QA Contact: David Lawrence
URL:
Whiteboard:
Depends On:
Blocks: IPv6Blocker
TreeView+ depends on / blocked
 
Reported: 2006-07-11 10:31 UTC by Peter Vrabec
Modified: 2007-11-30 22:11 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2006-08-03 13:58:48 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
Patch to remove IPv4 specific code from integration and netbeans in vim (6.75 KB, patch)
2006-07-11 12:29 UTC, Jan Pazdziora (Red Hat)
no flags Details | Diff

Description Peter Vrabec 2006-07-11 10:31:01 UTC
This bug was reported automaticaly in connection with IPv6 project.
Our aim is to support IPv6 in all Fedora Core packages so FC6 and RHEL5 will be ready for IPv6.
			
This package seems to lack IPv6 support as is illustrated in attached log.
	
Here follows part of scanning log (grep -r F_INET *)/up to 30 lines: 

/vim70/src/netbeans.c:324:    if ((sd = (NBSOCK)socket(AF_INET, SOCK_STREAM, 0)) == (NBSOCK)-1)
/vim70/src/netbeans.c:333:    server.sin_family = AF_INET;
/vim70/src/netbeans.c:366:	    if ((sd = (NBSOCK)socket(AF_INET, SOCK_STREAM, 0)) == (NBSOCK)-1)
/vim70/src/integration.c:656:	if ((sd = socket(AF_INET, SOCK_STREAM, 0)) == -1) {
/vim70/src/integration.c:664:	server.sin_family = AF_INET;
/vim70/src/integration.c:686:			if ((sd = socket(AF_INET, SOCK_STREAM, 0)) == -1) {

Comment 1 Jan Pazdziora (Red Hat) 2006-07-11 12:29:33 UTC
Created attachment 132232 [details]
Patch to remove IPv4 specific code from integration and netbeans in vim

Please consider the attached patch.

I did not test the patch beyond compile. Also note that with the getaddrinfo
approach, there are multiple socket and connect calls caused by multiple values
returned, which adds to the 36 retries in the original code. Maybe the number
of retries might need to be reconsidered? Please take the patch only as a hint
of how the code might need to change.

Comment 2 Karsten Hopp 2006-08-03 13:58:48 UTC
workshop and netbeans stuff is currently disabled in FC-devel, all those F_INET
matches from the original report aren't in use in our vim package.
I'll notify upstream of the proposed patch, but it definitely needs some more work
p.e. as it doesn't patch autofoo stuff for --enable-ipv6/--disable-ipv6



Note You need to log in before you can comment on or make changes to this bug.