RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.

Description of problem:
virStoragePoolObjPtr does not release if virStoragePoolLookupByTargetPathEnsureACL(conn, def) failed

Version-Release number of selected component (if applicable):
libvirt-7.5.0-1.el9.x86_64

How reproducible:


Steps to Reproduce:
1.vim src/storage/storage_driver.c
...
1724 virStoragePoolPtr
1725 storagePoolLookupByTargetPath(virConnectPtr conn,
1726                               const char *path)
1727 {
1728     virStoragePoolObj *obj;
1729     ...
1736 
1737     if ((obj = virStoragePoolObjListSearch(driver->pools,
1738                                            storagePoolLookupByTargetPathCallback,
1739                                            cleanpath))) {
1740         def = virStoragePoolObjGetDef(obj);
1741         if (virStoragePoolLookupByTargetPathEnsureACL(conn, def) < 0)
1742             return NULL;
1743 
1744         pool = virGetStoragePool(conn, def->name, def->uuid, NULL, NULL);
1745         virStoragePoolObjEndAPI(&obj);
1746     }
...

2.
3.

Actual results:


Expected results:
virStoragePoolObjPtr should be released by 'virStoragePoolObjEndAPI(&obj)'.

Additional info:

https://listman.redhat.com/archives/libvir-list/2021-July/msg00532.html

Fixed upstream:

commit 447f69dec47e1b0bd15ecd7cd49a9fd3b050fb87
Author: Peter Krempa <pkrempa>
Date:   Wed Jul 21 11:22:25 2021 +0200

    storage_driver: Unlock object on ACL fail in storagePoolLookupByTargetPath
    
    'virStoragePoolObjListSearch' returns a locked and refed object, thus we
    must release it on ACL permission failure.
    
    Fixes: 7aa0e8c0cb8
    Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1984318
    Signed-off-by: Peter Krempa <pkrempa>
    Reviewed-by: Michal Privoznik <mprivozn>

v7.5.0-160-g447f69dec4

Verified with libvirt-7.6.0-1.el9.x86_64.

Test steps are the same as https://bugzilla.redhat.com/show_bug.cgi?id=1986459#c5.