Spec URL: https://didiksupriadi41.fedorapeople.org/apache-commons-text.spec SRPM URL: https://didiksupriadi41.fedorapeople.org/apache-commons-text-1.9-1.fc34.src.rpm Description: The Commons Text library provides additions to the standard JDK's text handling. Our goal is to provide a consistent set of tools for processing text generally from computing distances between Strings to being able to efficiently do String escaping of various types. Fedora Account System Username: didiksupriadi41
This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=74260404
I will take this review.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated Issues: ======= - I understand that mockito-inline is not available. In that case, one of two things should be done: (1) File a bug against the mockito package, asking that subprojects/inline be built, and a pom for mockito-inline added. (2) Drop the BR on mockito-core from this package, since it isn't used. - Note the rpmlint complaint below that %gpgverify is not the first command in %prep. Reverse the order of %autosetup and %gpgverify, as the tarball should not be unpacked if verification fails. ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "*No copyright* Apache License 2.0", "Unknown or generated", "Apache License 2.0". 7 files have unknown license. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Macros in Summary, %description expandable at SRPM build time. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 40960 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Java: [x]: Bundled jar/class files should be removed before build [x]: Packages have proper BuildRequires/Requires on javapackages-tools (jpackage-utils) Note: Maven packages do not need to (Build)Require jpackage-utils. It is pulled in by maven-local Maven: [x]: If package contains pom.xml files install it (including metadata) even when building with ant [x]: POM files have correct Maven mapping [x]: Maven packages should use new style packaging [x]: Old add_to_maven_depmap macro is not being used [x]: Packages DO NOT have Requires(post) and Requires(postun) on jpackage- utils for %update_maven_depmap macro [x]: Package DOES NOT use %update_maven_depmap in %post/%postun [x]: Packages use .mfiles file list instead of %{_datadir}/maven2/poms ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not the first command in %prep. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. Java: [x]: Package uses upstream build method (ant/maven/etc.) [x]: Packages are noarch unless they use JNI ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- ================================================ rpmlint session starts ================================================ rpmlint: 2.2.0 configuration: /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/licenses.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 3 apache-commons-text-javadoc.noarch: W: package-with-huge-docs: 99% apache-commons-text-javadoc.noarch: E: files-duplicated-waste 287630 apache-commons-text-javadoc.noarch: W: files-duplicate /usr/share/javadoc/apache-commons-text/jquery/jquery-3.5.1.js /usr/share/javadoc/apache-commons-text/jquery/external/jquery/jquery.js apache-commons-text-javadoc.noarch: W: file-not-utf8 /usr/share/javadoc/apache-commons-text/member-search-index.zip apache-commons-text-javadoc.noarch: W: file-not-utf8 /usr/share/javadoc/apache-commons-text/package-search-index.zip apache-commons-text-javadoc.noarch: W: file-not-utf8 /usr/share/javadoc/apache-commons-text/type-search-index.zip ================= 2 packages and 1 specfiles checked; 1 errors, 5 warnings, 1 badness; has taken 0.3 s ================= Rpmlint (installed packages) ---------------------------- ================================================ rpmlint session starts ================================================ rpmlint: 2.2.0 configuration: /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/licenses.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 2 apache-commons-text-javadoc.noarch: W: package-with-huge-docs: 99% apache-commons-text-javadoc.noarch: E: files-duplicated-waste 287630 apache-commons-text-javadoc.noarch: W: files-duplicate /usr/share/javadoc/apache-commons-text/jquery/jquery-3.5.1.js /usr/share/javadoc/apache-commons-text/jquery/external/jquery/jquery.js apache-commons-text-javadoc.noarch: W: file-not-utf8 /usr/share/javadoc/apache-commons-text/member-search-index.zip apache-commons-text-javadoc.noarch: W: file-not-utf8 /usr/share/javadoc/apache-commons-text/package-search-index.zip apache-commons-text-javadoc.noarch: W: file-not-utf8 /usr/share/javadoc/apache-commons-text/type-search-index.zip ================= 2 packages and 0 specfiles checked; 1 errors, 5 warnings, 1 badness; has taken 0.3 s ================= Source checksums ---------------- https://archive.apache.org/dist/commons/KEYS : CHECKSUM(SHA256) this package : fff17447c9f5301b7e9a540c74e173aa6c4e65fe30d430f765fb430c9173394f CHECKSUM(SHA256) upstream package : fff17447c9f5301b7e9a540c74e173aa6c4e65fe30d430f765fb430c9173394f https://archive.apache.org/dist/commons/text/source/commons-text-1.9-src.tar.gz.asc : CHECKSUM(SHA256) this package : 5ec45fafb588d85a4a1e0f9fd6dab728ccf6e35d3a457cbec2efa8527ac9dfb1 CHECKSUM(SHA256) upstream package : 5ec45fafb588d85a4a1e0f9fd6dab728ccf6e35d3a457cbec2efa8527ac9dfb1 https://archive.apache.org/dist/commons/text/source/commons-text-1.9-src.tar.gz : CHECKSUM(SHA256) this package : 62c67235630c63ad5b1b78263b64f8fd75d42371ff4e927c591dd3dec48a29cd CHECKSUM(SHA256) upstream package : 62c67235630c63ad5b1b78263b64f8fd75d42371ff4e927c591dd3dec48a29cd Requires -------- apache-commons-text (rpmlib, GLIBC filtered): (java-headless or java-11-headless) javapackages-filesystem mvn(org.apache.commons:commons-lang3) Provides -------- apache-commons-text: apache-commons-text mvn(org.apache.commons:commons-text) mvn(org.apache.commons:commons-text:pom:) osgi(org.apache.commons.commons-text) Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10 Command line :/usr/bin/fedora-review -b 1984451 -m fedora-rawhide-x86_64 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Java, Shell-api Disabled plugins: Python, fonts, Perl, Ruby, R, Haskell, SugarActivity, Ocaml, PHP, C/C++ Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
Spec URL: https://didiksupriadi41.fedorapeople.org/apache-commons-text.spec SRPM URL: https://didiksupriadi41.fedorapeople.org/apache-commons-text-1.9-2.fc35.src.rpm Changelog - Add BR on mockito-inline - Patch the test files to disable url lookup - Use maven-local-openjdk11 to be able to compile test files - Reverse the order of %%autosetup and %%gpgverify I've solve both issues but also add a patch to disable some tests.
Looks good. This package is APPROVED.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/apache-commons-text