Bug 1985475 - VM migration assessment is not updated for previously selected VMs on the "Select VMs" screen of the migration plan wizard
Summary: VM migration assessment is not updated for previously selected VMs on the "Se...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Migration Toolkit for Virtualization
Classification: Red Hat
Component: User Experience
Version: 2.1.0
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: ---
: 2.1.0
Assignee: Mike Turley
QA Contact: Igor Braginsky
Avital Pinnick
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-07-23 16:33 UTC by Mike Turley
Modified: 2023-09-15 01:12 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-08-26 07:09:27 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github konveyor forklift-ui pull 719 0 None open Bug 1985475: SelectVMsForm: Ensure the latest versions of already-selected VMs are used when re-rendering from new query... 2021-07-23 17:18:40 UTC
Github konveyor forklift-ui pull 720 0 None open [Backport] Bug 1985475: SelectVMsForm: Ensure the latest versions of already-selected VMs are used when re-rendering fro... 2021-07-23 17:29:14 UTC
Github konveyor forklift-ui pull 722 0 None open [Backport] Bug 1985475: SelectVMsForm: Ensure the latest versions of already-selected VMs are used when re-rendering fro... 2021-07-23 18:29:46 UTC
Red Hat Product Errata RHEA-2021:3278 0 None None None 2021-08-26 07:09:32 UTC

Description Mike Turley 2021-07-23 16:33:03 UTC
This was a bug pre-2.0 that we fixed, and newer changes to the query behavior of the wizard seem to have broken it. While the user is on the Select VMs step of the wizard, it should be polling VMs for changes and re-rendering any new data (particularly noticeable when editing something on a VM that triggers re-validation, which should cause a spinner to appear in the Migration assessment column).

Navigating back to the Filter step of the wizard and forward again does render the new data, but it should update automatically with no user action required.

Comment 1 Mike Turley 2021-07-23 17:02:39 UTC
In debugging this, I found that it is only happening for the VMs that were already selected upon reaching that step of the wizard (e.g. when editing an existing plan, or moving back and forth between the steps). I've found the root cause, fix incoming.

Comment 2 Mike Turley 2021-07-23 18:16:11 UTC
In order to prevent conflicts in backporting the fix for this issue, we are also backporting a related refactor: https://github.com/konveyor/forklift-ui/pull/721

So in order to verify this BZ, we should test the Filter and Select VMs steps of the wizard in general and make sure they both still work in entirety.

Comment 3 Jeff Ortel 2021-07-27 00:07:21 UTC
 2.1.0-34 / IIB:93583

Comment 4 Mike Turley 2021-07-27 15:16:10 UTC
Jeff, I think you may have intended to update a different BZ. The PRs for this one have not been merged yet:

https://github.com/konveyor/forklift-ui/pull/719
https://github.com/konveyor/forklift-ui/pull/722

Comment 5 Mike Turley 2021-07-27 15:18:10 UTC
Just merged.

Comment 6 Fabien Dupont 2021-08-04 13:04:24 UTC
Please verify with build 2.1.0-40 / IIB 96091.

Comment 7 Igor Braginsky 2021-08-11 14:45:12 UTC
Validated this on MTV 2.1.0-44, iib:96817

Comment 10 errata-xmlrpc 2021-08-26 07:09:27 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Migration Toolkit for Virtualization 2.1.0), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2021:3278

Comment 11 Red Hat Bugzilla 2023-09-15 01:12:00 UTC
The needinfo request[s] on this closed bug have been removed as they have been unresolved for 500 days


Note You need to log in before you can comment on or make changes to this bug.