Bug 1985879 - Verification fails with next hop address 0.0.0.0
Summary: Verification fails with next hop address 0.0.0.0
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 8
Classification: Red Hat
Component: nmstate
Version: 8.4
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: beta
: ---
Assignee: Fernando F. Mancera
QA Contact: Mingyu Shi
URL:
Whiteboard:
Depends On:
Blocks: 1985876 1986285
TreeView+ depends on / blocked
 
Reported: 2021-07-26 07:14 UTC by Ales Musil
Modified: 2021-11-09 20:22 UTC (History)
7 users (show)

Fixed In Version: nmstate-1.1.0-3.el8
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
: 1986285 (view as bug list)
Environment:
Last Closed: 2021-11-09 17:44:09 UTC
Type: Bug
Target Upstream Version:


Attachments (Terms of Use)
Reproducer (547 bytes, application/x-shellscript)
2021-07-26 07:14 UTC, Ales Musil
no flags Details


Links
System ID Private Priority Status Summary Last Updated
Github nmstate nmstate pull 1683 0 None open nispor: fix show of empty next_hop_address and destination 2021-07-26 14:21:33 UTC
Red Hat Product Errata RHBA-2021:4157 0 None None None 2021-11-09 17:44:12 UTC

Description Ales Musil 2021-07-26 07:14:35 UTC
Created attachment 1805767 [details]
Reproducer

Description of problem:
nmstate fails verification phase for routes that have next-hop-address 0.0.0.0

Version-Release number of selected component (if applicable):
nmstate-1.0.2-13

How reproducible:
100%

Steps to Reproduce:
1. Run the reproducer


Actual results:
libnmstate.error.NmstateVerificationError: 
desired
=======
---
routes:
  config:
  - destination: 0.0.0.0/0
    next-hop-address: 0.0.0.0
    next-hop-interface: dummy
    table-id: 254

current
=======
---
routes:
  config:
  - destination: ''
    metric: 550
    next-hop-address: ''
    next-hop-interface: dummy
    table-id: 254

difference
==========
--- desired
+++ current
@@ -1,7 +1,8 @@
 ---
 routes:
   config:
-  - destination: 0.0.0.0/0
-    next-hop-address: 0.0.0.0
+  - destination: ''
+    metric: 550
+    next-hop-address: ''
     next-hop-interface: dummy
     table-id: 254


Expected results:
Should pass

Comment 4 Fernando F. Mancera 2021-07-26 14:21:34 UTC
Upstream patch: https://github.com/nmstate/nmstate/pull/1683

Comment 6 Gris Ge 2021-07-27 04:51:42 UTC
Tested with upstream patch. Looks good.

Comment 13 Mingyu Shi 2021-08-02 10:26:13 UTC
Verified with versions:
nmstate-1.0.2-14.el8_4.noarch
nispor-1.0.1-4.el8.x86_64
NetworkManager-1.30.0-10.el8_4.x86_64

Desired state applied: 
---
routes:
  config:
  - destination: 0.0.0.0/0
    next-hop-address: 0.0.0.0
    next-hop-interface: dummy
    table-id: 0
interfaces:
- name: dummy
  type: dummy
  state: up
  ipv4:
    enabled: true
    address:
    - ip: 192.0.2.1
      prefix-length: 24
  ipv6:
    enabled: false
[06:19:34@ci-vm-10-0-137-181 ~]0# ip route
default via 10.0.139.254 dev eth0 proto dhcp metric 100 
default dev dummy proto static scope link metric 550 
10.0.136.0/22 dev eth0 proto kernel scope link src 10.0.137.181 metric 100 
169.254.169.254 via 10.0.136.13 dev eth0 proto dhcp metric 100 
192.0.2.0/24 dev dummy proto kernel scope link src 192.0.2.1 metric 550

Comment 14 Mingyu Shi 2021-08-02 10:30:22 UTC
#comment13 is the verification for 8.4.0.z, please ignore it.


Verified with versions:
nmstate-1.1.0-3.el8.noarch
nispor-1.1.1-1.el8.x86_64
NetworkManager-1.32.4-1.el8.x86_64

Desired state applied: 
---
routes:
  config:
  - destination: 0.0.0.0/0
    next-hop-address: 0.0.0.0
    next-hop-interface: dummy
    table-id: 0
interfaces:
- name: dummy
  type: dummy
  state: up
  ipv4:
    enabled: true
    address:
    - ip: 192.0.2.1
      prefix-length: 24
  ipv6:
    enabled: false
[18:27:06@ibm-x3650m4-01-vm-12 ~]0# ip route 
default via 10.16.215.254 dev ens3 proto dhcp metric 100 
default dev dummy proto static scope link metric 550 
10.16.214.0/23 dev ens3 proto kernel scope link src 10.16.214.14 metric 100 
192.0.2.0/24 dev dummy proto kernel scope link src 192.0.2.1 metric 550

Comment 16 errata-xmlrpc 2021-11-09 17:44:09 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (nmstate bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2021:4157


Note You need to log in before you can comment on or make changes to this bug.