Bug 198637 - Make login processes initialise session keyring
Summary: Make login processes initialise session keyring
Alias: None
Product: Fedora
Classification: Fedora
Component: vsftpd   
(Show other bugs)
Version: 6
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Radek Vokal
QA Contact: Mike McLean
Depends On:
Blocks: 198623
TreeView+ depends on / blocked
Reported: 2006-07-12 13:29 UTC by David Howells
Modified: 2007-11-30 22:11 UTC (History)
0 users

Fixed In Version: 2.0.5-2
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2006-07-13 15:16:27 UTC
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---

Attachments (Terms of Use)
Add keyinit instruction to PAM script (2.78 KB, patch)
2006-07-13 14:16 UTC, David Howells
no flags Details | Diff

Description David Howells 2006-07-12 13:29:24 UTC
+++ This bug was initially created as a clone of Bug #198623 +++

This package contains the "ftp" service for which the PAM script needs to 
be modified.

The PAM scripts for the login programs need to be altered to forcibly create a 
new session keyring when a login event occurs.

These simply require the following line adding to their PAM scripts:

	session	    optional    pam_keyinit.so    force revoke

This forces them to create a new session keyring during login, replacing the
one inherited from their parent, and causes the session keyring so created to
be revoked when the login process exits.

Ideally, this should be "required" not "optional", but it still has to work if 
the pam_keyinit.so library is absent.

The authlogin program needs modifying to add:

	session	    optional    pam_keyinit.so    revoke

To the default session (system-auth).  This just creates a new session keyring 
if one doesn't yet exist for this process.

The "su" program needs to split its "su - [user]" mode PAM script from its "su 
[user]" PAM script, so that the former can forcibly create a keyring whilst 
the latter doesn't.

Comment 1 David Howells 2006-07-13 14:16:09 UTC
Created attachment 132375 [details]
Add keyinit instruction to PAM script

This patch modifies the contents of the devel/ directory to add keyinit
instructions to the vsftpd PAM script.

Comment 2 Radek Vokal 2006-07-13 15:16:27 UTC
I don't know why you hardcoded the path in the pam module? Also I've moved the
session line to the very top of the pam file.

Comment 3 David Howells 2006-07-13 15:21:10 UTC
> I don't know why you hardcoded the path in the pam module?

I followed the separate styles of each of the three PAM scripts I modified.  
Only one is actually installed, and that one doesn't have paths hardcoded.

Note You need to log in before you can comment on or make changes to this bug.