Bug 1986685 - panic when opm alpha diff
Summary: panic when opm alpha diff
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: OLM
Version: 4.9
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: ---
: 4.9.0
Assignee: tflannag
QA Contact: kuiwang
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-07-28 05:54 UTC by kuiwang
Modified: 2021-10-18 17:42 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-10-18 17:42:48 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github openshift operator-framework-olm pull 139 0 None open Bug 1986685: Fix panic in opm alpha diff when accessing the --skip-tls flag 2021-07-28 14:28:52 UTC
Red Hat Product Errata RHSA-2021:3759 0 None None None 2021-10-18 17:42:58 UTC

Description kuiwang 2021-07-28 05:54:08 UTC
Description of problem:
When I execute "opm alpha diff", it panic.

Version-Release number of selected component (if applicable):
[root@preserve-olm-env OSDK-1869]# ../../operator-framework-olm/bin/opm version
Version: version.Version{OpmVersion:"088bd07ea", GitCommit:"088bd07eacb2e2999e6946d5892d33f3b3a9e848", BuildDate:"2021-07-28T03:06:34Z", GoOs:"linux", GoArch:"amd64"}

How reproducible:
always

Steps to Reproduce:
[root@preserve-olm-env OSDK-1869]# rm -fr bundle.Dockerfile mta-operator/0.0.4/metadata/annotations.yaml
[root@preserve-olm-env OSDK-1869]# ../../operator-framework-olm/bin/opm alpha bundle build -d mta-operator/0.0.4/manifests -t quay.io/olmqe/mta-operator:v0.0.4-1869 -p mta-operator -c alpha -e alpha
INFO[0000] Building annotations.yaml                    
INFO[0000] Writing annotations.yaml in /data/kuiwang/cases/OSDK-1869/mta-operator/0.0.4/metadata 
INFO[0000] Building Dockerfile                          
INFO[0000] Writing bundle.Dockerfile in /data/kuiwang/cases/OSDK-1869 
INFO[0000] Building bundle image                        
Emulate Docker CLI using podman. Create /etc/containers/nodocker to quiet msg.
STEP 1: FROM scratch
STEP 2: LABEL operators.operatorframework.io.bundle.mediatype.v1=registry+v1
--> Using cache 15e491cc47a9fb627ddd7c5effb7b341ff133b96f54bed76c83a7cb13e4dc2cc
--> 15e491cc47a
STEP 3: LABEL operators.operatorframework.io.bundle.manifests.v1=manifests/
--> Using cache 918d57cf956eca34f6ae47c44994e428b91c6c49bb7170f86b903907df2a043d
--> 918d57cf956
STEP 4: LABEL operators.operatorframework.io.bundle.metadata.v1=metadata/
--> Using cache 2249aa186c06190044d49671ccfb7a809f2b9f55af6422fb30563b389e908f40
--> 2249aa186c0
STEP 5: LABEL operators.operatorframework.io.bundle.package.v1=mta-operator
--> Using cache ee133dc338547e23aed59e6f9cdee9a83b75668b276ac3f5796238cc56e4092e
--> ee133dc3385
STEP 6: LABEL operators.operatorframework.io.bundle.channels.v1=alpha
--> Using cache a249c67bc7a1b32f36a2946b986e6aac86a96c281f64e69a2c22ecb26472264d
--> a249c67bc7a
STEP 7: LABEL operators.operatorframework.io.bundle.channel.default.v1=alpha
--> Using cache 6c96f100ff64df79eed5355bea338f3e307ce1a93f893fa554e74b1b6f8c5af0
--> 6c96f100ff6
STEP 8: COPY mta-operator/0.0.4/manifests /manifests/
--> Using cache d1ca17a4ebc6f1b0b791024d6f2b38d797f4d50f18095fd12d5fcefe749c910d
--> d1ca17a4ebc
STEP 9: COPY mta-operator/0.0.4/metadata /metadata/
STEP 10: COMMIT quay.io/olmqe/mta-operator:v0.0.4-1869
--> 6e085f275d4
6e085f275d482fe8db10046e4a3d3956a8ec856b125207a40698d29cd96e5995
[root@preserve-olm-env OSDK-1869]# rm -fr bundle.Dockerfile mta-operator/0.0.4/metadata/annotations.yaml
[root@preserve-olm-env OSDK-1869]# podman push quay.io/olmqe/mta-operator:v0.0.4-1869
Getting image source signatures
Copying blob e4ad30b9b851 done  
Copying blob 494fdb3754ec skipped: already exists  
Copying config 6e085f275d done  
Writing manifest to image destination
Copying config 6e085f275d [======================================] 2.1KiB / 2.1KiB
Writing manifest to image destination
Writing manifest to image destination
Storing signatures
[root@preserve-olm-env OSDK-1869]# 
[root@preserve-olm-env OSDK-1869]# ../../operator-framework-olm/bin/opm alpha diff quay.io/olmqe/mta-operator:v0.0.4-1869
panic: flag accessed but not defined: skip-tls

goroutine 1 [running]:
github.com/operator-framework/operator-registry/cmd/opm/alpha/diff.(*diff).addFunc(0xc0005a4660, 0xc0000f7680, 0xc0004dcc90, 0x1, 0x1, 0x0, 0x0)
	/data/kuiwang/operator-framework-olm/vendor/github.com/operator-framework/operator-registry/cmd/opm/alpha/diff/cmd.go:98 +0x73f
github.com/spf13/cobra.(*Command).execute(0xc0000f7680, 0xc0004dcc70, 0x1, 0x1, 0xc0000f7680, 0xc0004dcc70)
	/data/kuiwang/operator-framework-olm/vendor/github.com/spf13/cobra/command.go:852 +0x472
github.com/spf13/cobra.(*Command).ExecuteC(0xc0003fe500, 0xc000000180, 0x200000003, 0xc000000180)
	/data/kuiwang/operator-framework-olm/vendor/github.com/spf13/cobra/command.go:960 +0x375
github.com/spf13/cobra.(*Command).Execute(...)
	/data/kuiwang/operator-framework-olm/vendor/github.com/spf13/cobra/command.go:897
main.main()
	/data/kuiwang/operator-framework-olm/vendor/github.com/operator-framework/operator-registry/cmd/opm/main.go:14 +0x2b

Actual results:
opm panic

Expected results:
can get the DC 

Additional info:

Comment 3 kuiwang 2021-07-29 06:13:35 UTC
verify it on 4.9. LGTM

No such panic

[root@preserve-olm-env OSDK-1869]#  ../../operator-framework-olm/bin/opm version
Version: version.Version{OpmVersion:"5c57b2841", GitCommit:"5c57b2841c83e9d7894269a15a5e21efa151384c", BuildDate:"2021-07-29T06:06:00Z", GoOs:"linux", GoArch:"amd64"}
[root@preserve-olm-env OSDK-1869]#

Comment 6 errata-xmlrpc 2021-10-18 17:42:48 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: OpenShift Container Platform 4.9.0 bug fix and security update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2021:3759


Note You need to log in before you can comment on or make changes to this bug.