Bug 1986819 - fix string typos for hot-plug disks
Summary: fix string typos for hot-plug disks
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Console Kubevirt Plugin
Version: 4.8
Hardware: Unspecified
OS: Unspecified
unspecified
low
Target Milestone: ---
: 4.10.0
Assignee: Aviv Turgeman
QA Contact: Leon Kladnitsky
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-07-28 11:34 UTC by Aviv Turgeman
Modified: 2022-03-10 16:05 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: No Doc Update
Doc Text:
Clone Of:
Environment:
Last Closed: 2022-03-10 16:04:47 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github openshift console pull 9674 0 None Merged Bug 1986819: fix string typos for hot-plug disks 2022-01-10 12:37:52 UTC
Github openshift console pull 9878 0 None open Bug 1986819: fix string typos for hot-plug disks 2022-01-20 20:17:50 UTC
Red Hat Product Errata RHSA-2022:0056 0 None None None 2022-03-10 16:05:06 UTC

Description Aviv Turgeman 2021-07-28 11:34:57 UTC
following list need to be changed

"Detach {{diskName}} hotplug disk", => 'Detach {{diskName}} hot-plugged disk'
"Add Disk (Hot-plugged)", => {{type}} is always Disk => 'Add Disk (hot plugged)'
"Hotplug is enabled only for \"Disk\" type", => 'Hot plug is enabled only for "Disk" type'
"Hotplug is enabled only for \"scsi\" interface" => 'Hot plug is enabled only for "scsi" interface'
"Automatically detach this disk upon VM restart.", => 'Automatically detach this disk when this VM restarts'
"Enable automatic detachment is available only for hot-plugged disks.", => 'Enable automatic detachment is available only for hot-plugged disks'
"Hot-plug disk", => 'Hot-plugged disk'
"The disk will be immediately added (hot-plugged) to the running VM.", => 'The disk will be immediately added (hot plugged) to the running VM.'
"The following hotplugged disks will be removed from virtual machine" => "The following hot-plugged disks will be removed from the virtual machine"

Comment 2 Leon Kladnitsky 2021-08-24 11:13:13 UTC
 The changed strings are as required except for a single typo:

"Add Disk (Hot-plugged)", => {{type}} is always Disk => 'Add Disk (hot plugged)'     - in UI: 'Add Disk (Hot plugged)' (note Hot is with capital "H")

Comment 3 Leon Kladnitsky 2021-08-25 06:40:46 UTC
Aviv, could you check it? Can you fix this? It's the only small thing left.

Comment 4 Aviv Turgeman 2021-08-25 07:29:36 UTC
Hi Leon, thanks for noticing
I've submitted a PR for it, it's already attached in the links, and this BZ moved back to POST.

Comment 6 Leon Kladnitsky 2022-01-24 21:21:30 UTC
Verified on upstream master

Comment 10 errata-xmlrpc 2022-03-10 16:04:47 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: OpenShift Container Platform 4.10.3 security update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2022:0056


Note You need to log in before you can comment on or make changes to this bug.