Bug 1986930
| Summary: | internal tool vdo2lvm name should change to something less appealing to the user | ||
|---|---|---|---|
| Product: | Red Hat Enterprise Linux 8 | Reporter: | Corey Marthaler <cmarthal> |
| Component: | lvm2 | Assignee: | Marian Csontos <mcsontos> |
| lvm2 sub component: | VDO | QA Contact: | cluster-qe <cluster-qe> |
| Status: | CLOSED ERRATA | Docs Contact: | |
| Severity: | low | ||
| Priority: | urgent | CC: | agk, awalsh, bjohnsto, heinzm, jbrassow, prajnoha, zkabelac |
| Version: | 8.5 | Keywords: | Triaged |
| Target Milestone: | beta | Flags: | pm-rhel:
mirror+
|
| Target Release: | --- | ||
| Hardware: | x86_64 | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | lvm2-2.03.12-8.el8 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2021-11-09 19:45:54 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
Tool vdo2lvm might be better located in /usr/libexec outside of reach of regular $PATH access - as it should be (ATM) used only by vdo manager through 'vdo convert' call. (In reply to Zdenek Kabelac from comment #1) > Tool vdo2lvm might be better located in /usr/libexec outside of reach of > regular $PATH access - as it should be (ATM) used only by vdo manager > through 'vdo convert' call. We could do this on our side. Corey would this work for you? A new build of vdo (NVR vdo-6.2.5.74-14.el8) is available that renames vdo2lvm to vdoprepareforlvm and moves it to /usr/libexec. The functionality of 'vdo convert' is unchanged, so the vdoimport utility still continues to work as it did previously. After discussion in lvm team it was decided to rename vdoimport as well. The old name does not imply a volume is imported into lvm. So this is now considered fixed by commit bbbd4fed69d88e67678994cb611d082d27bb774b - Rename vdoimport to lvm_import_vdo. https://sourceware.org/git/?p=lvm2.git;a=commit;h=bbbd4fed69d88e67678994cb611d082d27bb774b Marking Verified:Tested in the latest rpms.
kernel-4.18.0-339.el8 BUILT: Fri Aug 27 09:59:28 CDT 2021
lvm2-2.03.12-8.el8 BUILT: Thu Aug 26 15:49:15 CDT 2021
vdo-6.2.5.74-14.el8 BUILT: Fri Aug 20 17:56:40 CDT 2021
kmod-kvdo-6.2.5.72-80.el8 BUILT: Fri Aug 27 10:26:23 CDT 2021
[root@hayes-01 ~]# which vdo2lvm
/usr/bin/which: no vdo2lvm in (/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/root/bin)
[root@hayes-01 ~]# ls -l /usr/libexec/vdoprepareforlvm
-rwxr-xr-x. 1 root root 549448 Aug 20 17:56 /usr/libexec/vdoprepareforlvm
[root@hayes-01 ~]# /usr/libexec/vdoprepareforlvm -h
vdoprepareforlvm - Converts a VDO device for use with LVM
SYNOPSIS
vdoprepareforlvm <filename>
DESCRIPTION
vdoprepareforlvm converts the VDO block device named by <filename> for
use with LVM. The VDO device to be converted must not be running, and
should not already be an LVM VDO.
OPTIONS
--help
Print this help message and exit.
--version
Show the version of vdoprepareforlvm.
Marking verified with latest compose. kernel-4.18.0-340.el8 BUILT: Thu Sep 2 16:16:14 CDT 2021 lvm2-2.03.12-8.el8 BUILT: Thu Aug 26 15:49:15 CDT 2021 lvm2-libs-2.03.12-8.el8 BUILT: Thu Aug 26 15:49:15 CDT 2021 [root@hayes-03 ~]# ls -l /usr/libexec/vdoprepareforlvm -rwxr-xr-x. 1 root root 549448 Aug 20 17:56 /usr/libexec/vdoprepareforlvm [root@hayes-03 ~]# which vdo2lvm /usr/bin/which: no vdo2lvm in (/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/root/bin) Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory (lvm2 bug fix and enhancement update), and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2021:4431 |
Description of problem: If a user properly reads and follows the documentation, they will not have an issue with the tool names, however if they do not (like I didn't), and instead just type vdo[TAB] to see what options they have for converting their vdo volumes to be managed by LVM, the most appealing option is "vdo2lvm" instead of the correct tool "vdoimport". In fact, i'd argue that vdoimport should be named vdo2lvm. [root@hayes-03 ~]# vdo vdo vdo2lvm vdo-by-dev vdodmeventd vdodumpconfig vdoforcerebuild vdoformat vdoimport vdosetuuid vdostats [root@hayes-03 ~]# vdo2lvm -h vdo2lvm - Converts a VDO device for use with LVM SYNOPSIS vdo2lvm <filename> DESCRIPTION vdo2lvm converts the VDO block device named by <filename> for use with LVM. The VDO device to be converted must not be running, and should not already be an LVM VDO. OPTIONS --help Print this help message and exit. --version Show the version of vdo2lvm. [root@hayes-03 ~]# vdoimport -h vdoimport: Utility to convert VDO volume to VDO LV. vdoimport [options] <vdo_device_path> Options: -f | --force Bypass sanity checks -h | --help Show this help message -n | --name Specifies VG/LV name for converted VDO volume -v | --verbose Be verbose -y | --yes Answer "yes" at any prompts --dry-run Print commands without running them Version-Release number of selected component (if applicable): lvm2-2.03.12-5.el8 BUILT: Tue Jul 13 11:50:03 CDT 2021 lvm2-libs-2.03.12-5.el8 BUILT: Tue Jul 13 11:50:03 CDT 2021 vdo-6.2.5.65-14.el8 BUILT: Thu Jul 22 12:56:43 CDT 2021 kmod-kvdo-6.2.5.65-79.el8 BUILT: Thu Jul 22 12:59:43 CDT 2021