Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1986936

Summary:	Grafana shows wrong label on y-axis of network graphs
Product:	OpenShift Container Platform	Reporter:	Dhruv Gautam <dgautam>
Component:	Monitoring	Assignee:	Arunprasad Rajkumar <arajkuma>
Status:	CLOSED ERRATA	QA Contact:	hongyan li <hongyli>
Severity:	low	Docs Contact:
Priority:	medium
Version:	4.7	CC:	amuller, anpicker, aos-bugs, erooth, hongyli
Target Milestone:	---
Target Release:	4.9.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2021-10-18 17:42:53 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Dhruv Gautam 2021-07-28 14:52:37 UTC

Description of problem:
Grafana shows wrong label on y-axis of network graphs.
For example: For "Rate of received packet" graph, y-axis shows B/s (Bytes per second) but it should be P/s (Packets per second)

Version-Release number of selected component (if applicable):
4.7

How reproducible:
100%

Steps to Reproduce:
1. Open Grafana dashboard
2. Check network graph of any pod (Rate of received packets)
3. 

Actual results:
Rate of received packets shows B/s on y-axis

Expected results:
Rate of received packets should show P/s (packets per second) on y-axis

Additional info:
https://github.com/openshift/cluster-monitoring-operator/pull/1269

Comment 3 hongyan li 2021-07-29 06:45:56 UTC

The unit should be KPps or MPps, not kpps

Comment 6 hongyan li 2021-07-30 11:49:40 UTC

At least the unit should be Kpps not kpps to align with other graphs.

Comment 7 Arunprasad Rajkumar 2021-07-30 15:41:36 UTC

@hongyan li 

According to the grafana unit definitions(based on SI units)[1], pps represents packets per second and its notation would be something like pps(p/s), kpps(kp/s), Mpps(Mp/s), Gpps(Gp/s)[2]. 

Other graph panels seem to be related to data in bytes which shall follow Bps, KBps, MBps,..etc., this particular changes are meant to represent packets.

[1] https://github.com/grafana/grafana/blob/0757ba1c64d60160a435aeba1623f166683b503e/packages/grafana-data/src/valueFormats/categories.ts#L165
[2] https://github.com/grafana/grafana/blob/main/packages/grafana-data/src/valueFormats/symbolFormatters.ts#L64-L71

Comment 8 hongyan li 2021-07-31 08:16:50 UTC

I know what pps mean packet of per second, just other graph display capital K, than is KBps, network graph display kpps, the k letter is little one.

Comment 9 hongyan li 2021-08-09 09:11:25 UTC

according to pr 
https://github.com/grafana/grafana/pull/2955/files
document
https://en.wikipedia.org/wiki/Metric_prefix

the unit kpps makes sense, close the bug as verified.

Comment 16 errata-xmlrpc 2021-10-18 17:42:53 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: OpenShift Container Platform 4.9.0 bug fix and security update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2021:3759