Bug 1987284 - Review Request: nodejs-bash-language-server - A language server for Bash
Summary: Review Request: nodejs-bash-language-server - A language server for Bash
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Sahana Prasad
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-07-29 12:20 UTC by Andreas Schneider
Modified: 2021-08-25 07:31 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2021-08-25 07:31:27 UTC
Type: ---
Embargoed:
sahana: fedora-review+

Attachments (Terms of Use)

Description Andreas Schneider 2021-07-29 12:20:35 UTC 
Spec URL: https://xor.cryptomilk.org/rpm/nodejs-bash-language-server/nodejs-bash-language-server.spec
SRPM URL: https://xor.cryptomilk.org/rpm/nodejs-bash-language-server/nodejs-bash-language-server-1.17.0-0.fc34.src.rpm
Description: Bash language server implementation based on Tree Sitter and its grammar for Bash with explainshell integration.
Fedora Account System Username: asn
Comment 1 Andreas Schneider 2021-08-04 10:16:38 UTC 
Spec URL: https://xor.cryptomilk.org/rpm/nodejs-bash-language-server/nodejs-bash-language-server.spec
SRPM URL: https://xor.cryptomilk.org/rpm/nodejs-bash-language-server/nodejs-bash-language-server-1.17.0-1.fc34.src.rpm
Comment 2 Andreas Schneider 2021-08-04 10:33:19 UTC 
Spec URL: https://xor.cryptomilk.org/rpm/nodejs-bash-language-server/nodejs-bash-language-server.spec
SRPM URL: https://xor.cryptomilk.org/rpm/nodejs-bash-language-server/nodejs-bash-language-server-1.17.0-2.fc34.src.rpm
Comment 3 Andreas Schneider 2021-08-04 11:17:39 UTC 
Spec URL: https://xor.cryptomilk.org/rpm/nodejs-bash-language-server/nodejs-bash-language-server.spec
SRPM URL: https://xor.cryptomilk.org/rpm/nodejs-bash-language-server/nodejs-bash-language-server-1.17.0-3.fc34.src.rpm
Comment 4 Andreas Schneider 2021-08-05 12:53:03 UTC 
Spec URL: https://xor.cryptomilk.org/rpm/nodejs-bash-language-server/nodejs-bash-language-server.spec
SRPM URL: https://xor.cryptomilk.org/rpm/nodejs-bash-language-server/nodejs-bash-language-server-1.17.0-4.fc34.src.rpm
Comment 5 Andreas Schneider 2021-08-05 13:22:40 UTC 
Spec URL: https://xor.cryptomilk.org/rpm/nodejs-bash-language-server/nodejs-bash-language-server.spec
SRPM URL: https://xor.cryptomilk.org/rpm/nodejs-bash-language-server/nodejs-bash-language-server-1.17.0-5.fc34.src.rpm
Comment 6 Sahana Prasad 2021-08-06 08:25:21 UTC 
Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
=======
- If (and only if) the source package includes the text of the license(s)
  in its own file, then that file, containing the text of the license(s)
  for the package is included in %license.
  Note: License file COPYING is not marked as %license
  See: https://docs.fedoraproject.org/en-US/packaging-
  guidelines/LicensingGuidelines/#_license_text


===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "MIT License", "*No copyright*
     [generated file]", "BSD (3 clause)", "ISC License", "MIT License
     [generated file]", "*No copyright* MIT License", "MIT License Apache
     License 2.0", "*No copyright* Apache License 2.0", "Apache License
     2.0", "ISC License BSD (3 clause)", "BSD (2 clause)", "*No copyright*
     BSD (2 clause)", "BSD (2 clause) Apache License 2.0", "MIT License ISC
     License", "Public domain", "*No copyright* Academic Free License", "Do
     What The Fuck You Want To Public License, Version 2", "*No copyright*
     Do What The Fuck You Want To Public License, Version 2", "*No
     copyright* ISC License", "*No copyright* BSD (3 clause)", "BSD (3
     clause) Mozilla Public License 2.0", "*No copyright* the Unlicense",
     "the Unlicense", "MIT License GNU General Public License, Version 3",
     "*No copyright* MIT License GNU General Public License, Version 3",
     "MIT License BSD (2 clause) Apache License 2.0", "GNU Lesser General
     Public License, Version 3", "GNU Library General Public License v2 or
     later". 15223 files have unknown license. Detailed output of
     licensecheck in
     /home/asn/workspace/package/fedora/REVIEW/1987284-nodejs-bash-
     language-server/licensecheck.txt
[?]: Package does not own files or directories owned by other packages.
     Note: Dirs in package are owned also by: /usr/lib/node_modules(nodejs)
[?]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[?]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: SourceX tarball generation or download is documented.
     Note: Package contains tarball without URL, check comments
	 URL is specified
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[-]: %check is present and all tests pass.
[?]: Packages should try to preserve timestamps of original installed
     files.
[x]: Spec use %global instead of %define unless justified.
     Note: %define requiring justification: %define pkg_name bash-language-
     server
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Package should compile and build into binary rpms on all supported
     architectures.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: nodejs-bash-language-server-1.17.0-5.fc35.noarch.rpm
          nodejs-bash-language-server-1.17.0-5.fc35.src.rpm
nodejs-bash-language-server.noarch: W: manpage-not-compressed gz /usr/lib/node_modules/bash-language-server/node_modules/sshpk/man/man1/sshpk-conv.1
nodejs-bash-language-server.noarch: W: manpage-not-compressed gz /usr/lib/node_modules/bash-language-server/node_modules/sshpk/man/man1/sshpk-sign.1
nodejs-bash-language-server.noarch: W: manpage-not-compressed gz /usr/lib/node_modules/bash-language-server/node_modules/sshpk/man/man1/sshpk-verify.1
nodejs-bash-language-server.noarch: W: spelling-error %description -l en_US explainshell -> explain shell, explain-shell, explains hell
nodejs-bash-language-server.noarch: E: useless-provides bundled(nodejs-extsprintf)
nodejs-bash-language-server.noarch: E: useless-provides bundled(nodejs-punycode)
nodejs-bash-language-server.noarch: E: useless-provides bundled(nodejs-tough-cookie)
nodejs-bash-language-server.noarch: W: only-non-binary-in-usr-lib
nodejs-bash-language-server.noarch: W: hidden-file-or-dir /usr/lib/node_modules/bash-language-server/node_modules/.bin
nodejs-bash-language-server.noarch: W: hidden-file-or-dir /usr/lib/node_modules/bash-language-server/node_modules/.bin
nodejs-bash-language-server.noarch: W: hidden-file-or-dir /usr/lib/node_modules/bash-language-server/node_modules/acorn-globals/node_modules/.bin
nodejs-bash-language-server.noarch: W: hidden-file-or-dir /usr/lib/node_modules/bash-language-server/node_modules/acorn-globals/node_modules/.bin
nodejs-bash-language-server.noarch: E: non-executable-script /usr/lib/node_modules/bash-language-server/node_modules/acorn/bin/_acorn.js 644 /usr/bin/node 
nodejs-bash-language-server.noarch: W: cross-directory-hard-link /usr/lib/node_modules/bash-language-server/node_modules/combined-stream/lib/defer.js /usr/lib/node_modules/bash-language-server/node_modules/asynckit/lib/defer.js
nodejs-bash-language-server.noarch: E: non-executable-script /usr/lib/node_modules/bash-language-server/node_modules/dashdash/etc/dashdash.bash_completion.in 644 /bin/bash 
nodejs-bash-language-server.noarch: W: cross-directory-hard-link /usr/lib/node_modules/bash-language-server/node_modules/delayed-stream/License /usr/lib/node_modules/bash-language-server/node_modules/combined-stream/License
nodejs-bash-language-server.noarch: W: hidden-file-or-dir /usr/lib/node_modules/bash-language-server/node_modules/escodegen/node_modules/.bin
nodejs-bash-language-server.noarch: W: hidden-file-or-dir /usr/lib/node_modules/bash-language-server/node_modules/escodegen/node_modules/.bin
nodejs-bash-language-server.noarch: W: cross-directory-hard-link /usr/lib/node_modules/bash-language-server/node_modules/estraverse/LICENSE.BSD /usr/lib/node_modules/bash-language-server/node_modules/escodegen/LICENSE.BSD
nodejs-bash-language-server.noarch: W: cross-directory-hard-link /usr/lib/node_modules/bash-language-server/node_modules/esutils/LICENSE.BSD /usr/lib/node_modules/bash-language-server/node_modules/escodegen/LICENSE.BSD
nodejs-bash-language-server.noarch: W: cross-directory-hard-link /usr/lib/node_modules/bash-language-server/node_modules/esutils/LICENSE.BSD /usr/lib/node_modules/bash-language-server/node_modules/estraverse/LICENSE.BSD
nodejs-bash-language-server.noarch: W: cross-directory-hard-link /usr/lib/node_modules/bash-language-server/node_modules/fast-json-stable-stringify/LICENSE /usr/lib/node_modules/bash-language-server/node_modules/concat-map/LICENSE
nodejs-bash-language-server.noarch: W: cross-directory-hard-link /usr/lib/node_modules/bash-language-server/node_modules/forever-agent/LICENSE /usr/lib/node_modules/bash-language-server/node_modules/aws-sign2/LICENSE
nodejs-bash-language-server.noarch: W: cross-directory-hard-link /usr/lib/node_modules/bash-language-server/node_modules/har-validator/LICENSE /usr/lib/node_modules/bash-language-server/node_modules/har-schema/LICENSE
nodejs-bash-language-server.noarch: W: cross-directory-hard-link /usr/lib/node_modules/bash-language-server/node_modules/http-signature/LICENSE /usr/lib/node_modules/bash-language-server/node_modules/getpass/LICENSE
nodejs-bash-language-server.noarch: W: hidden-file-or-dir /usr/lib/node_modules/bash-language-server/node_modules/http-signature/node_modules/.bin
nodejs-bash-language-server.noarch: W: hidden-file-or-dir /usr/lib/node_modules/bash-language-server/node_modules/http-signature/node_modules/.bin
nodejs-bash-language-server.noarch: W: cross-directory-hard-link /usr/lib/node_modules/bash-language-server/node_modules/is-typedarray/LICENSE.md /usr/lib/node_modules/bash-language-server/node_modules/concat-map/LICENSE
nodejs-bash-language-server.noarch: W: cross-directory-hard-link /usr/lib/node_modules/bash-language-server/node_modules/is-typedarray/LICENSE.md /usr/lib/node_modules/bash-language-server/node_modules/fast-json-stable-stringify/LICENSE
nodejs-bash-language-server.noarch: W: hidden-file-or-dir /usr/lib/node_modules/bash-language-server/node_modules/jsdom/node_modules/.bin
nodejs-bash-language-server.noarch: W: hidden-file-or-dir /usr/lib/node_modules/bash-language-server/node_modules/jsdom/node_modules/.bin
nodejs-bash-language-server.noarch: W: cross-directory-hard-link /usr/lib/node_modules/bash-language-server/node_modules/json-schema-traverse/LICENSE /usr/lib/node_modules/bash-language-server/node_modules/fast-deep-equal/LICENSE
nodejs-bash-language-server.noarch: W: cross-directory-hard-link /usr/lib/node_modules/bash-language-server/node_modules/jsprim/LICENSE /usr/lib/node_modules/bash-language-server/node_modules/extsprintf/LICENSE
nodejs-bash-language-server.noarch: W: cross-directory-hard-link /usr/lib/node_modules/bash-language-server/node_modules/lodash/fp/each.js /usr/lib/node_modules/bash-language-server/node_modules/lodash/each.js
nodejs-bash-language-server.noarch: W: cross-directory-hard-link /usr/lib/node_modules/bash-language-server/node_modules/lodash/fp/eachRight.js /usr/lib/node_modules/bash-language-server/node_modules/lodash/eachRight.js
nodejs-bash-language-server.noarch: W: cross-directory-hard-link /usr/lib/node_modules/bash-language-server/node_modules/lodash/fp/entries.js /usr/lib/node_modules/bash-language-server/node_modules/lodash/entries.js
nodejs-bash-language-server.noarch: W: cross-directory-hard-link /usr/lib/node_modules/bash-language-server/node_modules/lodash/fp/entriesIn.js /usr/lib/node_modules/bash-language-server/node_modules/lodash/entriesIn.js
nodejs-bash-language-server.noarch: W: cross-directory-hard-link /usr/lib/node_modules/bash-language-server/node_modules/lodash/fp/extend.js /usr/lib/node_modules/bash-language-server/node_modules/lodash/extend.js
nodejs-bash-language-server.noarch: W: cross-directory-hard-link /usr/lib/node_modules/bash-language-server/node_modules/lodash/fp/extendWith.js /usr/lib/node_modules/bash-language-server/node_modules/lodash/extendWith.js
nodejs-bash-language-server.noarch: W: cross-directory-hard-link /usr/lib/node_modules/bash-language-server/node_modules/lodash/fp/first.js /usr/lib/node_modules/bash-language-server/node_modules/lodash/first.js
nodejs-bash-language-server.noarch: W: cross-directory-hard-link /usr/lib/node_modules/bash-language-server/node_modules/mime-db/LICENSE /usr/lib/node_modules/bash-language-server/node_modules/array-equal/LICENSE
nodejs-bash-language-server.noarch: W: cross-directory-hard-link /usr/lib/node_modules/bash-language-server/node_modules/minimatch/LICENSE /usr/lib/node_modules/bash-language-server/node_modules/json-stringify-safe/LICENSE
nodejs-bash-language-server.noarch: W: cross-directory-hard-link /usr/lib/node_modules/bash-language-server/node_modules/oauth-sign/LICENSE /usr/lib/node_modules/bash-language-server/node_modules/aws-sign2/LICENSE
nodejs-bash-language-server.noarch: W: cross-directory-hard-link /usr/lib/node_modules/bash-language-server/node_modules/oauth-sign/LICENSE /usr/lib/node_modules/bash-language-server/node_modules/forever-agent/LICENSE
nodejs-bash-language-server.noarch: W: cross-directory-hard-link /usr/lib/node_modules/bash-language-server/node_modules/once/LICENSE /usr/lib/node_modules/bash-language-server/node_modules/json-stringify-safe/LICENSE
nodejs-bash-language-server.noarch: W: cross-directory-hard-link /usr/lib/node_modules/bash-language-server/node_modules/once/LICENSE /usr/lib/node_modules/bash-language-server/node_modules/minimatch/LICENSE
nodejs-bash-language-server.noarch: W: cross-directory-hard-link /usr/lib/node_modules/bash-language-server/node_modules/optionator/LICENSE /usr/lib/node_modules/bash-language-server/node_modules/levn/LICENSE
nodejs-bash-language-server.noarch: W: cross-directory-hard-link /usr/lib/node_modules/bash-language-server/node_modules/prelude-ls/LICENSE /usr/lib/node_modules/bash-language-server/node_modules/levn/LICENSE
nodejs-bash-language-server.noarch: W: cross-directory-hard-link /usr/lib/node_modules/bash-language-server/node_modules/prelude-ls/LICENSE /usr/lib/node_modules/bash-language-server/node_modules/optionator/LICENSE
nodejs-bash-language-server.noarch: W: cross-directory-hard-link /usr/lib/node_modules/bash-language-server/node_modules/request/LICENSE /usr/lib/node_modules/bash-language-server/node_modules/aws-sign2/LICENSE
nodejs-bash-language-server.noarch: W: cross-directory-hard-link /usr/lib/node_modules/bash-language-server/node_modules/request/LICENSE /usr/lib/node_modules/bash-language-server/node_modules/forever-agent/LICENSE
nodejs-bash-language-server.noarch: W: cross-directory-hard-link /usr/lib/node_modules/bash-language-server/node_modules/request/LICENSE /usr/lib/node_modules/bash-language-server/node_modules/oauth-sign/LICENSE
nodejs-bash-language-server.noarch: W: hidden-file-or-dir /usr/lib/node_modules/bash-language-server/node_modules/request/node_modules/.bin
nodejs-bash-language-server.noarch: W: hidden-file-or-dir /usr/lib/node_modules/bash-language-server/node_modules/request/node_modules/.bin
nodejs-bash-language-server.noarch: W: cross-directory-hard-link /usr/lib/node_modules/bash-language-server/node_modules/sshpk/LICENSE /usr/lib/node_modules/bash-language-server/node_modules/getpass/LICENSE
nodejs-bash-language-server.noarch: W: cross-directory-hard-link /usr/lib/node_modules/bash-language-server/node_modules/sshpk/LICENSE /usr/lib/node_modules/bash-language-server/node_modules/http-signature/LICENSE
nodejs-bash-language-server.noarch: W: cross-directory-hard-link /usr/lib/node_modules/bash-language-server/node_modules/stealthy-require/LICENSE /usr/lib/node_modules/bash-language-server/node_modules/request-promise-native/LICENSE
nodejs-bash-language-server.noarch: W: cross-directory-hard-link /usr/lib/node_modules/bash-language-server/node_modules/tough-cookie/lib/memstore.js /usr/lib/node_modules/bash-language-server/node_modules/request/node_modules/tough-cookie/lib/memstore.js
nodejs-bash-language-server.noarch: W: cross-directory-hard-link /usr/lib/node_modules/bash-language-server/node_modules/tough-cookie/lib/pathMatch.js /usr/lib/node_modules/bash-language-server/node_modules/request/node_modules/tough-cookie/lib/pathMatch.js
nodejs-bash-language-server.noarch: W: cross-directory-hard-link /usr/lib/node_modules/bash-language-server/node_modules/tough-cookie/lib/store.js /usr/lib/node_modules/bash-language-server/node_modules/request/node_modules/tough-cookie/lib/store.js
nodejs-bash-language-server.noarch: W: cross-directory-hard-link /usr/lib/node_modules/bash-language-server/node_modules/tr46/node_modules/punycode/LICENSE-MIT.txt /usr/lib/node_modules/bash-language-server/node_modules/punycode/LICENSE-MIT.txt
nodejs-bash-language-server.noarch: W: cross-directory-hard-link /usr/lib/node_modules/bash-language-server/node_modules/tunnel-agent/LICENSE /usr/lib/node_modules/bash-language-server/node_modules/aws-sign2/LICENSE
nodejs-bash-language-server.noarch: W: cross-directory-hard-link /usr/lib/node_modules/bash-language-server/node_modules/tunnel-agent/LICENSE /usr/lib/node_modules/bash-language-server/node_modules/forever-agent/LICENSE
nodejs-bash-language-server.noarch: W: cross-directory-hard-link /usr/lib/node_modules/bash-language-server/node_modules/tunnel-agent/LICENSE /usr/lib/node_modules/bash-language-server/node_modules/oauth-sign/LICENSE
nodejs-bash-language-server.noarch: W: cross-directory-hard-link /usr/lib/node_modules/bash-language-server/node_modules/tunnel-agent/LICENSE /usr/lib/node_modules/bash-language-server/node_modules/request/LICENSE
nodejs-bash-language-server.noarch: W: cross-directory-hard-link /usr/lib/node_modules/bash-language-server/node_modules/type-check/LICENSE /usr/lib/node_modules/bash-language-server/node_modules/levn/LICENSE
nodejs-bash-language-server.noarch: W: cross-directory-hard-link /usr/lib/node_modules/bash-language-server/node_modules/type-check/LICENSE /usr/lib/node_modules/bash-language-server/node_modules/optionator/LICENSE
nodejs-bash-language-server.noarch: W: cross-directory-hard-link /usr/lib/node_modules/bash-language-server/node_modules/type-check/LICENSE /usr/lib/node_modules/bash-language-server/node_modules/prelude-ls/LICENSE
nodejs-bash-language-server.noarch: W: cross-directory-hard-link /usr/lib/node_modules/bash-language-server/node_modules/verror/CONTRIBUTING.md /usr/lib/node_modules/bash-language-server/node_modules/jsprim/CONTRIBUTING.md
nodejs-bash-language-server.noarch: W: cross-directory-hard-link /usr/lib/node_modules/bash-language-server/node_modules/verror/node_modules/extsprintf/LICENSE /usr/lib/node_modules/bash-language-server/node_modules/extsprintf/LICENSE
nodejs-bash-language-server.noarch: W: cross-directory-hard-link /usr/lib/node_modules/bash-language-server/node_modules/verror/node_modules/extsprintf/LICENSE /usr/lib/node_modules/bash-language-server/node_modules/jsprim/LICENSE
nodejs-bash-language-server.noarch: W: cross-directory-hard-link /usr/lib/node_modules/bash-language-server/node_modules/verror/node_modules/extsprintf/Makefile.targ /usr/lib/node_modules/bash-language-server/node_modules/extsprintf/Makefile.targ
nodejs-bash-language-server.noarch: W: cross-directory-hard-link /usr/lib/node_modules/bash-language-server/node_modules/verror/node_modules/extsprintf/README.md /usr/lib/node_modules/bash-language-server/node_modules/extsprintf/README.md
nodejs-bash-language-server.noarch: W: cross-directory-hard-link /usr/lib/node_modules/bash-language-server/node_modules/verror/node_modules/extsprintf/jsl.node.conf /usr/lib/node_modules/bash-language-server/node_modules/extsprintf/jsl.node.conf
nodejs-bash-language-server.noarch: W: cross-directory-hard-link /usr/lib/node_modules/bash-language-server/node_modules/vscode-languageserver-protocol/License.txt /usr/lib/node_modules/bash-language-server/node_modules/vscode-jsonrpc/License.txt
nodejs-bash-language-server.noarch: W: cross-directory-hard-link /usr/lib/node_modules/bash-language-server/node_modules/vscode-languageserver-textdocument/lib/umd/main.d.ts /usr/lib/node_modules/bash-language-server/node_modules/vscode-languageserver-textdocument/lib/esm/main.d.ts
nodejs-bash-language-server.noarch: W: cross-directory-hard-link /usr/lib/node_modules/bash-language-server/node_modules/vscode-languageserver-types/License.txt /usr/lib/node_modules/bash-language-server/node_modules/vscode-jsonrpc/License.txt
nodejs-bash-language-server.noarch: W: cross-directory-hard-link /usr/lib/node_modules/bash-language-server/node_modules/vscode-languageserver-types/License.txt /usr/lib/node_modules/bash-language-server/node_modules/vscode-languageserver-protocol/License.txt
nodejs-bash-language-server.noarch: W: cross-directory-hard-link /usr/lib/node_modules/bash-language-server/node_modules/vscode-languageserver-types/lib/umd/main.d.ts /usr/lib/node_modules/bash-language-server/node_modules/vscode-languageserver-types/lib/esm/main.d.ts
nodejs-bash-language-server.noarch: W: cross-directory-hard-link /usr/lib/node_modules/bash-language-server/node_modules/vscode-languageserver/License.txt /usr/lib/node_modules/bash-language-server/node_modules/vscode-jsonrpc/License.txt
nodejs-bash-language-server.noarch: W: cross-directory-hard-link /usr/lib/node_modules/bash-language-server/node_modules/vscode-languageserver/License.txt /usr/lib/node_modules/bash-language-server/node_modules/vscode-languageserver-protocol/License.txt
nodejs-bash-language-server.noarch: W: cross-directory-hard-link /usr/lib/node_modules/bash-language-server/node_modules/vscode-languageserver/License.txt /usr/lib/node_modules/bash-language-server/node_modules/vscode-languageserver-types/License.txt
nodejs-bash-language-server.noarch: E: wrong-script-end-of-line-encoding /usr/lib/node_modules/bash-language-server/node_modules/vscode-languageserver/bin/installServerIntoExtension
nodejs-bash-language-server.noarch: W: cross-directory-hard-link /usr/lib/node_modules/bash-language-server/node_modules/vscode-languageserver/typings/thenable.d.ts /usr/lib/node_modules/bash-language-server/node_modules/vscode-jsonrpc/typings/thenable.d.ts
nodejs-bash-language-server.noarch: W: cross-directory-hard-link /usr/lib/node_modules/bash-language-server/node_modules/whatwg-encoding/LICENSE.txt /usr/lib/node_modules/bash-language-server/node_modules/html-encoding-sniffer/LICENSE.txt
nodejs-bash-language-server.noarch: W: cross-directory-hard-link /usr/lib/node_modules/bash-language-server/node_modules/wordwrap/LICENSE /usr/lib/node_modules/bash-language-server/node_modules/concat-map/LICENSE
nodejs-bash-language-server.noarch: W: cross-directory-hard-link /usr/lib/node_modules/bash-language-server/node_modules/wordwrap/LICENSE /usr/lib/node_modules/bash-language-server/node_modules/fast-json-stable-stringify/LICENSE
nodejs-bash-language-server.noarch: W: cross-directory-hard-link /usr/lib/node_modules/bash-language-server/node_modules/wordwrap/LICENSE /usr/lib/node_modules/bash-language-server/node_modules/is-typedarray/LICENSE.md
nodejs-bash-language-server.noarch: W: cross-directory-hard-link /usr/lib/node_modules/bash-language-server/node_modules/wrappy/LICENSE /usr/lib/node_modules/bash-language-server/node_modules/json-stringify-safe/LICENSE
nodejs-bash-language-server.noarch: W: cross-directory-hard-link /usr/lib/node_modules/bash-language-server/node_modules/wrappy/LICENSE /usr/lib/node_modules/bash-language-server/node_modules/minimatch/LICENSE
nodejs-bash-language-server.noarch: W: cross-directory-hard-link /usr/lib/node_modules/bash-language-server/node_modules/wrappy/LICENSE /usr/lib/node_modules/bash-language-server/node_modules/once/LICENSE
nodejs-bash-language-server.noarch: W: no-manual-page-for-binary bash-language-server
nodejs-bash-language-server.src: W: spelling-error %description -l en_US explainshell -> explain shell, explain-shell, explains hell
nodejs-bash-language-server.src: W: invalid-url Source1: bash-language-server-1.17.0-vendor.tar.xz
2 packages and 0 specfiles checked; 6 errors, 88 warnings.

going through the errors, the first 5 are not applicable. The last one is not critical.




Rpmlint (installed packages)
----------------------------
Cannot parse rpmlint output:


Source checksums
----------------
https://github.com/bash-lsp/bash-language-server/archive/server-1.17.0/bash-language-server-1.17.0.tar.gz :
  CHECKSUM(SHA256) this package     : 9a1d11500577df2c80e6525df0687d3dc67f027177467c3ee2eeec19d1e6c097
  CHECKSUM(SHA256) upstream package : 9a1d11500577df2c80e6525df0687d3dc67f027177467c3ee2eeec19d1e6c097


Requires
--------
nodejs-bash-language-server (rpmlib, GLIBC filtered):
    /usr/bin/bash
    /usr/bin/node
    /usr/bin/sh



Provides
--------
nodejs-bash-language-server:
    bundled(nodejs-abab)
    bundled(nodejs-acorn)
    bundled(nodejs-acorn-globals)
    bundled(nodejs-ajv)
    bundled(nodejs-array-equal)
    bundled(nodejs-asn1)
    bundled(nodejs-assert-plus)
    bundled(nodejs-async-limiter)
    bundled(nodejs-asynckit)
    bundled(nodejs-aws-sign2)
    bundled(nodejs-aws4)
    bundled(nodejs-balanced-match)
    bundled(nodejs-bcrypt-pbkdf)
    bundled(nodejs-brace-expansion)
    bundled(nodejs-browser-process-hrtime)
    bundled(nodejs-caseless)
    bundled(nodejs-co)
    bundled(nodejs-combined-stream)
    bundled(nodejs-concat-map)
    bundled(nodejs-core-util-is)
    bundled(nodejs-cssom)
    bundled(nodejs-cssstyle)
    bundled(nodejs-dashdash)
    bundled(nodejs-data-urls)
    bundled(nodejs-deep-is)
    bundled(nodejs-delayed-stream)
    bundled(nodejs-domexception)
    bundled(nodejs-ecc-jsbn)
    bundled(nodejs-escodegen)
    bundled(nodejs-esprima)
    bundled(nodejs-estraverse)
    bundled(nodejs-esutils)
    bundled(nodejs-extend)
    bundled(nodejs-extsprintf)
    bundled(nodejs-fast-deep-equal)
    bundled(nodejs-fast-json-stable-stringify)
    bundled(nodejs-fast-levenshtein)
    bundled(nodejs-forever-agent)
    bundled(nodejs-form-data)
    bundled(nodejs-fs.realpath)
    bundled(nodejs-fuzzy-search)
    bundled(nodejs-getpass)
    bundled(nodejs-glob)
    bundled(nodejs-har-schema)
    bundled(nodejs-har-validator)
    bundled(nodejs-html-encoding-sniffer)
    bundled(nodejs-http-signature)
    bundled(nodejs-iconv-lite)
    bundled(nodejs-inflight)
    bundled(nodejs-inherits)
    bundled(nodejs-is-typedarray)
    bundled(nodejs-isstream)
    bundled(nodejs-jsbn)
    bundled(nodejs-jsdom)
    bundled(nodejs-json-schema)
    bundled(nodejs-json-schema-traverse)
    bundled(nodejs-json-stringify-safe)
    bundled(nodejs-jsprim)
    bundled(nodejs-left-pad)
    bundled(nodejs-levn)
    bundled(nodejs-lodash)
    bundled(nodejs-lodash.sortby)
    bundled(nodejs-mime-db)
    bundled(nodejs-mime-types)
    bundled(nodejs-minimatch)
    bundled(nodejs-nwsapi)
    bundled(nodejs-oauth-sign)
    bundled(nodejs-once)
    bundled(nodejs-optionator)
    bundled(nodejs-parse5)
    bundled(nodejs-path-is-absolute)
    bundled(nodejs-performance-now)
    bundled(nodejs-pn)
    bundled(nodejs-prelude-ls)
    bundled(nodejs-psl)
    bundled(nodejs-punycode)
    bundled(nodejs-qs)
    bundled(nodejs-request)
    bundled(nodejs-request-promise-core)
    bundled(nodejs-request-promise-native)
    bundled(nodejs-safe-buffer)
    bundled(nodejs-safer-buffer)
    bundled(nodejs-sax)
    bundled(nodejs-source-map)
    bundled(nodejs-sshpk)
    bundled(nodejs-stealthy-require)
    bundled(nodejs-symbol-tree)
    bundled(nodejs-tough-cookie)
    bundled(nodejs-tr46)
    bundled(nodejs-tunnel-agent)
    bundled(nodejs-turndown)
    bundled(nodejs-tweetnacl)
    bundled(nodejs-type-check)
    bundled(nodejs-urijs)
    bundled(nodejs-uuid)
    bundled(nodejs-verror)
    bundled(nodejs-vscode-jsonrpc)
    bundled(nodejs-vscode-languageserver)
    bundled(nodejs-vscode-languageserver-protocol)
    bundled(nodejs-vscode-languageserver-textdocument)
    bundled(nodejs-vscode-languageserver-types)
    bundled(nodejs-w3c-hr-time)
    bundled(nodejs-web-tree-sitter)
    bundled(nodejs-webidl-conversions)
    bundled(nodejs-whatwg-encoding)
    bundled(nodejs-whatwg-mimetype)
    bundled(nodejs-whatwg-url)
    bundled(nodejs-wordwrap)
    bundled(nodejs-wrappy)
    bundled(nodejs-ws)
    bundled(nodejs-xml-name-validator)
    nodejs-bash-language-server
    npm(bash-language-server)



Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10
Command line :/usr/bin/fedora-review -b 1987284
Buildroot used: fedora-rawhide-x86_64
Active plugins: Shell-api, Generic
Disabled plugins: Perl, Ocaml, Python, R, Java, PHP, C/C++, Haskell, SugarActivity, fonts
Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH




Review approved
Comment 7 Gwyn Ciesla 2021-08-06 15:16:36 UTC 
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/nodejs-bash-language-server
Note You need to log in before you can comment on or make changes to this bug.