Bug 1987564 - Review Request: <mongoInc-backup-0.1-1.fc34.x86_64.rpm> - <mongoInc-backup>
Summary: Review Request: <mongoInc-backup-0.1-1.fc34.x86_64.rpm> - <mongoInc-backup>
Keywords:
Status: CLOSED EOL
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: 34
Hardware: All
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-07-29 15:16 UTC by ergün
Modified: 2022-06-08 00:14 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2022-06-08 00:14:35 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description ergün 2021-07-29 15:16:25 UTC
Spec URL: https://github.com/OEntegrasyon/MongoDB_incremental_backup/releases/tag/mongoInc-backup
SRPM URL: https://github.com/OEntegrasyon/MongoDB_incremental_backup/releases/tag/mongoInc-backup
Description: It is a RPM package that can save incremental backups for the MogoDb and restore them in point-time recovery.
Fedora Account System Username:

Comment 1 Ben Beasley 2021-07-30 19:03:30 UTC
Please fix the review title by filling in the template values, and fill in your FAS username.

Comment 2 ergün 2021-08-03 07:47:17 UTC
Fas : erelbi

Comment 3 Artur Frenszek-Iwicki 2021-08-03 10:39:28 UTC
> Spec URL: https://github.com/OEntegrasyon/MongoDB_incremental_backup/releases/tag/mongoInc-backup
> SRPM URL: https://github.com/OEntegrasyon/MongoDB_incremental_backup/releases/tag/mongoInc-backup
This is a link to a GitHub downloads page. Please use direct links to the "raw" .spec and .src.rpm files.

> License:      GNU
GNU is a free software project, not the name of a license. Looking at the sources, you meant the GNU General Public License, version 3. Use "GPLv3" here.
https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing#SoftwareLicenses

> Group:        System
> Packager:   Ergün Elvan Bilsel
Not used in Fedora.
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_tags_and_sections

> mkdir -p $RPM_BUILD_ROOT/etc/mongobackup/
> mkdir -p $RPM_BUILD_ROOT/usr/local/bin/
> mkdir -p $RPM_BUILD_ROOT/usr/share/licenses/mongoInc-backup/
> mkdir -p $RPM_BUILD_ROOT/usr/share/doc/mongoInc-backup/
Do not use hard-coded paths. You should use the appropriate RPM macros instead, e.g. '/usr/share' -> '%{_datadir}'.
https://docs.fedoraproject.org/en-US/packaging-guidelines/RPMMacros/#_macros_for_paths_set_and_used_by_build_systems

> cp /home/ergunbilsel/PycharmProjects/mongoinc/mongoInc-backup-0.1/mongodb-backup.config $RPM_BUILD_ROOT/etc/mongobackup/
> ...
> cp /home/ergunbilsel/PycharmProjects/mongoinc/mongoInc-backup-0.1/THANKS  $RPM_BUILD_ROOT/usr/share/doc/mongoInc-backup/
1. Uh... this will fail when run anywhere else apart from your machine. 
2. This is done in %prep, whereas it should be done in %install.

Comment 4 Ben Cotton 2022-05-12 16:18:17 UTC
This message is a reminder that Fedora Linux 34 is nearing its end of life.
Fedora will stop maintaining and issuing updates for Fedora Linux 34 on 2022-06-07.
It is Fedora's policy to close all bug reports from releases that are no longer
maintained. At that time this bug will be closed as EOL if it remains open with a
'version' of '34'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, change the 'version' 
to a later Fedora Linux version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora Linux 34 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora Linux, you are encouraged to change the 'version' to a later version
prior to this bug being closed.

Comment 5 Ben Cotton 2022-06-08 00:14:35 UTC
Fedora Linux 34 entered end-of-life (EOL) status on 2022-06-07.

Fedora Linux 34 is no longer maintained, which means that it
will not receive any further security or bug fix updates. As a result we
are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release.

Thank you for reporting this bug and we are sorry it could not be fixed.


Note You need to log in before you can comment on or make changes to this bug.