Spec URL: http://www.kobold.org/~wart/fedora/skstream.spec SRPM URL: http://www.kobold.org/~wart/fedora/skstream-0.3.5-1.src.rpm Description: skstream is an isotream C++ socket library and is recommended for use as a transport for Atlas-C++. It is capable of creating iostream-based socket connections for both clients and servers.
- rpmlint output: W: skstream-devel no-documentation okay to ignore, I don't see any documentation which should go in devel - package is named according to package naming guidelines - spec filename matches package %{name} - package meets package naming guidelines - package licensed with open source compatible license - license field matches actual license - license included in %doc - spec file written in American english - spec file is legible - sources match upstream 0c5ec89551bc0900b2e708992f321794 skstream-0.3.5.tar.gz - package successfully compiles and builds on x86_64 FC-5 - All build dependencies listed in BuildRequires, optional dependencies not listed (zlib) - package does not contain locales - ldconfig properly called in %post/%postun - package is not relocatable - package owns all directories it creates - package does not contain any duplicate files - permissions on files is set properly - package contains proper %clean section - macro usage is consistant - package contains permissible content - package does not contain large documentation - files in %doc do not affect runtime - header files are contained in devel package - pkgconfig files are in devel package - library files w/o suffix are in devel - devel package requires base package - package does not contain .la files - package does not own files or directories owned by other packages ==== MUST ==== - Add Requires: pkgconfig to devel package - Explain why this is not compiled with optional zlib library - contact upstream about make docs error ==== NOTES ==== - make check has some failures, but these are okay, they require the echo service to be enabled or be run as root. I enabled echo on my system and ran make check as root and these tests pass.
(In reply to comment #1) > ==== MUST ==== > - Add Requires: pkgconfig to devel package Done. > - Explain why this is not compiled with optional zlib library I don't see that zlib is used anywhere? When I added BR: zlib-devel and compared the build logs, I didn't see any difference. Where did you see something that indicated that zlib could be used? > - contact upstream about make docs error Will do. > ==== NOTES ==== > - make check has some failures, but these are okay, they require the echo > service to be enabled or b> - rpmlint output: > W: skstream-devel no-documentation Updated files: http://www.kobold.org/~wart/fedora/skstream-0.3.5-2.src.rpm http://www.kobold.org/~wart/fedora/skstream.spec
oh the configure file checks for zip for some reason, not zlib, sorry. AC_CHECK_PROG(SK_ZIP, zip, zip, no) Ill go ahead and approve this, but might be worth finding out why zip is checked.
(In reply to comment #3) > oh the configure file checks for zip for some reason, not zlib, sorry. > > AC_CHECK_PROG(SK_ZIP, zip, zip, no) > > Ill go ahead and approve this, but might be worth finding out why zip is checked. As best as I can tell from grepping and browsing the Makefiles, this is only used during a Windows build for the Windows installer. It doesn't seem to make any difference on linux.
Imported and built for rawhide. Thanks!