Bug 1988496 - vmconsole-proxy-helper.cer is not renewed when running engine-setup
Summary: vmconsole-proxy-helper.cer is not renewed when running engine-setup
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Virtualization Manager
Classification: Red Hat
Component: ovirt-engine
Version: 4.4.6
Hardware: x86_64
OS: Unspecified
unspecified
low
Target Milestone: ovirt-4.5.0-1
: 4.5.0
Assignee: Milan Zamazal
QA Contact: Qin Yuan
URL:
Whiteboard:
: 2077907 (view as bug list)
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-07-30 16:38 UTC by Federico Sun
Modified: 2023-07-17 09:50 UTC (History)
12 users (show)

Fixed In Version: ovirt-engine-4.5.0.5
Doc Type: Bug Fix
Doc Text:
Previously, the vmconsole-proxy-helper certificate was not renewed when needed. With this release, the certificate is renewed each time following the CA certificate update.
Clone Of:
Environment:
Last Closed: 2022-05-26 16:23:07 UTC
oVirt Team: Virt
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github oVirt ovirt-engine pull 298 0 None open packaging: Renew expiring vmconsole certificates 2022-04-22 09:54:11 UTC
Github oVirt ovirt-engine pull 311 0 None open packaging: Renew expiring vmconsole certificates 2022-04-25 12:49:50 UTC
Red Hat Knowledge Base (Solution) 6838231 0 None None None 2022-03-23 17:22:54 UTC
Red Hat Product Errata RHSA-2022:4711 0 None None None 2022-05-26 16:23:16 UTC
oVirt gerrit 116201 0 master MERGED setup: Renew vmconsole proxy helper certificate 2021-08-16 12:36:55 UTC

Description Federico Sun 2021-07-30 16:38:00 UTC
Description of problem:

An expired 'vmconsole-proxy-helper.cer' is not renewed with `engine-setup`.


Version-Release number of selected component (if applicable):

RHV 4.x


How reproducible:

100%


Additional info:

Manual renewal of this certificate with `pki-enroll-pkcs12.sh` requires these 2 extra parameters: "--ku=digitalSignature --eku=1.3.6.1.4.1.2312.13.1.2.1.1"

Comment 1 Yedidyah Bar David 2021-08-04 14:22:40 UTC
A workaround:

# cd /etc/pki/ovirt-engine
# rm ./keys/vmconsole-proxy-helper.p12 ./keys/vmconsole-proxy-helper.key.nopass ./certs/vmconsole-proxy-helper.cer
# engine-setup --offline

I consider not touching/using the renew code but instead do something like [1], but for the helper. I think it should be enough, and due to the need to handle EKU, much simpler.

[1] https://gerrit.ovirt.org/c/ovirt-engine/+/108416

Comment 2 Yedidyah Bar David 2021-08-05 06:58:14 UTC
Milan, can you please have a look and/or take over? Thanks.

Comment 3 Milan Zamazal 2021-08-09 06:29:00 UTC
I'll look at it.

Comment 7 Qin Yuan 2022-04-22 02:55:48 UTC
The current fix only renews vmconsole cert when the engine CA cert is newer than the vmconsole cert.

Moving back to assigned for also renewing vmconsole cert when engine CA cert has longer expiration than vmconsole cert and the vmconsole cert has expired.

Comment 8 Andreas Bleischwitz 2022-04-22 15:01:29 UTC
*** Bug 2077907 has been marked as a duplicate of this bug. ***

Comment 10 Qin Yuan 2022-04-28 14:49:03 UTC
Verified with:
ovirt-engine-4.5.0.5-0.7.el8ev.noarch

Steps:
1. Update engine CA cert to make it newer than vmconsole-proxy-helper.cer, then run `engine-setup --offline` and check if vmconsole-proxy-helper.cer is refreshed.
2. Make vmconsole-proxy-helper.cer expire, but engine CA not expire, such as changing the system date, then run `engine-setup --offline` and check if vmconsole-proxy-helper.cer is refreshed.

Results:
1. vmconsole-proxy-helper.cer is refreshed during engine-setup when the engine CA cert is updated.
2. vmconsole-proxy-helper.cer is refreshed during engine-setup when vmconsole-proxy-helper.cer is expired.

Comment 15 errata-xmlrpc 2022-05-26 16:23:07 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: RHV Manager (ovirt-engine) [ovirt-4.5.0] security update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2022:4711

Comment 16 meital avital 2022-07-20 09:12:17 UTC
Due to QE capacity, we are not going to cover this issue in our automation

Comment 17 betrayonu 2023-07-17 09:50:47 UTC
running engine-setup should give you the opportunity to update
expired or expiring certificates.
If you don't want to upgrade your system you can run it with the offline option on https://asmallworldcup.com


Note You need to log in before you can comment on or make changes to this bug.