Bug 1988693 - Review Request: mingw-qt6-qt3d - Qt6 for Windows - Qt3d component
Summary: Review Request: mingw-qt6-qt3d - Qt6 for Windows - Qt3d component
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Major Hayden 🤠
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-07-31 10:20 UTC by Sandro Mani
Modified: 2021-08-09 21:02 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2021-08-09 21:02:13 UTC
Type: ---
Embargoed:
mhayden: fedora-review+


Attachments (Terms of Use)

Description Sandro Mani 2021-07-31 10:20:56 UTC
Spec URL: https://smani.fedorapeople.org/review/mingw-qt6-qt3d.spec
SRPM URL: https://smani.fedorapeople.org/review/mingw-qt6-qt3d-6.1.1-1.fc35.src.rpm
Description: Qt6 for Windows - Qt3d component
Fedora Account System Username: smani

Comment 1 Major Hayden 🤠 2021-08-02 19:45:22 UTC
This one fails to build in rawhide.

No matches found for the following disable plugin patterns: local, spacewalk, versionlock
Copr repository                                 181 kB/s | 3.0 kB     00:00    
fedora                                           34 kB/s | 9.9 kB     00:00    
No matching package to install: 'mingw32-qt6-qtbase = 6.1.1'
No matching package to install: 'mingw32-qt6-qtdeclarative = 6.1.1'
No matching package to install: 'mingw64-qt6-qtbase = 6.1.1'
No matching package to install: 'mingw64-qt6-qtdeclarative = 6.1.1'

Comment 2 Sandro Mani 2021-08-09 10:09:10 UTC
mingw-qt6-qtdeclarative is now available in rawhide.

Comment 3 Major Hayden 🤠 2021-08-09 14:39:01 UTC
Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
=======

The only issues found are ones that are common to mingw packages. This looks fine. Approved! 🎉

===== MUST items =====

Generic:
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
     Note: Using prebuilt packages
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "GNU General Public License, Version
     2", "GNU Lesser General Public License, Version 3", "GNU General
     Public License, Version 3", "*No copyright* [generated file]", "GNU
     Lesser General Public License, Version 3 GNU General Public License,
     Version 2", "BSD 3-clause "New" or "Revised" License", "Expat License
     BSD 2-clause "Simplified" License", "zlib/libpng license", "*No
     copyright* zlib/libpng license", "Boost Software License 1.0", "the
     Unlicense", "Expat License", "the Unlicense Expat License", "GNU
     Lesser General Public License, Version 3 GNU General Public License
     v2.0 or later", "GNU Free Documentation License, Version 1.3", "BSD
     2-clause "Simplified" License", "*No copyright* Public domain", "*No
     copyright* Boost Software License 1.0", "*No copyright* Boost Software
     License", "Expat License JSON License BSD 3-clause "New" or "Revised"
     License", "*No copyright* Creative Commons Attribution 2.5 Generic
     License", "Apache License 2.0", "BSD 3-clause "New" or "Revised"
     License [generated file]", "*No copyright* Expat License", "GNU
     General Public License", "NTP License". 3746 files have unknown
     license. Detailed output of licensecheck in /var/lib/copr-
     rpmbuild/results/mingw-qt6-qt3d/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: If the package is under multiple licenses, the licensing breakdown
     must be documented in the spec.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[X]: Package complies to the Packaging Guidelines
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[x]: Reviewer should test that the package builds in mock.
[x]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
     mingw32-qt6-qt3d , mingw64-qt6-qt3d
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise
     justified.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[x]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Spec use %global instead of %define unless justified.
     Note: %define requiring justification: %define release_version %(echo
     %{version} | awk -F. '{print $1"."$2}')
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).


Rpmlint
-------
Checking: mingw32-qt6-qt3d-6.1.1-1.fc35.noarch.rpm
          mingw64-qt6-qt3d-6.1.1-1.fc35.noarch.rpm
          mingw-qt6-qt3d-6.1.1-1.fc35.src.rpm
mingw32-qt6-qt3d.noarch: E: arch-independent-package-contains-binary-or-object /usr/i686-w64-mingw32/sys-root/mingw/lib/libQt63DAnimation.dll.a
mingw32-qt6-qt3d.noarch: E: arch-independent-package-contains-binary-or-object /usr/i686-w64-mingw32/sys-root/mingw/lib/libQt63DCore.dll.a
mingw32-qt6-qt3d.noarch: E: arch-independent-package-contains-binary-or-object /usr/i686-w64-mingw32/sys-root/mingw/lib/libQt63DExtras.dll.a
mingw32-qt6-qt3d.noarch: E: arch-independent-package-contains-binary-or-object /usr/i686-w64-mingw32/sys-root/mingw/lib/libQt63DInput.dll.a
mingw32-qt6-qt3d.noarch: E: arch-independent-package-contains-binary-or-object /usr/i686-w64-mingw32/sys-root/mingw/lib/libQt63DLogic.dll.a
mingw32-qt6-qt3d.noarch: E: arch-independent-package-contains-binary-or-object /usr/i686-w64-mingw32/sys-root/mingw/lib/libQt63DQuick.dll.a
mingw32-qt6-qt3d.noarch: E: arch-independent-package-contains-binary-or-object /usr/i686-w64-mingw32/sys-root/mingw/lib/libQt63DQuickAnimation.dll.a
mingw32-qt6-qt3d.noarch: E: arch-independent-package-contains-binary-or-object /usr/i686-w64-mingw32/sys-root/mingw/lib/libQt63DQuickExtras.dll.a
mingw32-qt6-qt3d.noarch: E: arch-independent-package-contains-binary-or-object /usr/i686-w64-mingw32/sys-root/mingw/lib/libQt63DQuickInput.dll.a
mingw32-qt6-qt3d.noarch: E: arch-independent-package-contains-binary-or-object /usr/i686-w64-mingw32/sys-root/mingw/lib/libQt63DQuickRender.dll.a
mingw32-qt6-qt3d.noarch: E: arch-independent-package-contains-binary-or-object /usr/i686-w64-mingw32/sys-root/mingw/lib/libQt63DQuickScene2D.dll.a
mingw32-qt6-qt3d.noarch: E: arch-independent-package-contains-binary-or-object /usr/i686-w64-mingw32/sys-root/mingw/lib/libQt63DRender.dll.a
mingw64-qt6-qt3d.noarch: E: arch-independent-package-contains-binary-or-object /usr/x86_64-w64-mingw32/sys-root/mingw/lib/libQt63DAnimation.dll.a
mingw64-qt6-qt3d.noarch: E: arch-independent-package-contains-binary-or-object /usr/x86_64-w64-mingw32/sys-root/mingw/lib/libQt63DCore.dll.a
mingw64-qt6-qt3d.noarch: E: arch-independent-package-contains-binary-or-object /usr/x86_64-w64-mingw32/sys-root/mingw/lib/libQt63DExtras.dll.a
mingw64-qt6-qt3d.noarch: E: arch-independent-package-contains-binary-or-object /usr/x86_64-w64-mingw32/sys-root/mingw/lib/libQt63DInput.dll.a
mingw64-qt6-qt3d.noarch: E: arch-independent-package-contains-binary-or-object /usr/x86_64-w64-mingw32/sys-root/mingw/lib/libQt63DLogic.dll.a
mingw64-qt6-qt3d.noarch: E: arch-independent-package-contains-binary-or-object /usr/x86_64-w64-mingw32/sys-root/mingw/lib/libQt63DQuick.dll.a
mingw64-qt6-qt3d.noarch: E: arch-independent-package-contains-binary-or-object /usr/x86_64-w64-mingw32/sys-root/mingw/lib/libQt63DQuickAnimation.dll.a
mingw64-qt6-qt3d.noarch: E: arch-independent-package-contains-binary-or-object /usr/x86_64-w64-mingw32/sys-root/mingw/lib/libQt63DQuickExtras.dll.a
mingw64-qt6-qt3d.noarch: E: arch-independent-package-contains-binary-or-object /usr/x86_64-w64-mingw32/sys-root/mingw/lib/libQt63DQuickInput.dll.a
mingw64-qt6-qt3d.noarch: E: arch-independent-package-contains-binary-or-object /usr/x86_64-w64-mingw32/sys-root/mingw/lib/libQt63DQuickRender.dll.a
mingw64-qt6-qt3d.noarch: E: arch-independent-package-contains-binary-or-object /usr/x86_64-w64-mingw32/sys-root/mingw/lib/libQt63DQuickScene2D.dll.a
mingw64-qt6-qt3d.noarch: E: arch-independent-package-contains-binary-or-object /usr/x86_64-w64-mingw32/sys-root/mingw/lib/libQt63DRender.dll.a
mingw-qt6-qt3d.src: E: specfile-error warning: Macro expanded in comment on line 7: (c=%{commit}; echo ${c:0:7})
mingw-qt6-qt3d.src: E: specfile-error warning: Macro expanded in comment on line 7: (c=%{commit}; echo ${c:0:7})
3 packages and 0 specfiles checked; 26 errors, 1659 warnings.




Rpmlint (installed packages)
----------------------------
Cannot parse rpmlint output:


Source checksums
----------------
http://download.qt.io/official_releases/qt/6.1/6.1.1/submodules/qt3d-everywhere-src-6.1.1.tar.xz :
  CHECKSUM(SHA256) this package     : 66e25fcf0bd965374f9814ef8fb960ff7c0414ec9480dcdc57caad17f23ede08
  CHECKSUM(SHA256) upstream package : 66e25fcf0bd965374f9814ef8fb960ff7c0414ec9480dcdc57caad17f23ede08


Requires
--------
mingw32-qt6-qt3d (rpmlib, GLIBC filtered):
    mingw32(kernel32.dll)
    mingw32(libgcc_s_dw2-1.dll)
    mingw32(libssp-0.dll)
    mingw32(libstdc++-6.dll)
    mingw32(libwinpthread-1.dll)
    mingw32(msvcrt.dll)
    mingw32(qt63danimation.dll)
    mingw32(qt63dcore.dll)
    mingw32(qt63dextras.dll)
    mingw32(qt63dinput.dll)
    mingw32(qt63dlogic.dll)
    mingw32(qt63dquick.dll)
    mingw32(qt63dquickanimation.dll)
    mingw32(qt63dquickextras.dll)
    mingw32(qt63dquickinput.dll)
    mingw32(qt63dquickrender.dll)
    mingw32(qt63dquickscene2d.dll)
    mingw32(qt63drender.dll)
    mingw32(qt6concurrent.dll)
    mingw32(qt6core.dll)
    mingw32(qt6gui.dll)
    mingw32(qt6network.dll)
    mingw32(qt6opengl.dll)
    mingw32(qt6qml.dll)
    mingw32(qt6qmlmodels.dll)
    mingw32(qt6quick.dll)
    mingw32(zlib1.dll)
    mingw32-crt
    mingw32-filesystem

mingw64-qt6-qt3d (rpmlib, GLIBC filtered):
    mingw64(kernel32.dll)
    mingw64(libgcc_s_seh-1.dll)
    mingw64(libssp-0.dll)
    mingw64(libstdc++-6.dll)
    mingw64(libwinpthread-1.dll)
    mingw64(msvcrt.dll)
    mingw64(qt63danimation.dll)
    mingw64(qt63dcore.dll)
    mingw64(qt63dextras.dll)
    mingw64(qt63dinput.dll)
    mingw64(qt63dlogic.dll)
    mingw64(qt63dquick.dll)
    mingw64(qt63dquickanimation.dll)
    mingw64(qt63dquickextras.dll)
    mingw64(qt63dquickinput.dll)
    mingw64(qt63dquickrender.dll)
    mingw64(qt63dquickscene2d.dll)
    mingw64(qt63drender.dll)
    mingw64(qt6concurrent.dll)
    mingw64(qt6core.dll)
    mingw64(qt6gui.dll)
    mingw64(qt6network.dll)
    mingw64(qt6opengl.dll)
    mingw64(qt6qml.dll)
    mingw64(qt6qmlmodels.dll)
    mingw64(qt6quick.dll)
    mingw64(zlib1.dll)
    mingw64-crt
    mingw64-filesystem



Provides
--------
mingw32-qt6-qt3d:
    mingw32(assimpsceneimport.dll)
    mingw32(defaultgeometryloader.dll)
    mingw32(gltfsceneexport.dll)
    mingw32(gltfsceneimport.dll)
    mingw32(openglrenderer.dll)
    mingw32(qt63danimation.dll)
    mingw32(qt63dcore.dll)
    mingw32(qt63dextras.dll)
    mingw32(qt63dinput.dll)
    mingw32(qt63dlogic.dll)
    mingw32(qt63dquick.dll)
    mingw32(qt63dquickanimation.dll)
    mingw32(qt63dquickextras.dll)
    mingw32(qt63dquickinput.dll)
    mingw32(qt63dquickrender.dll)
    mingw32(qt63dquickscene2d.dll)
    mingw32(qt63drender.dll)
    mingw32(qtquickscene2dplugin.dll)
    mingw32(qtquickscene3dplugin.dll)
    mingw32(quick3danimationplugin.dll)
    mingw32(quick3dcoreplugin.dll)
    mingw32(quick3dextrasplugin.dll)
    mingw32(quick3dinputplugin.dll)
    mingw32(quick3dlogicplugin.dll)
    mingw32(quick3drenderplugin.dll)
    mingw32(scene2d.dll)
    mingw32-qt6-qt3d

mingw64-qt6-qt3d:
    mingw64(assimpsceneimport.dll)
    mingw64(defaultgeometryloader.dll)
    mingw64(gltfsceneexport.dll)
    mingw64(gltfsceneimport.dll)
    mingw64(openglrenderer.dll)
    mingw64(qt63danimation.dll)
    mingw64(qt63dcore.dll)
    mingw64(qt63dextras.dll)
    mingw64(qt63dinput.dll)
    mingw64(qt63dlogic.dll)
    mingw64(qt63dquick.dll)
    mingw64(qt63dquickanimation.dll)
    mingw64(qt63dquickextras.dll)
    mingw64(qt63dquickinput.dll)
    mingw64(qt63dquickrender.dll)
    mingw64(qt63dquickscene2d.dll)
    mingw64(qt63drender.dll)
    mingw64(qtquickscene2dplugin.dll)
    mingw64(qtquickscene3dplugin.dll)
    mingw64(quick3danimationplugin.dll)
    mingw64(quick3dcoreplugin.dll)
    mingw64(quick3dextrasplugin.dll)
    mingw64(quick3dinputplugin.dll)
    mingw64(quick3dlogicplugin.dll)
    mingw64(quick3drenderplugin.dll)
    mingw64(scene2d.dll)
    mingw64-qt6-qt3d



Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10
Command line :/usr/bin/fedora-review --no-colors --prebuilt --rpm-spec --name mingw-qt6-qt3d --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg
Buildroot used: fedora-rawhide-ppc64le
Active plugins: Generic, Shell-api
Disabled plugins: Python, fonts, Perl, Java, R, PHP, Haskell, C/C++, Ocaml, SugarActivity
Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH

Comment 4 Jens Petersen 2021-08-09 15:42:35 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/mingw-qt6-qt3d

Comment 5 Sandro Mani 2021-08-09 21:02:13 UTC
Thanks!


Note You need to log in before you can comment on or make changes to this bug.