Spec URL: https://smani.fedorapeople.org/review/mingw-python-ephem.spec SRPM URL: https://smani.fedorapeople.org/review/mingw-python-pyephem-4.0.0.2-1.fc35.src.rpm Description: MinGW Windows Python pyephem Fedora Account System Username: smani
So the spec filename shows `mingw-python-ephem`, but the name of the package that is built is `mingw-python-pyephem`. You probably want to resolve that first.
Yes indeed Spec URL: https://smani.fedorapeople.org/review/mingw-python-ephem.spec SRPM URL: https://smani.fedorapeople.org/review/mingw-python-pyephem-4.0.0.2-2.fc35.src.rpm %changelog * Mon Aug 02 2021 Sandro Mani <manisandro> - 4.0.0.1-2 - Fix pkgname pyephem -> ephem Scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=73146926
Got a 404 on the SRPM url you provided, but I found the build at: https://smani.fedorapeople.org/review/mingw-python-ephem-4.0.0.2-2.fc35.src.rpm
Facepalm, missed the pyephem -> ephem there Spec URL: https://smani.fedorapeople.org/review/mingw-python-ephem.spec SRPM URL: https://smani.fedorapeople.org/review/mingw-python-ephem-4.0.0.2-2.fc35.src.rpm %changelog * Mon Aug 02 2021 Sandro Mani <manisandro> - 4.0.0.1-2 - Fix pkgname pyephem -> ephem Scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=73146926
And actually version should be 4.0.0.2 in the changelog, spec and srpm refreshed
[1] There are quite a few `non-executable-script` errors (see end of output below). https://fedoraproject.org/wiki/Packaging_tricks#Remove_shebang_from_Python_libraries [2] Include the `README.rst` from upstream in %doc. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package contains BR: python2-devel or python3-devel ===== MUST items ===== Generic: [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "Expat License", "*No copyright* Expat License". 136 files have unknown license. Detailed output of licensecheck in /var/lib/copr-rpmbuild/results/mingw-python- ephem/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [-]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in mingw32-python3-ephem , mingw64-python3-ephem [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). Rpmlint ------- Checking: mingw32-python3-ephem-4.0.0.2-2.fc35.noarch.rpm mingw64-python3-ephem-4.0.0.2-2.fc35.noarch.rpm mingw-python-ephem-4.0.0.2-2.fc35.src.rpm mingw32-python3-ephem.noarch: W: no-documentation mingw32-python3-ephem.noarch: E: non-executable-script /usr/i686-w64-mingw32/sys-root/mingw/lib/python3.10/site-packages/ephem/tests/test_angles.py 644 /usr/bin/env python mingw32-python3-ephem.noarch: E: non-executable-script /usr/i686-w64-mingw32/sys-root/mingw/lib/python3.10/site-packages/ephem/tests/test_bodies.py 644 /usr/bin/env python mingw32-python3-ephem.noarch: E: non-executable-script /usr/i686-w64-mingw32/sys-root/mingw/lib/python3.10/site-packages/ephem/tests/test_cities.py 644 /usr/bin/env python mingw32-python3-ephem.noarch: E: non-executable-script /usr/i686-w64-mingw32/sys-root/mingw/lib/python3.10/site-packages/ephem/tests/test_constants.py 644 /usr/bin/env python mingw32-python3-ephem.noarch: E: non-executable-script /usr/i686-w64-mingw32/sys-root/mingw/lib/python3.10/site-packages/ephem/tests/test_dates.py 644 /usr/bin/env python mingw32-python3-ephem.noarch: E: non-executable-script /usr/i686-w64-mingw32/sys-root/mingw/lib/python3.10/site-packages/ephem/tests/test_jpl.py 644 /usr/bin/env python mingw32-python3-ephem.noarch: E: non-executable-script /usr/i686-w64-mingw32/sys-root/mingw/lib/python3.10/site-packages/ephem/tests/test_launchpad_236872.py 644 /usr/bin/env python mingw32-python3-ephem.noarch: E: non-executable-script /usr/i686-w64-mingw32/sys-root/mingw/lib/python3.10/site-packages/ephem/tests/test_launchpad_244811.py 644 /usr/bin/env python mingw32-python3-ephem.noarch: E: non-executable-script /usr/i686-w64-mingw32/sys-root/mingw/lib/python3.10/site-packages/ephem/tests/test_locales.py 644 /usr/bin/env python mingw32-python3-ephem.noarch: E: non-executable-script /usr/i686-w64-mingw32/sys-root/mingw/lib/python3.10/site-packages/ephem/tests/test_observers.py 644 /usr/bin/env python mingw32-python3-ephem.noarch: E: non-executable-script /usr/i686-w64-mingw32/sys-root/mingw/lib/python3.10/site-packages/ephem/tests/test_rst.py 644 /usr/bin/env python mingw32-python3-ephem.noarch: E: non-executable-script /usr/i686-w64-mingw32/sys-root/mingw/lib/python3.10/site-packages/ephem/tests/test_stars.py 644 /usr/bin/env python mingw32-python3-ephem.noarch: E: non-executable-script /usr/i686-w64-mingw32/sys-root/mingw/lib/python3.10/site-packages/ephem/tests/test_usno.py 644 /usr/bin/env python mingw32-python3-ephem.noarch: E: non-executable-script /usr/i686-w64-mingw32/sys-root/mingw/lib/python3.10/site-packages/ephem/tests/test_usno_equinoxes.py 644 /usr/bin/env python mingw32-python3-ephem.noarch: W: non-standard-dir-in-usr i686-w64-mingw32 mingw64-python3-ephem.noarch: W: no-documentation mingw64-python3-ephem.noarch: E: non-executable-script /usr/x86_64-w64-mingw32/sys-root/mingw/lib/python3.10/site-packages/ephem/tests/test_angles.py 644 /usr/bin/env python mingw64-python3-ephem.noarch: E: non-executable-script /usr/x86_64-w64-mingw32/sys-root/mingw/lib/python3.10/site-packages/ephem/tests/test_bodies.py 644 /usr/bin/env python mingw64-python3-ephem.noarch: E: non-executable-script /usr/x86_64-w64-mingw32/sys-root/mingw/lib/python3.10/site-packages/ephem/tests/test_cities.py 644 /usr/bin/env python mingw64-python3-ephem.noarch: E: non-executable-script /usr/x86_64-w64-mingw32/sys-root/mingw/lib/python3.10/site-packages/ephem/tests/test_constants.py 644 /usr/bin/env python mingw64-python3-ephem.noarch: E: non-executable-script /usr/x86_64-w64-mingw32/sys-root/mingw/lib/python3.10/site-packages/ephem/tests/test_dates.py 644 /usr/bin/env python mingw64-python3-ephem.noarch: E: non-executable-script /usr/x86_64-w64-mingw32/sys-root/mingw/lib/python3.10/site-packages/ephem/tests/test_jpl.py 644 /usr/bin/env python mingw64-python3-ephem.noarch: E: non-executable-script /usr/x86_64-w64-mingw32/sys-root/mingw/lib/python3.10/site-packages/ephem/tests/test_launchpad_236872.py 644 /usr/bin/env python mingw64-python3-ephem.noarch: E: non-executable-script /usr/x86_64-w64-mingw32/sys-root/mingw/lib/python3.10/site-packages/ephem/tests/test_launchpad_244811.py 644 /usr/bin/env python mingw64-python3-ephem.noarch: E: non-executable-script /usr/x86_64-w64-mingw32/sys-root/mingw/lib/python3.10/site-packages/ephem/tests/test_locales.py 644 /usr/bin/env python mingw64-python3-ephem.noarch: E: non-executable-script /usr/x86_64-w64-mingw32/sys-root/mingw/lib/python3.10/site-packages/ephem/tests/test_observers.py 644 /usr/bin/env python mingw64-python3-ephem.noarch: E: non-executable-script /usr/x86_64-w64-mingw32/sys-root/mingw/lib/python3.10/site-packages/ephem/tests/test_rst.py 644 /usr/bin/env python mingw64-python3-ephem.noarch: E: non-executable-script /usr/x86_64-w64-mingw32/sys-root/mingw/lib/python3.10/site-packages/ephem/tests/test_stars.py 644 /usr/bin/env python mingw64-python3-ephem.noarch: E: non-executable-script /usr/x86_64-w64-mingw32/sys-root/mingw/lib/python3.10/site-packages/ephem/tests/test_usno.py 644 /usr/bin/env python mingw64-python3-ephem.noarch: E: non-executable-script /usr/x86_64-w64-mingw32/sys-root/mingw/lib/python3.10/site-packages/ephem/tests/test_usno_equinoxes.py 644 /usr/bin/env python mingw64-python3-ephem.noarch: W: non-standard-dir-in-usr x86_64-w64-mingw32 3 packages and 0 specfiles checked; 28 errors, 4 warnings. Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output: Source checksums ---------------- https://files.pythonhosted.org/packages/source/e/ephem/ephem-4.0.0.2.tar.gz : CHECKSUM(SHA256) this package : d03de73ebf6a91681d597eb5b5d43bcf6f0c67e292bba2f9a974734b4f15757e CHECKSUM(SHA256) upstream package : d03de73ebf6a91681d597eb5b5d43bcf6f0c67e292bba2f9a974734b4f15757e Requires -------- mingw32-python3-ephem (rpmlib, GLIBC filtered): mingw32(kernel32.dll) mingw32(libgcc_s_dw2-1.dll) mingw32(libpython3.10.dll) mingw32(libssp-0.dll) mingw32(msvcrt.dll) mingw32-crt mingw32-filesystem mingw64-python3-ephem (rpmlib, GLIBC filtered): mingw64(kernel32.dll) mingw64(libpython3.10.dll) mingw64(libssp-0.dll) mingw64(msvcrt.dll) mingw64-crt mingw64-filesystem Provides -------- mingw32-python3-ephem: mingw32(_libastro-cpython-310.dll) mingw32-python3-ephem mingw64-python3-ephem: mingw64(_libastro-cpython-310.dll) mingw64-python3-ephem Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10 Command line :/usr/bin/fedora-review --no-colors --prebuilt --rpm-spec --name mingw-python-ephem --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-rawhide-x86_64 Active plugins: Python, Generic, Shell-api Disabled plugins: fonts, PHP, Perl, Java, R, Ocaml, Haskell, SugarActivity, C/C++ Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
I've dropped the test files from the package. As for README.rst, I tend to omit those files in mingw packages due to [1] "There are various types of files which are simply duplicates of equivalent files found in Fedora native packages. These files should not be packaged in the MinGW package. " [1] https://fedoraproject.org/wiki/Packaging:MinGW?rd=Packaging/MinGW#Files_which_are_already_part_of_native_packages ---- Spec URL: https://smani.fedorapeople.org/review/mingw-python-ephem.spec SRPM URL: https://smani.fedorapeople.org/review/mingw-python-ephem-4.0.0.2-3.fc35.src.rpm %changelog * Mon Aug 02 2021 Sandro Mani <manisandro> - 4.0.0.2-3 - Don't install tests Scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=73151761
I just ran another built through COPR of your most recent SRPM and it still contains the test files: https://copr.fedorainfracloud.org/coprs/mhayden/review-mingw-python-ephem/build/2357131/
This one should be good (and I've also dropped docs installed below python site-packages).. Spec URL: https://smani.fedorapeople.org/review/mingw-python-ephem.spec SRPM URL: https://smani.fedorapeople.org/review/mingw-python-ephem-4.0.0.2-4.fc35.src.rpm %changelog * Mon Aug 02 2021 Sandro Mani <manisandro> - 4.0.0.2-4 - Also drop doc installed below python site-packages dir Scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=73153441
Okay, the test files were the last problem I saw and they are fixed now. Thanks! Approved.
Thanks!
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/mingw-python-ephem