Red Hat Bugzilla – Bug 198880
Review Request: perl-POE-Component-Client-DNS
Last modified: 2007-11-30 17:11:37 EST
Spec URL: http://home.comcast.net/~ckweyl/perl-POE-Component-Client-DNS.spec
POE::Component::Client::DNS provides a facility for non-blocking, concurrent DNS
requests. Using POE, it allows other tasks to run while waiting for name servers
I have to tell you that the "0" release violates the naming guidelines; please
make sure to bump this to "1" before you build.
I enabled the test suite just to try it, but I don't think it works under mock
due to an undefined network configuration. However, five of the tests did run
* source files match upstream:
O package meets naming and packaging guidelines (0 release should be 1)
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is correct.
* license field matches the actual license.
* license is open source-compatible. License text not included upstream.
* latest version is being packaged.
O BuildRequires are proper (BR: perl is redundant)
O No need to pass any compiler flags.
* %clean is present.
* package builds in mock (development, x86_64).
* rpmlint is silent.
* final provides and requires are sane:
perl(POE::Component::Client::DNS) = 0.99
perl-POE-Component-Client-DNS = 0.99-0.fc6
* noarch package; no debuginfo.
* %check is present but necessarily disabled for mock.
* no shared libraries are present.
* package is not relocatable.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no libtool .la droppings.
* not a GUI app.
Given the recent thread on the list, I'll start submitting future packages with
an initial release of 1.
+Import to CVS
+Add to owners.list
+Bump release, build for devel
+devel build succeeds
+Request branching (FC-4, FC-5)
Thanks for the review!