Bug 1989360 - Review Request: fedora-flathub-remote - Third party remote pointing to a filtered version of flathub.org
Summary: Review Request: fedora-flathub-remote - Third party remote pointing to a filt...
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Neal Gompa
QA Contact: Fedora Extras Quality Assurance
Depends On: 1989357
Blocks: 1982741
TreeView+ depends on / blocked
Reported: 2021-08-03 03:49 UTC by Owen Taylor
Modified: 2022-07-10 07:51 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Last Closed: 2022-07-10 07:51:03 UTC
Type: ---
ngompa13: fedora-review+

Attachments (Terms of Use)

Description Owen Taylor 2021-08-03 03:49:19 UTC
Spec URL: https://pagure.io/fedora-flathub-filter/raw/main/f/fedora-flathub-remote.spec
SRPM URL: https://otaylor.fedorapeople.org/fedora-flathub-remote-1-1.src.rpm
This package adds configuration to add a remote pointing to flathub.org when
third-party repositories are enabled on a Fedora Linux system. This remote is
filtered to include only specific Fedora-approved packages. (If the user
installs the Flathub remote manually, the filter is removed, and the flathub
remote is no longer managed as a third-party repository.)

See: https://fedoraproject.org/wiki/Changes/Filtered_Flathub_Applications
Fedora Account System Username: otaylor

Comment 1 Neal Gompa 2021-08-03 14:31:42 UTC
Taking this review.

Comment 2 Neal Gompa 2021-08-10 15:10:00 UTC
This package looks fairly trivial.

There are only two issues:

* Release needs to be "1%{?dist}" to include the DistTag
* Missing license file

Comment 4 Neal Gompa 2021-08-12 20:23:28 UTC
There's still no license file...

Comment 5 Owen Taylor 2021-08-12 20:38:20 UTC
Bah, sorry, messed up the update and didn't actually get the LICENSE into the package. Try again with the same URLs.

Comment 6 Neal Gompa 2021-08-12 20:39:55 UTC
Review notes:

* Package is named correctly
* Package builds and installs correctly
* Package licensing is correct and license file is installed properly
* No serious rpmlint issues



Comment 7 Gwyn Ciesla 2021-08-12 20:46:02 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/fedora-flathub-remote

Comment 8 Package Review 2022-07-10 07:51:03 UTC
Package is now in repositories, closing review.

Note You need to log in before you can comment on or make changes to this bug.