Spec URL: https://music.fedorapeople.org/fmidi.spec SRPM URL: https://music.fedorapeople.org/fmidi-0.1.1-1.fc34.src.rpm Description: Fmidi is a library to read and play back MIDI files. It supports both standard MIDI files and RIFF MIDI files. The functionality is exposed as a C programming interface, and it is implemented with C++. It is a simple library which is good for implementing a MIDI file player, or any program taking MIDI files as inputs. In fact, a player with a terminal interface is provided as an example. Fedora Account System Username: music Koji scratch builds: F35: https://koji.fedoraproject.org/koji/taskinfo?taskID=73207484 F34: https://koji.fedoraproject.org/koji/taskinfo?taskID=73207485 F33: https://koji.fedoraproject.org/koji/taskinfo?taskID=73207486
I will take this review.
This package is APPROVED. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. There are no upstream tests to run, so this is acceptable. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: The placement of pkgconfig(.pc) files are correct. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: fmidi-tools-0.1.1-1.fc36.x86_64.rpm fmidi-libs-0.1.1-1.fc36.x86_64.rpm fmidi-devel-0.1.1-1.fc36.x86_64.rpm fmidi-debuginfo-0.1.1-1.fc36.x86_64.rpm fmidi-debugsource-0.1.1-1.fc36.x86_64.rpm fmidi-0.1.1-1.fc36.src.rpm fmidi-libs.x86_64: W: no-documentation fmidi.src:123: W: macro-in-%changelog %autochangelog 6 packages and 0 specfiles checked; 0 errors, 2 warnings. Rpmlint (debuginfo) ------------------- Checking: fmidi-libs-debuginfo-0.1.1-1.fc36.x86_64.rpm fmidi-tools-debuginfo-0.1.1-1.fc36.x86_64.rpm fmidi-debuginfo-0.1.1-1.fc36.x86_64.rpm 3 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- rpmlint: 2.0.0 configuration: /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/licenses.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 4 fmidi-libs.x86_64: E: shlib-policy-name-error 0.1 fmidi-tools.x86_64: W: no-manual-page-for-binary fmidi-convert fmidi-tools.x86_64: W: no-manual-page-for-binary fmidi-grep fmidi-tools.x86_64: W: no-manual-page-for-binary fmidi-play fmidi-tools.x86_64: W: no-manual-page-for-binary fmidi-read fmidi-tools.x86_64: W: no-manual-page-for-binary fmidi-seq fmidi-devel.x86_64: W: missing-dependency-on fmidi*/fmidi-libs/libfmidi* = 0.1.1 ================= 3 packages and 0 specfiles checked; 1 errors, 6 warnings, 1 badness; has taken 0.3 s ================= Source checksums ---------------- https://github.com/jpcima/fmidi/archive/v0.1.1/fmidi-0.1.1.tar.gz : CHECKSUM(SHA256) this package : 65b8ba2290d4c41dbe251fb220dfab3308512a3ebf62f27916fd45cf94716e7d CHECKSUM(SHA256) upstream package : 65b8ba2290d4c41dbe251fb220dfab3308512a3ebf62f27916fd45cf94716e7d Requires -------- fmidi-tools (rpmlib, GLIBC filtered): fmidi-libs(x86-64) libc.so.6()(64bit) libev.so.4()(64bit) libfmidi.so.0.1()(64bit) libfmt.so.8()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libncurses.so.6()(64bit) librtmidi.so.4()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libtinfo.so.6()(64bit) rtld(GNU_HASH) fmidi-libs (rpmlib, GLIBC filtered): ld-linux-x86-64.so.2()(64bit) libc.so.6()(64bit) libfmt.so.8()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) rtld(GNU_HASH) fmidi-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config fmidi-libs(x86-64) libfmidi.so.0.1()(64bit) fmidi-debuginfo (rpmlib, GLIBC filtered): fmidi-debugsource (rpmlib, GLIBC filtered): Provides -------- fmidi-tools: fmidi-tools fmidi-tools(x86-64) fmidi-libs: fmidi-libs fmidi-libs(x86-64) libfmidi.so.0.1()(64bit) fmidi-devel: fmidi-devel fmidi-devel(x86-64) pkgconfig(fmidi) fmidi-debuginfo: fmidi-debuginfo fmidi-debuginfo(x86-64) fmidi-debugsource: fmidi-debugsource fmidi-debugsource(x86-64) Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10 Command line :/usr/bin/fedora-review -b 1989592 -m fedora-rawhide-x86_64 Buildroot used: fedora-rawhide-x86_64 Active plugins: C/C++, Generic, Shell-api Disabled plugins: SugarActivity, PHP, Ruby, R, Perl, Ocaml, fonts, Java, Haskell, Python Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
Thanks for the review!
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/fmidi
FEDORA-2021-b9f8ee66ff has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-b9f8ee66ff
FEDORA-2021-a22b4cd39d has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2021-a22b4cd39d
FEDORA-2021-b9f8ee66ff has been pushed to the Fedora 34 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-b9f8ee66ff \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-b9f8ee66ff See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2021-a22b4cd39d has been pushed to the Fedora 33 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-a22b4cd39d \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-a22b4cd39d See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2021-b9f8ee66ff has been pushed to the Fedora 34 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2021-a22b4cd39d has been pushed to the Fedora 33 stable repository. If problem still persists, please make note of it in this bug report.