Bug 1989610 - Unsupported data types should not be rendered on operand details page
Summary: Unsupported data types should not be rendered on operand details page
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Management Console
Version: 4.8
Hardware: Unspecified
OS: Unspecified
low
low
Target Milestone: ---
: 4.11.0
Assignee: Jon Jackson
QA Contact: Xiyun Zhao
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-08-03 14:40 UTC by Jon Jackson
Modified: 2022-09-07 07:53 UTC (History)
6 users (show)

Fixed In Version:
Doc Type: No Doc Update
Doc Text:
Clone Of:
Environment:
Last Closed: 2022-08-10 10:36:52 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github openshift console pull 11433 0 None open Bug 1989610: Don't render empty div for invalid descriptors. 2022-05-10 14:17:54 UTC
Github openshift console pull 9763 0 None None None 2021-08-09 20:33:06 UTC
Red Hat Product Errata RHSA-2022:5069 0 None None None 2022-08-10 10:37:19 UTC

Description Jon Jackson 2021-08-03 14:40:58 UTC
Description of problem:
Currently we display "Unsupported" on the Operand details page when a descriptor falls through to the default details item and is not a primitive data type:

https://github.com/openshift/console/blob/10788fddfaaed31f0b5b64d34690d5a5f324652a/frontend/packages/operator-lifecycle-manager/src/components/descriptors/common.tsx#L33-L35

This causes confusion as it's not clear that the message only relates to the field data type and not the field itself.

Version-Release number of selected component (if applicable):
4.8

How reproducible:
Always

Steps to Reproduce:
1. Create the CRD, CSV, and Operand from this gist in the default namespace: https://gist.github.com/TheRealJon/3680c8a573bde88a974588e269230562
2. Navigate to /k8s/ns/default/clusterserviceversions/mock-operator/test.tectonic.com~v1~MockResource/mock-resource-instance
3. Look for the Field Group detail item on the resulting page

Actual results:
The item exists and renders the message "Unsupported"

Expected results:
Since the data type is not supported, we should not render a detail item

Comment 3 Xiyun Zhao 2021-09-01 07:38:35 UTC
Hi Jackson,

After verified this bug on OCP4.9.As you said, since the data type is not supported, we should not render a detailed item. 
But the layout of the page does not seem correct, a blank part will instead of the properties.
If more than one field with the unsupported data type, the page will look discordances (shared a snapshot)
Please help to take a look

Thanks

Comment 9 Jon Jackson 2022-05-17 14:35:29 UTC
@xiyuzhao I've addressed your comment in my latest PR. This should be fixed now.

Comment 10 Xiyun Zhao 2022-05-19 09:03:41 UTC
This bug has been verified and payload 4.11.0-0.nightly-2022-05-18-053037

Verification Step
1. Follow the reproduce steps on Bug description
   1) Create the CRD, CSV, and Operand from this gist in the default namespace: https://gist.github.com/TheRealJon/3680c8a573bde88a974588e269230562
   2) Navigate to /k8s/ns/default/clusterserviceversions/mock-operator/test.tectonic.com~v1~MockResource/mock-resource-instance
   3) Look for the Field Group detail item on the resulting page
2. Verify if the "Unsupported" data type is still rendered detail item on the page

Result:
2. The unsupported data type will not render details on the page, and no layout issue is found on the page

Comment 12 errata-xmlrpc 2022-08-10 10:36:52 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Important: OpenShift Container Platform 4.11.0 bug fix and security update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2022:5069


Note You need to log in before you can comment on or make changes to this bug.