Bug 1989677 - Upgrading Pipelines Operator from v1.2.3 to v1.4.1 fails
Summary: Upgrading Pipelines Operator from v1.2.3 to v1.4.1 fails
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Red Hat OpenShift Pipelines
Classification: Red Hat
Component: pipelines
Version: 1.4
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: ---
: ---
Assignee: Nikhil Thomas
QA Contact: Ruchir Garg
Robert Krátký
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-08-03 17:32 UTC by Divya
Modified: 2025-10-03 11:11 UTC (History)
13 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2022-06-02 09:45:40 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)

Description Divya 2021-08-03 17:32:57 UTC
Description of problem:
Upgrading Pipelines Operator from v1.2.3 to v1.4.1(stable channel) fails with below error messages: 

    {},"logging.googleapis.com/sourceLocation":{"file":"/opt/app- 
root/src/go/src/github.com/tektoncd/operator/vendor/knative.dev/pkg/client/injection/kube/reconciler/core/v1/namespace/controller.go","line":"119","function":"knative.dev/pkg/client/injection/kube/reconciler/core/v1/namespace.createRecorder"}}
panic: The environment variable "METRICS_DOMAIN" is not set


Version-Release number of selected component (if applicable):
1.4.1

How reproducible:
Always

Steps to Reproduce:
1. Install Pipelines Operator v1.2.3 (stable channel)
2. Upgrade the operator to v1.4.1
3.

Actual results:
It fails with error

Expected results:
It should be updated to latest version as selected 

Additional info:
Manually adding the the METRICS_DOMAIN environment variable to the pipeline operator YAML appears to resolve the issue and allows the pipeline operator to deploy successfully 

----------------------
              spec:
                containers:
                  - command:
                      - openshift-pipelines-operator
                    env:
                      - name: METRICS_DOMAIN
                        value: tekton.dev/triggers
---------------

Comment 2 Vincent Demeester 2021-08-09 15:46:37 UTC
As commented in https://bugzilla.redhat.com/show_bug.cgi?id=1991637

I think the workaround here (before we do a bugfix release) is to add the following to the `openshift-pipelines-operator` deployment in `openshift-operators` namespace:

```
env:
  - name: METRICS_DOMAIN
    value: tekton.dev/operator

```

Comment 3 Vincent Demeester 2021-08-09 15:50:59 UTC
Based on https://github.com/operator-framework/operator-lifecycle-manager/blob/master/doc/design/subscription-config.md#configuring-operators-deployed-by-olm I think the "cleanest" workaround here would be to edit the OpenShift Pipelines operator with the following (in spec)

```
apiVersion: operators.coreos.com/v1alpha1
kind: Subscription
metadata:
  # […]
  name: openshift-pipeline-operator
  namespace: openshift-operators
  # […]
spec:
  # […]
  config:
    env:
      - name: METRICS_DOMAIN
        value: tekton.dev/operator
  name: openshift-pipelines-operator-rh
  # […]
```

Comment 5 Novonil Choudhuri 2021-08-09 20:18:18 UTC
From customer :

I applied the change and delete the pods controlled by deployment “openshift-pipelines-operator” in “openshift-operators” namespace this action did resolve the crash I reported earlier. Also yes we are running “OpenShift-Serverless” on test/validation cluster as well.

Comment 7 jdee 2022-03-10 15:37:01 UTC
Is there any update on this ticket? The cu is looking for a update.

Comment 9 Nikhil Thomas 2022-05-19 06:44:12 UTC
@dbasant is the customer still using OpenShift Pipelines 1.4.1.

as @nchoudhu mentioned the suggested workaround has got upgrade moving.

Is that good enough.

In addition, I shall discuss this with my team and get an update.

Comment 10 Nikhil Thomas 2022-05-19 06:44:39 UTC
@dbasant is the customer still using OpenShift Pipelines 1.4.1.

as @nchoudhu mentioned the suggested workaround has got upgrade moving.

Is that good enough.

In addition, I shall discuss this with my team and get an update.

Comment 12 Nikhil Thomas 2022-06-02 09:44:53 UTC
@skanniha Thank you.
I shall close this bug.


Note You need to log in before you can comment on or make changes to this bug.