Bug 198975 - fdisk_wrapper.py has missing option-parm in sfdisk command
Summary: fdisk_wrapper.py has missing option-parm in sfdisk command
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Fedora
Classification: Fedora
Component: system-config-lvm
Version: 5
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Stanko Kupcevic
QA Contact: Jim Parsons
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2006-07-15 08:03 UTC by James G. Sack
Modified: 2007-11-30 22:11 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2006-12-18 21:50:06 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description James G. Sack 2006-07-15 08:03:06 UTC
Description of problem:
 from inspection, line 56 of fdisk_wrapper.py seems to omit an option parm for 
the sfdisk -u option.

 s/'-u', devname/'-u', 's', devname/

Version-Release number of selected component (if applicable):
 system-config-lvm-1.0.18-1.2.FC5

How reproducible:
 I haven't actually seen any consequences, haven't tried to cause an error, but 
runninf sfdisk -u without a units parm causes the devname arg to be ignored, 
which I presume could cause confusion.

Regards,
..jim

Comment 1 James G. Sack 2006-07-15 08:11:44 UTC
I believe I should have suggested an 'S' arg rather than 's'.

Another way to state it is to make line 56 look like line 87, which would give
  res = execWithCapture(SFDISK, [SFDISK, '-l', '-uS', devname]) 

..jim

Comment 2 Stanko Kupcevic 2006-12-18 21:50:06 UTC
Line 56 uses fdisk (which doesn't allow argument to -u option), and not sfdisk,
which is in use on line 87. 


Note You need to log in before you can comment on or make changes to this bug.