Bug 1990134 - Fix data corruption in nbdkit-cow-filter and nbdkit-cache-filter
Summary: Fix data corruption in nbdkit-cow-filter and nbdkit-cache-filter
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat Enterprise Linux 9
Classification: Red Hat
Component: nbdkit
Version: 9.0
Hardware: Unspecified
OS: Unspecified
high
high
Target Milestone: beta
: ---
Assignee: Virtualization Maintenance
QA Contact: mxie@redhat.com
URL:
Whiteboard:
Depends On:
Blocks: 1990135 2040775
TreeView+ depends on / blocked
 
Reported: 2021-08-04 19:56 UTC by Richard W.M. Jones
Modified: 2022-01-14 16:40 UTC (History)
10 users (show)

Fixed In Version: nbdkit-1.26.3-1.el9
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
: 1990135 (view as bug list)
Environment:
Last Closed: 2021-12-07 21:35:16 UTC
Type: Bug
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Issue Tracker RHELPLAN-92397 0 None None None 2021-08-04 19:58:29 UTC

Description Richard W.M. Jones 2021-08-04 19:56:37 UTC
Description of problem:

A data corrupter bug has been identified in the following
nbdkit filters:

https://libguestfs.org/nbdkit-cow-filter.1.html
https://libguestfs.org/nbdkit-cache-filter.1.html

It's quite subtle, but it affects modular virt-v2v and was
picked up by Ming Xie during testing.

The full bug is described in this link, as well as a simple way
to reproduce it, and the fix:

https://listman.redhat.com/archives/libguestfs/2021-August/msg00044.html

Version-Release number of selected component (if applicable):

All versions of nbdkit since 1.14 up to 1.27.4

How reproducible:

100%

Steps to Reproduce:
1. See link above.

Comment 3 mxie@redhat.com 2021-08-06 05:44:56 UTC
Reproduce the bug with nbdkit-1.26.2-2.el9.x86_64 

Steps to reproduce:

1. # nbdkit --filter=cow data "33 * 100000" --run 'nbdsh -u $uri -c "h.trim(100000, 0)" ; nbdcopy $uri - | hexdump -C'
00000000  00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00  |................|
*
00010000  21 21 21 21 21 21 21 21  21 21 21 21 21 21 21 21  |!!!!!!!!!!!!!!!!|
*
000186a0


Verify the bug with nbdkit-1.26.3-1.el9.x86_64

Steps:
1.# nbdkit --filter=cow data "33 * 100000" --run 'nbdsh -u $uri -c "h.trim(100000, 0)" ; nbdcopy $uri - | hexdump -C'
00000000  00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00  |................|
*
000186a0


Result:
   The bug has been fixed, so move the bug from ON_QA to VERIFIED


Note You need to log in before you can comment on or make changes to this bug.