Bug 1990193 - 'more' and 'Show Less' is not being translated on Home -> Search page
Summary: 'more' and 'Show Less' is not being translated on Home -> Search page
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Management Console
Version: 4.9
Hardware: All
OS: All
Target Milestone: ---
: 4.10.0
Assignee: Jakub Hadvig
QA Contact: Xiyun Zhao
Depends On: 1986754
TreeView+ depends on / blocked
Reported: 2021-08-05 01:25 UTC by Xiyun Zhao
Modified: 2022-03-12 04:37 UTC (History)
6 users (show)

Fixed In Version:
Doc Type: No Doc Update
Doc Text:
Clone Of: 1986754
Last Closed: 2022-03-12 04:37:00 UTC
Target Upstream Version:

Attachments (Terms of Use)

System ID Private Priority Status Summary Last Updated
Github openshift console pull 10099 0 None open Bug 1990193: Internationalize Search page ToolbarFilter props 2021-09-17 19:53:59 UTC
Red Hat Product Errata RHSA-2022:0056 0 None None None 2022-03-12 04:37:13 UTC

Comment 1 Xiyun Zhao 2021-08-05 01:31:18 UTC
This bug is created for an issue that is not being fixed on Bug 1986754.

The issue of 'more' and 'Show Less' is not being translated also needs to check on Home -> Search page

Comment 2 ralpert 2021-08-05 02:13:56 UTC
We are not using the ChipGroup component on the Search page. Instead, we're using it indirectly using a different PatternFly component. I suspect we will need to file a bug with PatternFly to get access to the props needed to pass in the translated text.

Comment 3 ralpert 2021-08-05 20:38:05 UTC
I took a look at the PatternFly code and we'll need to add additional props to the ToolbarFilter component so we can pass in internationalized text to the ToolbarFilter's internal ChipGroup. This fix may take a bit since we'll have to get it into PatternFly, upgrade, and then make the update on our end. I can get started on the PF side though.

Comment 4 ralpert 2021-08-05 21:01:38 UTC
PatternFly PR is here: https://github.com/patternfly/patternfly-react/pull/6138

We'll have to wait for it to merge before we can do anything else for this particular bug.

Comment 5 ralpert 2021-08-16 17:36:49 UTC
My PatternFly PR is included in @patternfly/react-core release 4.148.1. We are currently on @patternfly/react-core" 4.135.15. We will need to upgrade in order to fix this bug on the OpenShift side.

Comment 6 ralpert 2021-08-16 17:49:00 UTC
Spoke to Joe Caiani and he said we upgrade on every major PF release. The next release will be around 8/23, depending when the PF team completes testing and the OS team completes integration testing. This bug won't be able to move until we upgrade to a version that contains the fix.

Comment 7 ralpert 2021-09-03 14:17:42 UTC
We still haven't upgraded PF yet and can't move further on this bug.

Comment 8 ralpert 2021-09-13 20:04:28 UTC
We are currently on "@patternfly/react-core": "4.147.2", but require 4.148.1+ to fix this bug. It may be another month before we can address this in OpenShift.

Comment 9 ralpert 2021-09-17 14:42:33 UTC
It looks like a colleague just updated us, so I will try to get this fix up today!

Comment 12 Xiyun Zhao 2021-09-26 02:51:45 UTC
This bug has been fixed and verified on payload 4.10.0-0.nightly-2021-09-23-210724

Verification Steps:
1. Login OpenShift Web console
2. The language preference set to Simplified Chinese language
3. In Administrator, access Home -> Search dashboard 
3. In Events, check some resource filters, in resource bar, 'more' is hardcoded and not translated in Simplified Chinese language.
4. Click 'more' button, display the selected resources, 'Show Less' is hardcode and not translated too.

'more' and 'Show Less' have been translated to the correct language.

Comment 17 errata-xmlrpc 2022-03-12 04:37:00 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: OpenShift Container Platform 4.10.3 security update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.


Note You need to log in before you can comment on or make changes to this bug.