Fedora Account System
Red Hat Associate
Red Hat Customer
Spec URL: https://dcavalca.fedorapeople.org/review/rust-displaydoc/rust-displaydoc.spec SRPM URL: https://dcavalca.fedorapeople.org/review/rust-displaydoc/rust-displaydoc-0.2.3-1.fc35.src.rpm Description: Derive macro for implementing the display Trait via a doc comment and string interpolation. Fedora Account System Username: dcavalca
This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=73335632
Package was generated with rust2rpm, simplifying the review. - package builds and installs without errors on rawhide - test suite is run and all unit tests pass - latest version of the crate is packaged - license matches upstream specification and is acceptable for Fedora - license file is included with %license in %files - package complies with Rust Packaging Guidelines Four minor issues: 1) The value for the Summary tag is too long. E: summary-too-long C Derive macro for implementing the display Trait via a doc comment and string interpolation Please trim this to some sensible shorter version. 2) Also, leave the "# Initial patched metadata" comment intact. It's basically a marker for "this patch was generated automatically by rust2rpm -p, do this again if you're updating this package". 3) Please file a PR with https://github.com/yaahc/displaydoc with the static_assertions bump. 4) Please drop "README.tpl" (a cargo-readme template file?) and "examples" from %doc. They are both useless in Fedora. Other than that, Package APPROVED.
Thanks! Will get this fixed before importing. $ fedpkg request-repo rust-displaydoc 1990500 https://pagure.io/releng/fedora-scm-requests/issue/36557
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-displaydoc